From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org
Cc: heikki.krogerus@linux.intel.com,
kernel test robot <lkp@intel.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Make configure_mux static
Date: Thu, 25 Jun 2020 13:57:06 +0200 [thread overview]
Message-ID: <1a05b712-0617-dc57-6099-dd4a072af9f9@collabora.com> (raw)
In-Reply-To: <20200620020038.230887-1-pmalani@chromium.org>
Hi Prashant,
On 20/6/20 4:00, Prashant Malani wrote:
> Since cros_typec_configure_mux() is only used in cros-ec-typec,
> it should be marked static.
>
> Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Applied for 5.9
> ---
> drivers/platform/chrome/cros_ec_typec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 509fc761906b..1df1386f32e4 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -428,9 +428,9 @@ static int cros_typec_enable_dp(struct cros_typec_data *typec,
> return typec_mux_set(port->mux, &port->state);
> }
>
> -int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> - uint8_t mux_flags,
> - struct ec_response_usb_pd_control_v2 *pd_ctrl)
> +static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> + uint8_t mux_flags,
> + struct ec_response_usb_pd_control_v2 *pd_ctrl)
> {
> struct cros_typec_port *port = typec->ports[port_num];
> enum typec_orientation orientation;
>
prev parent reply other threads:[~2020-06-25 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 2:00 Prashant Malani
2020-06-25 11:57 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a05b712-0617-dc57-6099-dd4a072af9f9@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®