From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFAC208BA for ; Fri, 19 Jul 2024 08:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721377697; cv=none; b=hDA9T0BQAgnQlgy25xPmNfzLLHeNFoE+mzwJtcNhjmJBO9dvoRN/ioZum/kFXhgS8q8Y6sm0UDdaD7UGxnozmJU48RgSDyl4YIoXmkJNm5FLz9G0LcNjZ+5tADr6a8tiKU0MaQiMbzSgaaMXDMgqDA8Ma2h7OwI4PihjAoNu+lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721377697; c=relaxed/simple; bh=uWPARPGNpau4+HY+lZwmXboy9UGPd32fjMChKTLhLKU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SLgUyAq66DNdXelFGZfqonIQdtmidSTfTlAWfXgTW5Bc6wJk7Hwdczv0UyhvY+jww+GtasKfXcuF5e/4pJ9KwDAwEtuETyiEaOLoy//DwHAtJGw4zw9UqmqPQHMcIeGr98KGmxk8PH0gX5oBwlHpqOYJq+AN4tdzhEH+Lguou7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EX1yyxUy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EX1yyxUy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721377695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RRex67Mz8epoWANX5IYCXnoNaj4foCtRpW//w2kagY4=; b=EX1yyxUyBEn9AtMuop9/narqlMreUPa3r5DFr6nHCRJ1YtVP+AF5JSiocYz30xuMTM1NY7 FFbm/xwNXpgDOa+fK+fbCxSux4TZPX5oaJYX1CjuSLCif8kSBFpEgkqjuXYfNBHy0JwgCy N1gOEiML+KSS/smYWS/YW58KDJs6Hv4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-fbfNDR4OOYaCgUKrD8KLNg-1; Fri, 19 Jul 2024 04:28:13 -0400 X-MC-Unique: fbfNDR4OOYaCgUKrD8KLNg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4265d3bf59dso10028645e9.3 for ; Fri, 19 Jul 2024 01:28:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721377692; x=1721982492; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RRex67Mz8epoWANX5IYCXnoNaj4foCtRpW//w2kagY4=; b=dKwG+M+iqGVwYGICNXnHDEtQPKSrrV7QNh264Hip0ryUk9skUfXtoKi5nwzmR8vse7 37wNEclHrf2YvU8tOdXto9PJkys1NcWM363mlZ+kjMGsxZnckFveBGptABZI8XiVrK74 AFWB4g5fUgyexAUiXNnBwi3Zxre9veWmCD1aRRZQkQ5ppZ1szzHbk0XmGNd935t9s2UI Ds9YvUIgPZXc/GvkPYliDrTkj7eTR8LaDWqtsV90pfjtDLhwZ9/6qqQW7Tt/+gJPFjT5 rc0p22emOv3fjHTCvbnNYKkt64cqBCUc2pxM6KyykTtDRxNLaJKeIkjLGLcxIzHBL2pG rOpg== X-Gm-Message-State: AOJu0YwtiVQx1gZ4Cobdwvmtu46bV4Wvx+M0AIbt/FW9Cn2PVWvNhwof niimaBJXfunh8yJ/Qp+LwDMhXmn4sLeXj5zaf5UcgZQrYVzxteW3HOZIMet2bJPqVcJLk+at/s3 VPvvQ2M5/RTC9A5qjsFGp+33fngNJTxSEgjFo1+EI2Qx3/rsyUHQLzNbUF+okbA== X-Received: by 2002:a05:600c:1c03:b0:426:668f:5eca with SMTP id 5b1f17b1804b1-427c2c99b70mr47225885e9.7.1721377691929; Fri, 19 Jul 2024 01:28:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9el61BzvNN7OiAoaIackyBdrRqSv7IvxZKq4Eq22fjV+zSZ1D7W4iI1PPo1840RGDlLtPmg== X-Received: by 2002:a05:600c:1c03:b0:426:668f:5eca with SMTP id 5b1f17b1804b1-427c2c99b70mr47225705e9.7.1721377691478; Fri, 19 Jul 2024 01:28:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1000:c4af:a24f:b8ba:8bbc? (p200300cbc7051000c4afa24fb8ba8bbc.dip0.t-ipconnect.de. [2003:cb:c705:1000:c4af:a24f:b8ba:8bbc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a3c0fasm44307985e9.7.2024.07.19.01.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 01:28:11 -0700 (PDT) Message-ID: <1a0884cb-39ed-455e-a505-7c1b2a0e5225@redhat.com> Date: Fri, 19 Jul 2024 10:28:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/x86/pat: Only untrack the pfn range if unmap region To: Yan Zhao , Peter Xu Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Alex Williamson , Jason Gunthorpe , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , "x86@kernel.org" , "Tian, Kevin" , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky References: <20240712144244.3090089-1-peterx@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.07.24 01:18, Yan Zhao wrote: > On Thu, Jul 18, 2024 at 10:03:01AM -0400, Peter Xu wrote: >> On Thu, Jul 18, 2024 at 09:50:31AM +0800, Yan Zhao wrote: >>> Ok. Then if we have two sets of pfns, then we can >>> 1. Call remap_pfn_range() in mmap() for pfn set 1. >> >> I don't think this will work.. At least from the current implementation, >> remap_pfn_range() will only reserve the memtype if the range covers the >> whole vma. > Hmm, by referring to pfn set 1 and pfn set 2, I mean that they're both > covering the entire vma, but at different times. > > To make it more accurately: > > Consider this hypothetical scenario (not the same as what's implemented in > vfio-pci, but seems plausible): > > Suppose we have a vma covering only one page, then > (1) Initially, the vma is mapped to pfn1, with remap_pfn_range(). > (2) Subsequently, unmap_single_vma() is invoked to unmap the entire VMA. > (3) The driver then maps the entire vma to pfn2 in fault handler > > Given this context, my questions are: > 1. How can we reserve the memory type for pfn2? Should we call > track_pfn_remap() in mmap() in advance? > 2. How do we untrack the memory type for pfn1 and pfn2, considering they > belong to the same VMA but mutual exclusively and not concurrently? Do we really have to support such changing PFNs in a VMA? Are there existing use cases that would rely on that? Would it be a problem if we would merge the mmap+track_pfn_remap, such that such a special VMA can only ever belong to a single PFN range, that is fixed, but PFNs can be faulted in lazily? -- Cheers, David / dhildenb