From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31FDD221265 for ; Wed, 21 May 2025 15:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842095; cv=none; b=Lvvhhj4tWiHfTXHxbSX8nf/n3pPRsQdW8yimIm8UaEBqeTQfOkVoZJIMWbVsgIa+Y10SOcgiVsN2ZYpgsWlXjBqc872fTBkgw2zVH5Lf8fjXGH0dDQqvnfav8ca2A9RthYpYygN/QREMSRWEdZAk2K4rVCsFWxmTvKNT3ykCAIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842095; c=relaxed/simple; bh=0Hm0voyeDVNLto4h3bUVaIJA2qzEuKKWBY8Rt1tYC7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uzLwZxa8Tj2126XndIF7Uidt4CKkEpWBEWZ128atcwc5uMfXjxUqLqGYuK+Jk3pJMKv68YEbhL7HyczYkmXw1q/YIVV08IaDDbUC63KBYwY0PXwYBqJdv2zNMRnqyGUq+610cUbqB+xCqY9MZXSZh96iF/PosEk1hOXGEnVEpEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B7IMEbTG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B7IMEbTG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54L9XKN6020574 for ; Wed, 21 May 2025 15:41:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 11xIrqs7y33esKOfbwtRMscbBQ+xSYJyjFlpp1MuMfc=; b=B7IMEbTGShkwi76/ Ixsqiho8zgp9Eae1mE6FPZiZayqVcz9zQ9p9WgC2WgMqZd2drKbPeGs5swIsjhFP kvh9G8MbVBxKyNAvisHQ2XeS5rtedgq+iLDdau/SWbV/y32cyzNgJzi3HbwTR2Q/ 65pwKZMuV+ArOrAQat12+JNHl9B8fnW3MpR4VFXMOvN6K+WdrDIxkl7sAWRbm0P/ W5CjVMHnW9GrVRQDaB2KIZM0NpbUwdpt3feL+Sn1x8b8NwotyDqJkqTvJ88YfYrB /8IUAuS8RAbZkB2W2ABwNj3DTb7ePwaD+ua6Vxhqz10GwkjfRaBbMJc5oS+vnMef +mo2PQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46s9pb1qan-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 21 May 2025 15:41:32 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4766afee192so194620711cf.0 for ; Wed, 21 May 2025 08:41:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747842091; x=1748446891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=11xIrqs7y33esKOfbwtRMscbBQ+xSYJyjFlpp1MuMfc=; b=ZQVU8p6kzyIvqlRXX0Lvk4H0YS3Qg/SOJK9ti/9WDRVgurhm7obvQaa4gz3zxWJNZ6 b4/8GK4q9uJ1dFO04QPN5FKtPuTOQxU1COW24gck0manmgYRIye0hF3H/zABDi9KVbUg rUkSMlMBnX4R3pgS1VNeVcICU3g1XZqjugnbYZhTOU671LYXqpTfC9OJnz+HOwQoT0Eo WleA+gg/Oe4ch6j5tXKSfPtsZDmzM4iUJSaBoUwd0siznDXItJVz3TEY79MyPwG8zxhv G9KR2LMFZujKUb4insd9pfq3g0ObvWDoaHBcDx/qWAL4qqcwjACDe2Ld12HmOZcRhJuo LELw== X-Forwarded-Encrypted: i=1; AJvYcCWWLF2uo7yAHUlCCyN/+mclI+DBFZGjvSghxsWf3UoFPABgX6t+IiJ3WJ25cHrVyIa704LpYWLRrFKUfUw=@vger.kernel.org X-Gm-Message-State: AOJu0YywrIFl7fpppAH9mDaoiS0SmzB/ekWmaJW5kBueFbKhHZXcyX7y MHKucAvgD0SXy9re4C7yHdbpOEqlGdvidqd7rl3u1qwoplVayGNB9i9OO/wtls8sU79MJjh7PZO rhWjcjG13JzLMMIgvUBQO6eTqWoL9oI6UwaszIUqfBgt+k0MhWKrP+sN4uSXcZocVjAA= X-Gm-Gg: ASbGnct2ThTBKOfgptcaxwf+lUTuTnxgyuBj+ddfTE2VRBRLyypFjXNejr5gJ/OkNE9 Ok2M9LmcIb3XU+V+IlQ9KREPL1jfahi1NhEtTVQ7RNDIpl+awTpC5+yjVl96EaxRHd/IorYbBOk oFvlSC0YuzvV6GKTfPYGA0aSepcNHcQvGQ2WBBApPHKnUzGQJG8PV4oLpgFZOxYHeM2UB4Df2FG PHS9UryzryXrqYCGVbyAAh5+40RUNocV5W1w6ZFBmXLoG+nmarhaOFIET4ACZXJF9TTT64eXhGP 5Q/qnNF7CTk5Cyc5ydSG7sBW5SE7cGRqrzzK5ZHzWUt12kmtQf1TslO2b4r6bCB8Bfm2SKIVVlT 50ZbIwmjjyVyYVONOlprwEkYlbfV7Gu5PXSmz/u5806kIGrA16SYE+p5L1/yvKMRX X-Received: by 2002:a05:622a:5c96:b0:477:64b0:6a21 with SMTP id d75a77b69052e-494b07d98e2mr375789591cf.23.1747842091614; Wed, 21 May 2025 08:41:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzymVPyAEezG0iALlrdblH7qdHofBk2xTG0MRCZc7og2yUqLNV3+TUUJqDglHgQSrVGu3AZg== X-Received: by 2002:a05:622a:5c96:b0:477:64b0:6a21 with SMTP id d75a77b69052e-494b07d98e2mr375789091cf.23.1747842091152; Wed, 21 May 2025 08:41:31 -0700 (PDT) Received: from ?IPV6:2001:14bb:c7:69ba:b852:d3f4:8957:5a1e? (2001-14bb-c7-69ba-b852-d3f4-8957-5a1e.rev.dnainternet.fi. [2001:14bb:c7:69ba:b852:d3f4:8957:5a1e]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55208f7b362sm389589e87.236.2025.05.21.08.41.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 08:41:30 -0700 (PDT) Message-ID: <1a0a5178-fcf0-49b6-8e4c-1393c0f4f229@oss.qualcomm.com> Date: Wed, 21 May 2025 18:41:27 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] mmc: sdhci-msm: Enable MMC_CAP_AGGRESSIVE_PM for qualcomm controllers To: Sarthak Garg Cc: Adrian Hunter , Ulf Hansson , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com, kernel@quicinc.com References: <20241104060722.10642-1-quic_sartgarg@quicinc.com> <10c90fee-ce7f-4034-9028-4252f19cb67f@quicinc.com> <064d3eed-c2ea-4b41-85b2-d2a5a922f8c7@quicinc.com> <48c73675-a73f-46f1-81a9-f701a2cf00a5@quicinc.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=WJl/XmsR c=1 sm=1 tr=0 ts=682df42c cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=Kn0oP55XQ_SHoSlfIoAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: VmLI7pzUJcGgwp9QG5v9cSNfiwSE1NaQ X-Proofpoint-GUID: VmLI7pzUJcGgwp9QG5v9cSNfiwSE1NaQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIxMDE1MyBTYWx0ZWRfX19LYS+2THUx8 4zNDoxVJcWtcRhDktr/KDMKjZNFUUxRkt2/5MbtZr/ljsYDhtPp69tpJCxw1tB57DXWhsSsNkZY 7KFTkBDhP8o+A4yLIsGLEpaASL4Liwmbkg9NQ15DxmB9MKjt8RhW3HKuE0ps/oyw4890KFb64QK 8OhBwpgcgCvTlDMJVtu40Zf0qbmg+opXP7e+IZ+onArarOp54W+GM7Q8rUkUxaHcW+C73KnEhNy R3sArFAWDSSTTQbp35IGRxhX4ZutjusPq2Yi0j6vLLWX7qne2CslO0eQkoJptibaHNAaMJPQ2I3 LS4T8Ahtdgl5FerCSkjiGXhFb3qVOBs6TOhZtF08jw60epHCtRsU+YA9quSm/nAUHPTLbdGhOL5 CwyMMMbuw9luDZrTJksGSJsj+OwG2u16pO7aZEPg7gwJAUnREEWXr7YCJA14047c/lOS8WQ5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-21_05,2025-05-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 mlxscore=0 adultscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505210153 On 21/05/2025 18:36, Sarthak Garg wrote: > > > On 5/21/2025 8:19 PM, Dmitry Baryshkov wrote: >> On 21/05/2025 17:35, Sarthak Garg wrote: >>> >>> >>> On 5/21/2025 6:25 PM, Dmitry Baryshkov wrote: >>>> On Wed, May 21, 2025 at 12:46:49PM +0530, Sarthak Garg wrote: >>>>> >>>>> >>>>> On 11/15/2024 6:53 PM, Dmitry Baryshkov wrote: >>>>>> On Fri, 15 Nov 2024 at 12:23, Sarthak Garg >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 11/4/2024 4:19 PM, Dmitry Baryshkov wrote: >>>>>>>> On Mon, Nov 04, 2024 at 11:37:22AM +0530, Sarthak Garg wrote: >>>>>>>>> Enable MMC_CAP_AGGRESSIVE_PM for qualcomm controllers. >>>>>>>>> This enables runtime PM for eMMC/SD card. >>>>>>>> >>>>>>>> Could you please mention, which platforms were tested with this >>>>>>>> patch? >>>>>>>> Note, upstream kernel supports a lot of platforms, including >>>>>>>> MSM8974, I >>>>>>>> think the oldest one, which uses SDHCI. >>>>>>>> >>>>>>> >>>>>>> This was tested with qdu1000 platform. >>>>>> >>>>>> Are you sure that it won't break other platforms? >>>>>> >>>>> >>>>> Thanks for your valuable comment. >>>>> I am not sure about the older platforms so to avoid issues on older >>>>> platforms we can enable this for all SDCC version 5.0 targets ? >>>> >>>> No, there are still a lot of platforms. Either explain why this is >>>> required for all v5 platforms (and won't break those) or find some >>>> other >>>> way, e.g. limit the change to QDU1000, explaining why it is _not_ >>>> applicable to other platforms. >>>> >>> >>> Thanks for your comment. >> >> No need to. >>  >> I agree with your concern but for me also its not possible to test on >>> all the platforms. >> >> Sure. >> >> Lets say if I want to enable this caps for QDU1000 for which it has >>> been tested and on any other upcoming target after testing, then how >>> can I proceed to enable? >> >> Let's start from the beginning: why do you want to enable it on QDU1000? >> > > QDU1000 is one latest available target where we have enabled this and > tested. This has been enabled to save power. Isn't it a powered device? How much power is the save? Is it worth it? -- With best wishes Dmitry