From: Tomas Melin <tomas.melin@vaisala.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: industrialio-backend: support backend capabilities
Date: Wed, 14 Jan 2026 09:39:32 +0200 [thread overview]
Message-ID: <1a0adfe1-3847-40c6-ae95-73cd3f41786c@vaisala.com> (raw)
In-Reply-To: <aWaz2JrwtwwE3dEc@smile.fi.intel.com>
Hi,
On 13/01/2026 23:06, Andy Shevchenko wrote:
> On Tue, Jan 13, 2026 at 12:12:48PM +0000, Tomas Melin wrote:
>> Not all backends support the full set of capabilities provided by the
>> industrialio-backend framework. Capability bits can be used in frontends
>> and backends for checking for a certain feature set, or if using
>> related functions can be expected to fail.
>>
>> Capability bits should be set by a compatible backend and provided when
>> registering the backend.
>
> ...
>
>> struct iio_backend {
>
>> u8 idx;
>> + u32 caps;
>
> Please, run `pahole` to see if there is a better place for a new member.
> (I bet there is.)
Indeed, there seems to be. Thanks for the suggestion, will update.
>
>> };
>
> ...
>
>> +enum iio_backend_capabilities {
>> + IIO_BACKEND_CAP_TEST_PATTERNS = BIT(0),
>> + IIO_BACKEND_CAP_BUFFERING = BIT(1),
>> + IIO_BACKEND_CAP_CALIBRATION = BIT(2)
>
> Add trailing comma, it will allow to avoid unneeded churn in the future.
Sounds good, was just following existing style.
Thanks,
Tomas
>
>> +};
>
>
next prev parent reply other threads:[~2026-01-14 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 12:12 [PATCH v2 0/3] iio: adc: ad9467: Support alternative backends Tomas Melin
2026-01-13 12:12 ` [PATCH v2 1/3] iio: adc: ad9467: include two's complement in default mode Tomas Melin
2026-01-13 21:04 ` Andy Shevchenko
2026-01-14 7:41 ` Tomas Melin
2026-01-13 12:12 ` [PATCH v2 2/3] iio: industrialio-backend: support backend capabilities Tomas Melin
2026-01-13 15:18 ` David Lechner
2026-01-14 7:29 ` Tomas Melin
2026-01-13 21:06 ` Andy Shevchenko
2026-01-14 7:39 ` Tomas Melin [this message]
2026-01-14 7:51 ` Andy Shevchenko
2026-01-13 12:12 ` [PATCH v2 3/3] iio: adc: ad9467: check for " Tomas Melin
2026-01-13 15:19 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a0adfe1-3847-40c6-ae95-73cd3f41786c@vaisala.com \
--to=tomas.melin@vaisala.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®