From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0939C327BF8 for ; Wed, 13 May 2026 18:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696220; cv=none; b=nbOXt1A+i4LHtnB2ewwXAU/ZJq4aL+iPFfggY9iKdheIoqgtn7P/6pPZpZgfCl/oRz/l9tp0lM2QCQ8HdqQRM7p8GtL6jZ2tf6AJsInRvoYu5gqZ6dJzksVPWsdAU0sdH1qyD09HBBrOvQTfXmFUIEhmqCy4cZqlEbXGSIvX/ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696220; c=relaxed/simple; bh=iOltX60XHPNgqNIC2DpQT5Z7BO+j/K77i8PFIemPJSU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c/THlpmquL8FV6ghWZgyj4T/C0raNZHrVz++/KMthr2atvf3XYCJIwyBg727XPRtcFboIJB0HhQk8+vv1966DBK47VNX14tgZm0LLqLl18OEb5squin+IYYClI2dqoP9Rf0oxwTYJqDOqJg8rC2u5MIGIqPI2VICmYTIxXURABU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a4OJJW6V; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a4OJJW6V" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c8027e876fcso3032031a12.1 for ; Wed, 13 May 2026 11:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778696217; x=1779301017; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=s03Oh/BgVRz777SZgXCs5erRF14ygyMEU76E4HIIUlM=; b=a4OJJW6V3AsKe7WrE2jneBjmQFz0lhp83ZA77ymTVE4zgqV1UTY0pekS2n8mQFMyC3 3G+VsPaJJg8867jqClkZDoQXwgCKRmcdFiVuvsMq5UDAAcGrNHy9vsKwy8528+fDNuYd XnErY/uPbAhfZD0gMHIR0COl1kkinYkzp3YDVl2M1zYyn96xGLccL49kqFMggVqDILrD HYzA7XoDZN+4UrL3jeB06JEFDAXzdxOgMT349Y160FIHp2Fz09ygugzIqvSklnXuv6En uEwrXWPb34rfdcMYBfi+sYX3LG1Y3D0qs+MJ3sZEVpmf3f/HkB4WuFK52FLyScqd3Z5H T+NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778696217; x=1779301017; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=s03Oh/BgVRz777SZgXCs5erRF14ygyMEU76E4HIIUlM=; b=gs5mGkU04C11KEJ1PDGXwd5TT5Dzm/m1DoRvEy43SGF+kbvi1xbfmzrlPd9F5BtP5Z gZdO88K2CshXu1cwQZJWlkMC8F/+xPYEXK/yIgTarFWzM0xADoVMwsO76RK/I6FZMKEC KRvAY/YY2ocjUlQA7bsIdwMDRjnj70DAMt547HM4Woud6vwxgiJTBdBGHijG8M3YS2na gufuhoFa5p1ipwDgU9bmM9YbcWaKzF9veSyHdUuewNcJNC0BYmAGcWqe/g8d8y82RjvS QPzRYCZvVmX0nEwTkWuLib3jylsnQeVDmo8En64sakYxVnvpzy9jM+9IRIwFv3M4Xb+g BWCw== X-Gm-Message-State: AOJu0YzJtDroiorv9ALBrlcjUvK39iNdgCNieReDzxV3AZVHIBLaQPXn hTrQZyzZuwKYtz7Hqrzl8jc+nOzp5R7bG1pgQDfPZXpB9mFKI7p4WAY3 X-Gm-Gg: Acq92OFdBor9Zojt4I0wN2bBwscuQ/WXQZhO32w/VyHpTBfPry3F1+Lb5DtKH1A2VHR gzUNsBSjfqHzdj5Tqi0zkaZXKcEj4lg3IVZnFz/ooYMmuXNMn3/e9E5TSTwe9EgbUPkwYsJZhM0 DBI4bzrmQu53hgCrfTEHcWOZTn8EAndr9xqyFrB1m4ipvtRvJb0qpZZ8tb/gvubVH0qb1wDDabV w9ac095FKOXoC0BXkVB25nSwfJWr5lMSeIWkOxdL43QRtXSY2YWqAZteD6zpt37RulBsVgQmCye pwZCaCN8NZMCMUP+uikS6DqWbgSWGPSVO+8uRlMgTRy8/PXyiZpv6OL9D1sR+6Lx5OW5126af8u /J6dlD28Nc7Yqbz5VugdF1pZKcHo50EljJl9++bRVd8UkqNkacyJIj9bJ7O273xCf55PvXYzH8P XRmQ+sMYY4r9DFfkSTIfgsXzlF5CmzUBwtsr6TbdGmV5FbgRU= X-Received: by 2002:a05:6a20:2454:b0:3a2:f05a:7952 with SMTP id adf61e73a8af0-3afb1a0a587mr4668221637.39.1778696216880; Wed, 13 May 2026 11:16:56 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c826768acf3sm18893427a12.10.2026.05.13.11.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 11:16:55 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 13 May 2026 11:16:54 -0700 From: Guenter Roeck To: Wilken Gottwalt Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH] hwmon: corsair-psu: fix and readd locking of command buffer Message-ID: <1a11ddfb-8c3a-4f0d-afda-c4c82daa6d9e@roeck-us.net> References: <5f0406fa-9692-49f0-bcfe-c013f5fc7b62@roeck-us.net> <20260513162135.2893e42d@posteo.net> <254b59a8-182f-4ad3-8469-4f9e9511d3a5@roeck-us.net> <20260513175350.07900558@posteo.net> <62e02950-e31b-4faa-8b36-98bbfe898367@roeck-us.net> <20260513195027.028b7b63@posteo.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513195027.028b7b63@posteo.net> On Wed, May 13, 2026 at 05:50:30PM +0000, Wilken Gottwalt wrote: > On Wed, 13 May 2026 09:42:08 -0700 > Guenter Roeck wrote: > > Now I am completely confused. What is that guard() and scoped_guard() patch? Again, with subsystem locks instead of guard(). Guenter --- >From bafbb2e301621335381209e395fa281a395ffc53 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Wed, 13 May 2026 09:25:46 -0700 Subject: [PATCH] hwmon: (corsair-psu) Protect debugfs accesses with subsystem lock Debugfs accesses need to be mutext protected. Acquire hwmon subsystem lock where needed to avoid race conditions against hwmon sysfs accesses. Signed-off-by: Guenter Roeck --- drivers/hwmon/corsair-psu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c index 76f3e1da68d0..866e798d553c 100644 --- a/drivers/hwmon/corsair-psu.c +++ b/drivers/hwmon/corsair-psu.c @@ -664,7 +664,9 @@ static void print_uptime(struct seq_file *seqf, u8 cmd) long val; int ret; + hwmon_lock(priv->hwmon_dev); ret = corsairpsu_get_value(priv, cmd, 0, &val); + hwmon_unlock(priv->hwmon_dev); if (ret < 0) { seq_puts(seqf, "N/A\n"); return; @@ -730,7 +732,9 @@ static int ocpmode_show(struct seq_file *seqf, void *unused) * getting of the value itself can also fail during this. Because of this every other value * than OCP_MULTI_RAIL can be considered as "single rail". */ + hwmon_lock(priv->hwmon_dev); ret = corsairpsu_get_value(priv, PSU_CMD_OCPMODE, 0, &val); + hwmon_unlock(priv->hwmon_dev); if (ret < 0) seq_puts(seqf, "N/A\n"); else -- 2.45.2