From: Radu Rendec <radu@rendec.net>
To: Eliav Farber <farbere@amazon.com>,
Thomas Gleixner <tglx@kernel.org>,
Antoine Tenart <atenart@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] irqchip/alpine-msi: Drop redundant asm/msi.h include
Date: Sat, 24 Oct 2026 14:20:28 -0400 [thread overview]
Message-ID: <1a128eaffb2994591882308f67e0d7a0c4bcd4b1.camel@rendec.net> (raw)
In-Reply-To: <20260923083703.38974-3-farbere@amazon.com>
On Wed, 2026-09-23 at 08:37 +0000, Eliav Farber wrote:
> The driver already includes <linux/msi.h>, which itself pulls in
> <asm/msi.h>, so the explicit arch include is redundant. Remove it;
> checkpatch also flags the direct use of the asm header in favour of
> the linux one. No functional change.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> drivers/irqchip/irq-alpine-msi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
> index 0d97abb85e16..20f1f7f7612b 100644
> --- a/drivers/irqchip/irq-alpine-msi.c
> +++ b/drivers/irqchip/irq-alpine-msi.c
> @@ -21,7 +21,6 @@
> #include <linux/slab.h>
>
> #include <asm/irq.h>
> -#include <asm/msi.h>
>
> /* MSIX message address format: local GIC target */
> #define ALPINE_MSIX_SPI_TARGET_CLUSTER0 BIT(16)
Reviewed-by: Radu Rendec <radu@rendec.net>
next prev parent reply other threads:[~2026-10-24 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 8:36 [PATCH 0/4] irqchip/alpine-msi: Cleanups and debug logging Eliav Farber
2026-09-23 8:37 ` [PATCH 1/4] irqchip/alpine-msi: Use SPDX-License-Identifier Eliav Farber
2026-10-24 18:05 ` Radu Rendec
2026-09-23 8:37 ` [PATCH 2/4] irqchip/alpine-msi: Drop redundant asm/msi.h include Eliav Farber
2026-10-24 18:20 ` Radu Rendec [this message]
2026-09-23 8:37 ` [PATCH 3/4] irqchip/alpine-msi: Add missing space after comma in GENMASK_ULL Eliav Farber
2026-10-24 18:21 ` Radu Rendec
2026-09-23 8:37 ` [PATCH 4/4] irqchip/alpine-msi: Add debug logging for MSI allocation Eliav Farber
2026-10-24 18:47 ` Radu Rendec
2026-10-24 19:33 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a128eaffb2994591882308f67e0d7a0c4bcd4b1.camel@rendec.net \
--to=radu@rendec.net \
--cc=atenart@kernel.org \
--cc=farbere@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®