From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28031E22E9 for ; Mon, 2 Mar 2026 18:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475685; cv=none; b=E+uS9Z07e1DeYL0I+pQeQsVmq54B4o/ebp0e6iDoZcuBSljg97+12pTyQMY7I8dd79Bmhnan0qJSuEqLGDor0UU/xOgU2ZkgoUeAimgep0V+4HdGpf5STIRdhEncxuSaYRPcl3KuFDbsfFuITzuGJETMIpre0uT3A5EDwf4+f9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475685; c=relaxed/simple; bh=uKLs7LaNVRNd1atbobusqQm6rehZQXgScL2EvSc9Ljs=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=YLAngTj2NMSnq8TLcZsqz+xmkUeaoKsznOitRYvUEDcc2ifcdLybMwyLk3OPTOqcRDjlbLX7WnQR42Hn4Ky4/BHykTlPmgrqxJHH/n8MmBDG+SyPqcArNrgAYIkmb6bD1sX5Vva4pIVPR8zEKyIztYk1eHjluoiEFKsuD192dOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NXWDrP2G; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXWDrP2G" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-436e87589e8so4599288f8f.3 for ; Mon, 02 Mar 2026 10:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772475682; x=1773080482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=uKLs7LaNVRNd1atbobusqQm6rehZQXgScL2EvSc9Ljs=; b=NXWDrP2Gve58BhmDf8HBVUjR3bz9UtiorA6Kt8TMPc2o5ZC4ZqNLTnlZ2nrjVf7Gqa ZCLbJzVbE5x7K4QvMwnxi4Rvzc2cL6HxnT/viyt9qgTctQQKWs/4PEXwLGS0NuaQilUa esDMHpeAfGYcqrer+gDOwBCjbmAN5lxX84eQuRvdeXl0WLFBcDk3MpIQo41+O/wateLp HGkKpe3n9Do+DJfG51ZQSRGZ8OQqVjjJ/AoWw7Nxr+Wh1MF1sU9Af4FNi2KFn66gUGhK iCqVg82xmtdf4fIQ0m6Ow4R9nC6vOzM2MuA2kD/eQYYEuMf7AiRtxlG/NfXsjfRRerk0 QNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772475682; x=1773080482; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uKLs7LaNVRNd1atbobusqQm6rehZQXgScL2EvSc9Ljs=; b=djFEil6rmivVW6SKt0Nk85NMYKzO0DpX3mO03JfI2/7w+k+lku/bZ1jPiklGeOrTPs BFeAg+dvBPJBE2A0TFlhf0g+pDMYFR21Psfm73X5Wnsj8eIligOO748dCcEixMUj1oJt yS9uKbEr18RCgfrpkxaa7a+gBABErv5c69uS3TY0e/PyL2UKSDRSrEszm5xEchEjFll9 7FT26cgJCwAsQTOULFI5Kz7/iUx/mFNfePWptzFzEWFkJZYqKwflyDe3mifE60jN/CsO 6jLt5FoBYUASrq/BSEaNlms4dHkD8YXl9bzQienTXrbUhiFH2qgQAMY4Lv3jtwEPZGgf mQdA== X-Forwarded-Encrypted: i=1; AJvYcCUtAdGq3ravFjK8TjuRTIzSuo88N6EelLux/AptlFadVNCsirz3tnQCwXWfs+PR8mID3wG6BLjIu+0ElTU=@vger.kernel.org X-Gm-Message-State: AOJu0YyVW2FHZmxmvQfdQ4gNr2kPsVQbw0FJ26rB1gQSJ61x1KryFt3R i/LtXDuxeyg5QtZJZHkqjG0VCEkZ8eHxbvUBOrxSQAn9BDkG4HpoAv5O X-Gm-Gg: ATEYQzy3lBIAzZjYPjzPtmV5XlonYTehVyaHccg9FrhBDumxgcGuukqjhiyWayIIjwS x4Qw9bP95143rdAFEk207F+vsadYi9LlRcFhNM1xNj3SgXXWaRbbvgpjPqK1knT70ldLKtjvujq K2jIbqgoz6Ok4AFrKAEZ2zvNKd9bDcQYX3rdvhBZTZb/s//bllJTHfLfhOQo4ClFrIuZFR7pKCE 8ncYecdjRmDL5j8qFFj6uAxAwAbRkUsZrNL3OLN0c2RTjrtIOla+DS+OlvHosiQGFjtxXy3cuV6 AivcmzzZ3ykG0Eo/1rV/9rYndb83wMXfEu94hljLHYoyrbOW1OdvOpOpvqGZEOCSdNYxZSH9hJv 0fe5o3jgyPrngtGoxu166H14g6MHycqzJqrDd7vSRsy38IW4Rb+HgmDdLpuQzQINH2T56JRXQyq LHqcxQsHxg36zok4/D X-Received: by 2002:a5d:5c89:0:b0:439:b81f:ad98 with SMTP id ffacd0b85a97d-439b81faf6cmr6223979f8f.47.1772475682014; Mon, 02 Mar 2026 10:21:22 -0800 (PST) Received: from [127.0.0.1] ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c75b272sm28389886f8f.24.2026.03.02.10.21.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 10:21:21 -0800 (PST) Date: Mon, 2 Mar 2026 18:21:20 +0000 From: Josh Law To: Mark Rutland Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Josh Law Message-ID: <1a19899b-862b-477f-8314-4821ac6b8716@gmail.com> In-Reply-To: References: <20260301003407.2493781-1-objecting@objecting.org> <20260301003407.2493781-4-objecting@objecting.org> <3fe578cc-07b3-442b-8eca-1f94c1975e85@gmail.com> Subject: Re: [PATCH 4/4] arm64: kernel: Fix style in io.c macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <1a19899b-862b-477f-8314-4821ac6b8716@gmail.com> 2 Mar 2026 18:08:29 Mark Rutland : > On Mon, Mar 02, 2026 at 03:45:16PM +0000, Josh Law wrote: >> 2 Mar 2026 14:51:19 Mark Rutland : >> >>> On Sun, Mar 01, 2026 at 12:34:07AM +0000, Josh Law wrote: >>>> Signed-off-by: Josh Law >>>> --- >>>> arch/arm64/kernel/io.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/arch/arm64/kernel/io.c b/arch/arm64/kernel/io.c >>>> index fe86ada23c7d..ce27fa5d2e37 100644 >>>> --- a/arch/arm64/kernel/io.c >>>> +++ b/arch/arm64/kernel/io.c >>>> @@ -17,10 +17,10 @@ >>>> #define memcpy_toio_aligned(to, from, count, bits)=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> =C2=A0=C2=A0=C2=A0 ({=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 volatile u##bits __iomem *_= to =3D to;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits *_from =3D from;= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits * _from =3D from;= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 \ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 size_t _count =3D count;=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits *_end_from =3D _fr= om + ALIGN_DOWN(_count, 8); \ >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits * _end_from =3D _f= rom + ALIGN_DOWN(_count, 8);\ >>>> +\ >>> >>> There is no style violation here. There's no need to add a space betwee= n >>> '*' and the variable name. >>> >>> Mark. >> >> I used checkpatch.pl... it detected that > > So? Tools can be wrong. > > In general, checkpatch.pl shouldn't be applied to existing files to find > issues, since there are many deliberate violations, and cases it cannot > parse correctly. > > I checked out v7.0-rc2, and ran: > > =C2=A0 ./scripts/checkpatch.pl -f arch/arm64/kernel/io.c > > ... and the warning you see seems to be: > > | ERROR: need consistent spacing around '*' (ctx:WxV) > | #20: FILE: arch/arm64/kernel/io.c:20: > | +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 const u##bits *_from =3D from;=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > > From a quick scan of checkpatch.pl, that's because it has mis-parsed > this as a binary operator, where we *do* want consistent space around > the '*'. > > For types that's not the case, e.g. > > | [mark@lakrids:~/src/linux]% cat test.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > | int *foo =3D 1; > | > | int * bar =3D 1; > | [mark@lakrids:~/src/linux]% ./scripts/checkpatch.pl -f test.c=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > | WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > | #1: FILE: test.c:1: > | +int *foo =3D 1; > | > | ERROR: "foo * bar" should be "foo *bar" > | #3: FILE: test.c:3: > | +int * bar =3D 1; > > Mark. Sorry Mark, I'm sure I'll do a real useful patch to you very soon V/R