From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.98 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793638700; b=CvaJJovKo9sAgyGwJA51VDS3pOpMybPn96PJpKadIKpj6/zr67FvYraXJDJNIFGGIRS1 VBvOCGAhr9oxCQyynDj7vUPtXbbNkWJSJH0I5hZR5W+mpYwyaYHQpgET1vtQG545WKtxn gGI3Mc518OeqbqW5NdUWSXLvx6SDy0KCy0R95U2MOtmGks59gBsnzCfnajwUjNmLucFjR 2wN+5sd3vM/QBXTIVJC9Cb28vHTlPAiyURZ6xwo92e+Za6YDkrUcYBx/a3UIo4N2kxIRD F39f6rIfHs5KqsiRjrlqCRNZ4nfQfuwpbIa6KMT1t8G/vvxVNbvBo+NlPN5DumZq9Sw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793638700; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:X-Relaying-Domain: X-CFilter-Loop:Received:DKIM-Signature:X-Forwarded-Encrypted: X-Received:X-Received:Received:From:To:CC:Date:Message-ID:In-Reply-To: References:User-Agent:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:X-DetectorID-Processed; bh=KIqsitZcMi7h2QQHA4zZ281+QxpG2+lZy3zu6UwkhTg=; b=S1qlJ+wUok7uxwx0B66Crf51tTGWUooTec4UX1w4qmskRzW9eiZsfYk5xFeuM9n/3h7p vFFAmoacTwg++ziutpECiirjQB3lealES5H2k3vxhks3t13sQ93mPEo4iy3Qd8Cubxuse +XNYOkdmQ6KVuj4kmcQV5tksBkt9KO3jHkpWSovVhawjysQyAugE25qhBJYOUZgOSLy2o gOVokeRa2VMpN4nQZtRHlZ7TgMP0kG3g0uah4znS1nTtlrSxuZwYADQlOVr6q5jzYDLTJ 2W/Soe1twhe8TzXA3HeIVhrXTYmKatTzHaobSO+eLd3s2gNhyHSIYrWIxa5ruMutegA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=hdcZWG8g; arc=none smtp.remote-ip=209.85.216.98 Received: from mail-pj1-f98.google.com (mail-pj1-f98.google.com [209.85.216.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87722606EE8F for ; Mon, 2 Nov 2026 16:58:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 87722606EE8F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=hdcZWG8g Received: by mail-pj1-f98.google.com with SMTP id 98e67ed59e1d1-3ad787e0593so1538072a91.3 for ; Mon, 02 Nov 2026 08:58:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793638699; x=1794243499; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KIqsitZcMi7h2QQHA4zZ281+QxpG2+lZy3zu6UwkhTg=; b=0m0Ajl8Y6cuXlmBDxmBy/Rl1n+zMkEzKyvJuTR++ZkxENc0jJKnun7nwKd/kspaaWy HKWF2ZOphCwjzLf6G0B/kDqtKHoGF4waMZxLi/p/nTfwoFFUvmP8wwdQheDAwx87qBDy KcH/PmfQDquIylsmRXlR2S8zJ6aSvxFj903zf/bO5Luqk1fvQlJ7UeAtLn0X8l9WSieV rV4Bnchlxn+2jMPNWa2iIQaC+j1679BR0trJ9pkBKj8ZI/4O9QzBz7Y2A3Nh0mtqE7SY aGDVv+U+IbdjHF0eGSxzo7DLIr4XH16imYKoOqHApinFNx3DdAd40grwcTdR4s/9/zVb Hq5Q== X-Forwarded-Encrypted: i=1; AKwUvBxpXZB7x0P0LcpUblNyP6TP0dClDR0NPNgUUhbW6fyX6F8GPmCCi2HZwxlGaoqhvaiROFTMon/XQthFSuE=@vger.kernel.org X-Gm-Message-State: APuU4Z8GjOli+8xRxxK5SOJzQBlNT7ZT3HXfJG93OnBg7Yor7NFRzZpL tEtqGIPcKPDSWhqNhJCzMq4IOZtxOmBN6WMJWDrvbJebahkBCod18z+f1hQUVHWfx+yqBoY/mAl J1SqaCdykX7q5wYgQ8IdrRr7474RF8htro7n50wTXnBt/68wl2p8RPDnJaQmHM1xNmXw/qL/O7t s4ZQkMgvVCEsw70yfwbFhDbBQHRmd8aWlRVF2HGbiWNsBmiPe7zaCv2LxCX2NIt1kz+BtAuvcHV wHunf9j/PufV1jWd9dqdT9XXg== X-Gm-Gg: AYBFou027NvRTymN1Vmu6qkGmVzoKpry/9/yhpdD8rw8Q7IlEOAnzhO6WjwhgfEogin x+a7EQKBh2k4FTy417/XaqJ9eLF6k7nl+1KLFTjxHk63ClqeatcQzKIShyKZ9aOOpmWtPLUxLJM Y+gjgkz45twR9XM2IetL22b+OKiXM5n+FBGXaKUAxXoiebTadFRQPI6gg5Dz6q2t7P2z9IKeeTT 8RT56ZCIz3q4IX9UYDpA4p2/mOaX6j5F3PJzuwc9lAHEiSATso+ujpkMpJAlrCAM2vW1LIGjeDE dJLy7YWdLBvegA+G6IDVh7aYhK5oPLUa0/pSID9CSRdGqXp6SiU/mgZTRistWS931evy5CYmhUG U5vMevKWvq23s2pdP7QUW43xivKSno1lFFKrgIcK7SE8Czew+8YiXHvOQOOKMB5XE6qpl/FYjuW XcJpmfwxR+z/4c5e49b6+gRfOsVhHemS1yK3b3vUA= X-Received: by 2002:a17:90b:5243:b0:3ad:3e8:12 with SMTP id 98e67ed59e1d1-3ae89806353mr7571089a91.48.1793638698785; Mon, 02 Nov 2026 08:58:18 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-13.dlp.protect.broadcom.com. [144.49.247.13]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3ae6e84adc9sm10164648a91.5.2026.11.02.08.58.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2026 08:58:18 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-8468290b866so4589852a34.1 for ; Mon, 02 Nov 2026 08:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1793638697; x=1794243497; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from:from :to:cc:subject:date:message-id:reply-to:content-type; bh=KIqsitZcMi7h2QQHA4zZ281+QxpG2+lZy3zu6UwkhTg=; b=hdcZWG8gMbeB5TX0YsX6HZFukc+i7ihXfyZHSmZH3/RxNQNVKw64zlS9owFM8qFicM A03Lfv/TWoUpsXa+Ha/dfo4/fDXNLYlZ+KYXcSsh9GcLPiMXj7ba0WLRnD1CgKpaGk81 ShBtIjONXTBgYLFiOJ3JvdWFzCXvRcEhXg4qk= X-Forwarded-Encrypted: i=1; AKwUvBwS92ruvMkA51ALHC2bluI02VjUzJOxVfGkEthf2mopurULXO4/apjJkJPdS6xbpvckh7K77Fj4riHnre8=@vger.kernel.org X-Received: by 2002:a05:6830:2e04:b0:84b:c230:c2c1 with SMTP id 46e09a7af769-85d36400d05mr10579863a34.18.1793638697445; Mon, 02 Nov 2026 08:58:17 -0800 (PST) X-Received: by 2002:a05:6830:2e04:b0:84b:c230:c2c1 with SMTP id 46e09a7af769-85d36400d05mr10579847a34.18.1793638696985; Mon, 02 Nov 2026 08:58:16 -0800 (PST) Received: from [192.168.178.59] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-85d354985cdsm9955316a34.10.2026.11.02.08.58.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2026 08:58:16 -0800 (PST) From: Arend van Spriel To: Neal Gompa , CC: "Pieter-Paul Giesberts" , "Franky Lin (Zhenhui)" , Mathy Vanhoef , Kalle Valo , Kees Cook , "Gustavo A. R. Silva" , , , , , Hector Martin , Daniel Berlin , Janne Grunau , , Hante Meuleman , Date: Mon, 02 Nov 2026 17:58:11 +0100 Message-ID: <1a19d3270b8.2873.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20260925-brcm4388-submit-v1-0-b5cbc2cde2fb@gmail.com> User-Agent: AquaMail/2.8.1 (build: 200801029) Subject: Re: [PATCH 00/13] wifi: brcmfmac: Add BCM4388 support X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Op 2 november 2026 01:43:07 schreef Neal Gompa : > On Fri, Sep 25, 2026 at 9:49 AM Michael Reeves via B4 Relay > wrote: >> >> The Broadcom BCM4388 chipset requires new PCIe initialization and >> firmware interfaces. Add support for these interfaces to brcmfmac to >> enable basic station operation. >> >> This series adds: >> - Signed firmware loading and mailbox transport >> - Fixes for chip identification and firmware capability matching >> - Versioned scan and join requests, and extended PMK payloads >> - Updated event mask handling >> >> These changes include work by Hector Martin and Daniel Berlin from Asahi >> Linux, refactored where needed for upstream inclusion. >> >> The series provides basic station support only. 6 GHz support is planned >> for a follow-up patchset after this lands. The driver retains legacy >> interfaces for older firmware. >> >> Tested on an Apple M3 MacBook Air (J613): >> - Device boot and network scanning >> - 5 GHz WPA2-PSK association and DHCP >> - Bidirectional TCP traffic >> >> Testing required separate Apple PCIe and devicetree patches, as well as >> Janne Grunau's port-authorization fix [1]. >> >> [1] >> https://lore.kernel.org/linux-wireless/20260915-brcmfmac-4way-handshake-offload-authenticated-event-v2-1-fbb9cc7ac177@jannau.net/ >> >> --- >> Daniel Berlin (1): >> wifi: brcmfmac: Support versioned scan parameter layouts >> >> Hector Martin (6): >> wifi: brcmfmac: Support newer PCIe core startup and interrupts >> wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware >> wifi: brcmfmac: Load signed PCIe firmware images >> wifi: brcmfmac: Accept newer BSS information versions >> wifi: brcmfmac: Support versioned join requests >> wifi: brcmfmac: Add BCM4388 support >> >> Michael Reeves (6): >> wifi: brcmfmac: pcie: Report the detected chip ID to the bus >> wifi: brcmfmac: Match complete firmware capability names >> wifi: brcmfmac: Fall back to RSSI-only default join preferences >> wifi: brcmfmac: Use event_msgs_ext for event masks >> wifi: brcmfmac: Handle larger firmware band lists >> wifi: brcmfmac: Handle extended PMK command payloads >> >> .../wireless/broadcom/brcm80211/brcmfmac/Makefile | 1 + >> .../net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 9 + >> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 368 +++++++------- >> .../wireless/broadcom/brcm80211/brcmfmac/chip.c | 36 +- >> .../wireless/broadcom/brcm80211/brcmfmac/common.c | 27 +- >> .../wireless/broadcom/brcm80211/brcmfmac/core.c | 5 +- >> .../wireless/broadcom/brcm80211/brcmfmac/core.h | 18 + >> .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 124 ++++- >> .../wireless/broadcom/brcm80211/brcmfmac/feature.h | 2 + >> .../wireless/broadcom/brcm80211/brcmfmac/fweh.c | 130 ++++- >> .../wireless/broadcom/brcm80211/brcmfmac/fweh.h | 1 + >> .../broadcom/brcm80211/brcmfmac/fwil_types.h | 141 +++++- >> .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 65 ++- >> .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.h | 9 +- >> .../wireless/broadcom/brcm80211/brcmfmac/pcie.c | 560 +++++++++++++++++---- >> .../broadcom/brcm80211/brcmfmac/scan_param.c | 416 +++++++++++++++ >> .../broadcom/brcm80211/brcmfmac/scan_param.h | 13 + >> .../broadcom/brcm80211/include/brcm_hw_ids.h | 2 + >> .../broadcom/brcm80211/include/chipcommon.h | 5 + >> 19 files changed, 1593 insertions(+), 339 deletions(-) >> --- >> base-commit: 42a9fb3382fc2573e92f41d203b095d9a372cfc9 >> change-id: 20260925-brcm4388-submit-5cb8d3e6d6a5 > > Works for me and looks good. So what does "Works for me" mean here. Did you verify it is working on some hardware you have? If so, please share the info. Regards, Arend