From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96ADC3B52F4; Fri, 25 Sep 2026 21:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790370350; cv=none; b=GBskewaWfTjDecoHB2+GpAeBV0LqDKed/qF8/jrA5z4sGq5iDvnWLPhwdr2Tpp2j5Bf4+HsZSo8dZP1jriBtnCL9TRXZHcVR5L9tg2wow/c4mn+IXtABVlaKvF0KpcvWjz2RWBKKxGT86tqCbGzWXWL902Cjm3HSVIASVcRCqUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790370350; c=relaxed/simple; bh=b2qb3/m17D3IRapINEcz5X+cf1puUkUajkGVTpn8xNc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=trQHJmJ8jpU2Emnr72NUws/mAkgBiG4s16pSt7xXdevwNa6detSJIymfQdpalyINb4+J83e4+k9OoyZ+ly1BUrdlKNjXK6OppOb0BBszKyIYKerM4nZRDJRUWW7IhtzpjtNbSpqeObYvvcQFxtMssp5ePDY2q/yqzRu+UHbvfY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=CVZtL4P0; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="CVZtL4P0" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20260925210544euoutp0243b789d72a0438105cf8c503582698ec~YrFfDN8xy1957819578euoutp02g; Fri, 25 Sep 2026 21:05:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20260925210544euoutp0243b789d72a0438105cf8c503582698ec~YrFfDN8xy1957819578euoutp02g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1790370344; bh=qk8Ge4T09jwT9y52eGQdabyjZGZHTm4rz1alzvhqzEo=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=CVZtL4P01wXy1+ugGq9YEKbXZtnS2m47LDVMgeukd6k9aRE2PKTyTewEyd+xd1xUz 8XKsChiKzsHX6DVkdi2FeObuR4HvgrN2iAyS5sv8IPM1Qj2rOSydSod94INXrs4zeX 5ElvIi0+nZqcmJqlTKr1DtZBGumK+I3xrSlCxzds= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260925210543eucas1p2a1839e7e4c6489c00394e4e8a41e38dd~YrFdyTFmE0692106921eucas1p2t; Fri, 25 Sep 2026 21:05:43 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260925210541eusmtip20e82e1fc97240a09f0da0d95e25d9799~YrFcD3k-g2562925629eusmtip2U; Fri, 25 Sep 2026 21:05:41 +0000 (GMT) Message-ID: <1a1a9b49-430b-4218-b27d-e133d488e8d9@samsung.com> Date: Fri, 25 Sep 2026 23:05:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy To: Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Heiko Stuebner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Joshua Peisach , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20260917-mutant-chamois-of-competence-46ca77@quoll> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260925210543eucas1p2a1839e7e4c6489c00394e4e8a41e38dd X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260915153214eucas1p2b548f3236ef98fb0cbf320e397420125 X-EPHeader: CA X-CMS-RootMailID: 20260915153214eucas1p2b548f3236ef98fb0cbf320e397420125 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> On 9/17/26 08:51, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: >> Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. >> >> This device is a child of the starfive,jh7110-hdmi-subsystem node. It >> functions as both a PHY provider for the controller and as a clock >> provider for the variable pixel clock (hdmi_pclk), which it generates >> from its refoclk. >> >> Reviewed-by: Joshua Peisach > > While I appreciate other people looking at this, I don't think review > here applies. It was a blanket tag, given to the entire series, with > exception that it is from newbie, thus I want to ask: was this binding > REALLY reviewed by Joshua? > > Are the rest of the patches actually reviewed or just "looks good to > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > of doing review. > > >> Signed-off-by: Michal Wilczynski >> --- >> .../phy/starfive,jh7110-inno-hdmi-phy.yaml | 49 ++++++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-inno-hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-inno-hdmi-phy.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..f838fcc238ec7db0a8e794234bdceec36cb6d9e7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-inno-hdmi-phy.yaml >> @@ -0,0 +1,49 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://protect2.fireeye.com/v1/url?k=1b336029-7ab87530-1b32eb66-74fe485cbfec-59631fa23f87244c&q=1&e=7e2eb06f-7b14-4bec-84e5-b60bb954d80a&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Fstarfive%2Cjh7110-inno-hdmi-phy.yaml%23 >> +$schema: https://protect2.fireeye.com/v1/url?k=46734e4d-27f85b54-4672c502-74fe485cbfec-9b6e35999c41723e&q=1&e=7e2eb06f-7b14-4bec-84e5-b60bb954d80a&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: StarFive JH7110 Innosilicon INNO HDMI PHY >> + >> +maintainers: >> + - Michal Wilczynski >> + >> +description: >> + The PHY portion of the StarFive JH7110 INNO HDMI IP. >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-inno-hdmi-phy >> + >> + clocks: >> + maxItems: 1 >> + description: Reference oscillator. > > This barely counts as a resource, so usual question: no resources here? > no MMIO? Even the user of this phy is the block itself. > > This makes me wonder if this should be a device node in the first place > (instead folded into the parent). The PHY has no reg because the reg is shared with the controller and owned by the parent - patch 9 lets the bridge take its regmap from there. The user of the PHY is not only the block itself. It is the pixel clock provider for the whole display subsystem, voutcrg takes hdmitx0_pixelclk as the parent of its DC8200 pixel MUXes, and while HDMI output is active it is the only intended source for that clock. The parent has to be assigned explicitly so the general PLL does not end up driving the pixel clock, and so a DSI user does not reach the HDMI PHY clock generator. So it has to be its own node. The HDMI block has two independent functions with different clock inputs and one of them feeds back into the SoC clock tree. The PHY generates hdmitx0_pixelclk which voutcrg consumes the controller consumes pclk/mclk/bclk from voutcrg. Folded into one node that node is both a provider to and a consumer of voutcrg which is a cycle in the hardware description, not just in Linux. > > > Best regards, > Krzysztof > > Best regards, -- Michal Wilczynski