mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Ghiti <alex@ghiti.fr>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: compat_vdso: install compat_vdso.so.dbg to /lib/modules/*/vdso/
Date: Mon, 18 Mar 2024 21:53:42 +0100	[thread overview]
Message-ID: <1a1bf141-9fbf-4d30-bdd3-fd20f6170c3f@ghiti.fr> (raw)
In-Reply-To: <CAK7LNARShVA953-U+p6=wzq3GFsKx4GwpRiqmqftjQz3VkE2VA@mail.gmail.com>

Hi Masahiro,

On 15/03/2024 05:06, Masahiro Yamada wrote:
> On Thu, Mar 7, 2024 at 5:12 AM Alexandre Ghiti <alex@ghiti.fr> wrote:
>> Hi Masahiro,
>>
>> On 24/02/2024 04:37, Masahiro Yamada wrote:
>>> Ping x 2 ?
>>>
>>>
>>>
>>>
>>>
>>> On Sun, Jan 21, 2024 at 6:48 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>> On Fri, Nov 17, 2023 at 9:58 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>>> 'make vdso_install' installs debug vdso files to /lib/modules/*/vdso/.
>>>>>
>>>>> Only for the compat vdso on riscv, the installation destination differs;
>>>>> compat_vdso.so.dbg is installed to /lib/module/*/compat_vdso/.
>>>>>
>>>>> To follow the standard install destination and simplify the vdso_install
>>>>> logic, change the install destination to standard /lib/modules/*/vdso/.
>>>>>
>>>>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>>>>> ---
>>>> Ping?
>>>> (in case "yet more RISC-V updates" happens)
>>>>
>>>>
>>>>
>>>>
>>>>>    arch/riscv/Makefile | 2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
>>>>> index a74be78678eb..5cbe596345c1 100644
>>>>> --- a/arch/riscv/Makefile
>>>>> +++ b/arch/riscv/Makefile
>>>>> @@ -146,7 +146,7 @@ endif
>>>>>    endif
>>>>>
>>>>>    vdso-install-y                 += arch/riscv/kernel/vdso/vdso.so.dbg
>>>>> -vdso-install-$(CONFIG_COMPAT)  += arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg:../compat_vdso/compat_vdso.so
>>>>> +vdso-install-$(CONFIG_COMPAT)  += arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>>>>>
>>>>>    ifneq ($(CONFIG_XIP_KERNEL),y)
>>>>>    ifeq ($(CONFIG_RISCV_M_MODE)$(CONFIG_ARCH_CANAAN),yy)
>>>>> --
>>>>> 2.40.1
>>>>>
>>>> --
>>>> Best Regards
>>>> Masahiro Yamada
>>>
>>> --
>>> Best Regards
>>> Masahiro Yamada
>>>
>>> _______________________________________________
>>> linux-riscv mailing list
>>> linux-riscv@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>
>> Couldn't changing this library install path break some existing
>> application? I mean it kind of breaks where the library is expected to
>> be right?
>
> Do you have a particular library in mind?


None in particular.


>
>
> RISV-V is the only architecture that installs a debug vdso
> to a different location than the
> standard lib/modules/*/vdso/.
>
>
> I regard this as a fix.


You're probably right, I don't see why the search path would be 
different on riscv, unless it was fixed in userspace but I think this is 
the right thing to do, so:

Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex


>
>
>
>
>

  reply	other threads:[~2024-03-18 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 12:58 Masahiro Yamada
2024-01-20 21:48 ` Masahiro Yamada
2024-02-24  3:37   ` Masahiro Yamada
2024-03-06 20:12     ` Alexandre Ghiti
2024-03-15  4:06       ` Masahiro Yamada
2024-03-18 20:53         ` Alexandre Ghiti [this message]
2024-03-26 21:08           ` Palmer Dabbelt
2024-03-20 15:27     ` Masahiro Yamada
2024-03-27 14:00 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a1bf141-9fbf-4d30-bdd3-fd20f6170c3f@ghiti.fr \
    --to=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=masahiroy@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®