Re: [PATCH v9 08/11] arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som

[Josua Mayer <josua@solid-run.com>]

Am 28.09.26 um 18:10 schrieb Geert Uytterhoeven:
> Hi Josua,
>
> On Mon, 28 Sept 2026 at 16:40, Josua Mayer <josua@solid-run.com> wrote:
>> Add support for the SolidRun HummingBoard Ripple [2] with RZ/G2L
>> SoM [1].
>>
>> The HummingBoard Ripple is a reduced version of HummingBoard Pulse,
>> featuring:
>> - 2x USB-2.0 Type-A connector
>> - 1x 1Gbps RJ45 Ethernet
>> - micro-HDMI connector
>> - microSD connector
>> - mini-PCI-E connector with SIM slot supporting USB-2.0 interface
>> - MIPI-CSI Camera Connector (not described without specific camera)
>> - RTC with backup battery
>>
>> The carrier board is identical between RZ/G2L, RZ/G2LC, RZ/G2UL and
>> RZ/V2L SoMs, yet only the RZ/G2LC combination has a product page [2].
>>
>> While the variant being supported here is named "Ripple", shared include
>> files are still named according to the full board for consistency with
>> schematics, silk screen labels and other SoMs on same board.
>>
>> Description for microSD is shared with HummingBoard IIoT.
>>
>> [1] https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/rz-g2l-som/
>> [2] https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/hummingboard-rz-series-sbcs/hummingboard-rz-g2lc-base/
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
> Thanks for the update!
>
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts
>> @@ -0,0 +1,17 @@
>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +/*
>> + * Copyright 2025 Josua Mayer <josua@solid-run.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "r9a07g044l2.dtsi"
>> +#include "rzg2l-sr-som.dtsi"
>> +#include "rzg2l-hummingboard-ripple.dtsi"
>> +#include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
> This new include is not needed, as rzg2l-hummingboard-ripple.dtsi
> already includes it:
>
>
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi
>> @@ -0,0 +1,125 @@
>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +/*
>> + * Copyright 2025 Josua Mayer <josua@solid-run.com>
>> + */
>> +
>> +#include "rzg2l-hummingboard-pulse-common.dtsi"
>> +#include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
> Same for patch [09/11].
>
> Patch [10/11] is fine, as that one does not share
> rzg2l-hummingboard-ripple.dtsi.
>
> As the rest LGTM, I can fix that while applying, so no need to send
> a v10.

Thanks!

Since Sashiko also found a small issue in patch 11/11 ... v10 can still 
be considered.

To the includes, I would actually suggest a different solution for the 
duplicate include,
considering that I got confused about it:

diff --git 
a/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts 
b/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts
index 493a2b9b51d25..95a36f8804b55 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts
+++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts
@@ -7,8 +7,9 @@

  #include "r9a07g044l2.dtsi"
  #include "rzg2l-sr-som.dtsi"
-#include "rzg2l-hummingboard-ripple.dtsi"
+#include "rzg2l-hummingboard-pulse-common.dtsi"
  #include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
+#include "rzg2l-hummingboard-ripple.dtsi"

  / {
      compatible = "solidrun,rzg2l-hummingboard-ripple", 
"solidrun,rzg2l-sr-som",
diff --git 
a/arch/arm64/boot/dts/renesas/r9a07g054l2-hummingboard-ripple.dts 
b/arch/arm64/boot/dts/renesas/r9a07g054l2-hummingboard-ripple.dts
index 3df7c67d75a25..0c73871524541 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g054l2-hummingboard-ripple.dts
+++ b/arch/arm64/boot/dts/renesas/r9a07g054l2-hummingboard-ripple.dts
@@ -7,8 +7,9 @@

  #include "r9a07g054l2.dtsi"
  #include "rzg2l-sr-som.dtsi"
-#include "rzg2l-hummingboard-ripple.dtsi"
+#include "rzg2l-hummingboard-pulse-common.dtsi"
  #include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
+#include "rzg2l-hummingboard-ripple.dtsi"

  / {
      compatible = "solidrun,rzv2l-hummingboard-ripple", 
"solidrun,rzv2l-sr-som",
diff --git a/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi 
b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi
index d5bd9b7de4282..aeb92630f4c6b 100644
--- a/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi
@@ -3,9 +3,6 @@
   * Copyright 2025 Josua Mayer <josua@solid-run.com>
   */

-#include "rzg2l-hummingboard-pulse-common.dtsi"
-#include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
-
  / {
      aliases {
          /* this board does not use second phy / ethernet on SoM */