mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: krzk@kernel.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	perex@perex.cz, s.nawrocki@samsung.com, tiwai@suse.com,
	stable@vger.kernel.org
Subject: Re: [PATCH 03/20] ASoC: samsung: snow: Fix clock leak in snow_probe()
Date: Wed, 16 Sep 2026 12:22:45 +0100	[thread overview]
Message-ID: <1a22633e-6264-4ea4-a6be-28f87802000b@sirena.org.uk> (raw)
In-Reply-To: <20260916070341.1965422-1-vulab@iscas.ac.cn>

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On Wed, Sep 16, 2026 at 07:03:41AM +0000, Wentao Liang wrote:
> In snow_probe(), priv->clk_i2s_bus is acquired via of_clk_get_by_name().
> If devm_snd_soc_register_card() subsequently fails, the acquired clock
> is never released, leading to a reference count leak.

You've not copied me on the rest of the series so I don't know what's
going on with dependencies.  When sending a patch series it is important
to ensure that all the various maintainers understand what the
relationship between the patches as the expecation is that there will be
interdependencies.  Either copy everyone on the whole series or at least
copy them on the cover letter and explain what's going on.  If there are
no strong interdependencies then it's generally simplest to just send
the patches separately to avoid any possible confusion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-09-16 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:03 Wentao Liang
2026-09-16 11:22 ` Mark Brown [this message]
2026-11-07 16:45   ` Wentao Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a22633e-6264-4ea4-a6be-28f87802000b@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=s.nawrocki@samsung.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®