From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbdATKWK (ORCPT ); Fri, 20 Jan 2017 05:22:10 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50356 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751740AbdATKWH (ORCPT ); Fri, 20 Jan 2017 05:22:07 -0500 Subject: Re: [PATCH 1/2] ARM: dts: exynos: Add CLK_ACLK432_SCALER clock to gsc_pd for Exynos5800 To: linux-kernel@vger.kernel.org References: <1484864995-10679-1-git-send-email-javier@osg.samsung.com> Cc: Inki Dae , Andi Shyti , Shuah Khan , Marek Szyprowski , Andrzej Hajda , devicetree@vger.kernel.org, Kukjin Kim , Russell King , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <1a244e36-a965-3efb-4413-b40e8c549cf9@osg.samsung.com> Date: Fri, 20 Jan 2017 07:11:04 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1484864995-10679-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 01/19/2017 07:29 PM, Javier Martinez Canillas wrote: > On Exynos5800 SoC the SCALER block uses 2 input clocks: CLK_ACLK_300_GSCL > and CLK_ACLK432_SCALER, so both needs to be ungated in order to access it. > > The SoC manual say the CLK_ACLK432_SCALER is needed to access the internal > buses, so add this clock as another asynchronous bridges (ASB) clock. > > The Exynos5420 only has the CLK_ACLK_300_GSCL clock defined. So just using > this definition from exynos5420.dtsi in Exynos5800 leads to the following: > Please ignore this patch as suggested by Marek. Instead I'll post a patch to mark the clock as CLK_IS_CRITICAL, as a temporary workaround until a proper runtime PM based solution gets merged. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America