From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F923ACF14 for ; Wed, 25 Feb 2026 12:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023285; cv=none; b=HrCWs4NrwR70LP2dVnQCijbqcFD4UarK1So+Ei0zRx/LkMa3we/UKMuTApvJ70urb9HYuxHi9FcofFDjnQyZudh/074IP1Gwq07DPJvgKX4jYWhCevhm56K/+UjEexuEDmAUhxquCOhD9LMVtjLIjEyfU4LElWu5yR5zSqoPFJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023285; c=relaxed/simple; bh=iqvKLMDFqeno+jEiq0kO0YroAm03A6FEtNiHUdWPP1w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jOCHzAJohe4vGtpubBed3MX4KnGfec1feKHiMdXvyqlkR/UKkGF+/EvA/LwZ/3SW+uKf1SXJ32MLc4PrdNPk7L1GWzlxvAQjcL8cFZ9S4fRvr4xJvJLdMqCpW/x8n9SelWKz786Gj3ugbk5HD2kHC7AFqZeKX6COY4DSYPlmYm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K4PoU5ea; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h5oz3wzI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K4PoU5ea"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h5oz3wzI" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PB3Rq21512053 for ; Wed, 25 Feb 2026 12:41:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HYT7mQ2ja/t6BbG4swbmeUHgbB2sHNob61Efta+Yx6I=; b=K4PoU5eaODjd5Erx y7ZESAXmdu8XRksHW6ZBHZfOYVnvnlYZvfWr8XU3iinrkrtwfNLzB3760EySj3W2 F+PYFPdXFlDwvU6kp1lb2TnRUY9omAnLsjQbglYkqJS2FlBuXLlRT8ELJiwj2Ee6 MBnrGps5sU374fb8i1xCKwawGSj+/jhUymuWBj9XFb2hdkSFRwFxKB7mMiRDDUAq YKQ/5F7MOGl+oY0OiXJKyx11OxUSFi+NGVoTaWcEWYOumLsqfNU1bJFouLSZiWmb YfnTdELai8uFkc0uUmuwEynyHm2NKmTYJhe0RPvz1MsbhZP6F81uXQO4kDNSoLaV 22AOGw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chyvf07qd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 12:41:22 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3978cdb2so540157985a.1 for ; Wed, 25 Feb 2026 04:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772023282; x=1772628082; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HYT7mQ2ja/t6BbG4swbmeUHgbB2sHNob61Efta+Yx6I=; b=h5oz3wzIMSymH/W9QUPMpdjXybvXBI8ivdCJgfvKDuucG/Vzx6raJtil8FjyaeGhkj 8PLrxJ4WK/GV4ftq3B95T6dngxiJnk/6lq5lyJULdL6xhYIEUtUdMdd9mAe/X3Cnzx9K KVIzxOtWn/B0xQk+mFMSWExCZdOw0Z2PLeN6Vb9iETCV3aIvS5I9qzxUDVQ6+kNtDWXc uMCWH3jfHMfjuADDKTDHwSG16+KoCp6O9HQU1TQaV34YdOvtUqV3tURvbsmNqqShuxjF La81UAug3An8pl1j/IWBr1lXVt44zQo8J9IEH48IcMEFZE5tcqwHOMqMjvCS9ba/nuLj 3icw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772023282; x=1772628082; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HYT7mQ2ja/t6BbG4swbmeUHgbB2sHNob61Efta+Yx6I=; b=Im2Wbqn6jergUzwscyxbIo9KTrDD1KrQMQ39xuSd1iF9S81iKtvBXooPen/NFu84eT RrLja9KessgNmOY2I09ycrlti2hvRuEZS6huylICBjFUt3Jrl972Se5TZ99eqbYAubwt CtHcYtOarzAIntLEU/x9bL3NnZgAOD0rEz2G45AfOtrEA34SqUgWIVhszBNAj3il8QYv 55Q79TI7jZ2xK+rZJ1iNiX802PbltTAIZjSoZn286MI0ySi4PHIucxE0SThV3VSdYVV8 ZwCvbwb4bOUEoX5/WW62GJheSoUOjqC0WLFa4uQFEstKX6Flv9/hNHpyzITG5RY0QwW2 SrvA== X-Forwarded-Encrypted: i=1; AJvYcCVuOc650VQ5NUzozK5xpopRVlx2s0RoaQq+mPFCPWVeABvTexl5ng25DQO4y3wFixklD7vUKd7oQhNarO8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyyq4fEeRVIzwTJQjXLF4P/OinoB8yqbfY4w/VX0m1LW6lwFKUA IxpN6AcCHFOiv//8ARs9k0hbo1gKq2C7/IGHiFOZoRbqbJjtYeZFaEl+DU3u+BEzuL3kKk2DfBd /1G7odLrXcGO6z93R0AksAXOkmHf7/za+QNMWVI8OhPB6ijIkNXDtKr6r2GOmiHuqmWw= X-Gm-Gg: ATEYQzyRJCBPKJ5bqNRuISCdVqeioIvZiZP3hT4t6WyHkDD1t/+sYwmWFLS17wiHJ67 uJCgrtsW5xeU9LuZ+/Tar2qRm86wSFqOuJtkHt/mzRaCByuPQrCWylhSaWy/Whmk4rYgmDVgB0D HHiNqQDMf9hhmJORwIMSNa5RnWXB35Ldkz1xX1P8KTDH3FHwcwlsgMi1VlRYs/kJ7quSXU0yfaO 8ELdawdqwcVYYsC3tc3GpKPl8/rgqnpqeJrZayP0nl0EGsIjyoO7NHbGLXC/bj6skyNmQNIgrMC YxxqT1skMlsuKKEtoD85zlaUlzlWbll0coHNLd983ahhsj9Swvjyai8d7VVjdugGSaf+80BN8T7 VPc3XoZrA9q5qOMISQd2YEIWLNKZh1oZU8ZCAC+EwdmP9tDZLKzn4mKWB/ro+lpzSxS6US6CZZZ w4NTk= X-Received: by 2002:a05:620a:1a25:b0:8c7:1aea:53b7 with SMTP id af79cd13be357-8cb8caa40f8mr1516386685a.9.1772023282389; Wed, 25 Feb 2026 04:41:22 -0800 (PST) X-Received: by 2002:a05:620a:1a25:b0:8c7:1aea:53b7 with SMTP id af79cd13be357-8cb8caa40f8mr1516383885a.9.1772023281901; Wed, 25 Feb 2026 04:41:21 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084f191b9sm500484366b.67.2026.02.25.04.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 04:41:21 -0800 (PST) Message-ID: <1a28d203-e0ee-4c0d-a6ac-7f50ab26bdeb@oss.qualcomm.com> Date: Wed, 25 Feb 2026 13:41:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/5] watchdog: qcom: add support to get the bootstatus from IMEM To: Kathiravan Thirumoorthy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org References: <20260225-wdt_reset_reason-v7-0-65d5b7e3e1eb@oss.qualcomm.com> <20260225-wdt_reset_reason-v7-4-65d5b7e3e1eb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260225-wdt_reset_reason-v7-4-65d5b7e3e1eb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Bb8f3qNyt1OKahk2sRCTp_fZyWsWNiim X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDEyMyBTYWx0ZWRfX9gPMr3K8fY2o AWkKihDv1PNdyr1Z/7vUoofpN461sGMpxsyFMkLKK+6ipWAsL6tz5jz5k/O17dohnEJ0LLUd81Q Pp6rJCT4TkfHoc9/KrllPt/qBKrZp9DyIbS0a03oixJq8pHqgpO9zP6dzDTfRRckocsbsQo8YFq SyHe84SnZ073gTem5XkOloXXwa4syzsN4wFoCwM7Q+cUzStIO7QJ14ZTH9QxZVXo4026H+nx0/x R7ATM222D04ViORuS4McNAz+0emuHtJKPi54yp6MkVQ+y8Iys5Lu6p4NpyyjrpFeKf3JgO4zid5 EE6ahUsuiuLIodq0RWOpkSDuWK8nK+S0tN9qBp6NeqztO2fCD/LONNm1jvv6fpfgEAkZ22D2iPt YrbWH1t7tpEbAEKP4YU7uuB67+XroHJU/H2Tpf9QwZlCdeSf/pouFI+FznYj8Ne7gNoORS1HkWB +r5zEvJZfX0g6CsbPEQ== X-Proofpoint-GUID: Bb8f3qNyt1OKahk2sRCTp_fZyWsWNiim X-Authority-Analysis: v=2.4 cv=dZWNHHXe c=1 sm=1 tr=0 ts=699eedf3 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=5uP7x7crlKMPZidxuXQA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_03,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250123 On 2/25/26 7:43 AM, Kathiravan Thirumoorthy wrote: > When the system boots up after a watchdog reset, the EXPIRED_STATUS bit > in the WDT_STS register is cleared. To identify if the system was > restarted due to WDT expiry, XBL update the information in the IMEM region. > Update the driver to read the restart reason from IMEM and populate the > bootstatus accordingly. > > With the CONFIG_WATCHDOG_SYSFS enabled, user can extract the information > as below: > > cat /sys/devices/platform/soc@0/f410000.watchdog/watchdog/watchdog0/bootstatus > 32 > > For backward compatibility, keep the EXPIRED_STATUS bit check. Add a new > function qcom_wdt_get_bootstatus() to read the restart reason from > IMEM. > > Signed-off-by: Kathiravan Thirumoorthy > --- [...] > +static int qcom_wdt_get_bootstatus(struct device *dev, struct qcom_wdt *wdt, > + u32 val) > +{ > + struct device_node *imem; > + struct resource res; > + void __iomem *addr; > + int ret; > + > + imem = of_parse_phandle(dev->of_node, "sram", 0); > + if (!imem) { > + > + /* Fallback to the existing check */ Odd \n above 'existing' is imprecise, perhaps something like /* Read the EXPIRED_STATUS bit as a fallback */ lg otherwise Reviewed-by: Konrad Dybcio Konrad