From: "Manu Abraham" <abraham.manu@gmail.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] dvb_frontend_ioctl(): fix check-after-use
Date: Wed, 1 Aug 2007 07:52:29 +0400 [thread overview]
Message-ID: <1a297b360707312052l14adb72el8ee59c74b7757605@mail.gmail.com> (raw)
In-Reply-To: <20070730222817.GE3972@stusta.de>
On 7/31/07, Adrian Bunk <bunk@stusta.de> wrote:
> The Coverity checker spotted that we have already oops'ed if "fe" was NULL.
>
> Since "fe" being NULL seems impossible at this point this patch removes
> the NULL check.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
> --- linux-2.6.23-rc1-mm1/drivers/media/dvb/dvb-core/dvb_frontend.c.old 2007-07-29 21:41:56.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/media/dvb/dvb-core/dvb_frontend.c 2007-07-29 21:42:16.000000000 +0200
> @@ -706,11 +706,11 @@ static int dvb_frontend_ioctl(struct ino
> struct dvb_frontend_private *fepriv = fe->frontend_priv;
> int err = -EOPNOTSUPP;
>
> dprintk ("%s\n", __FUNCTION__);
>
> - if (!fe || fepriv->exit)
> + if (fepriv->exit)
> return -ENODEV;
>
> if ((file->f_flags & O_ACCMODE) == O_RDONLY &&
> (_IOC_DIR(cmd) != _IOC_READ || cmd == FE_GET_EVENT ||
> cmd == FE_DISEQC_RECV_SLAVE_REPLY))
>
> -
Acked-by: Manu Abraham <manu@linuxtv.org>
next prev parent reply other threads:[~2007-08-01 3:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 22:28 Adrian Bunk
2007-08-01 3:52 ` Manu Abraham [this message]
2007-08-10 17:47 ` [v4l-dvb-maintainer] " Markus Rechberger
2007-08-10 23:19 ` Trent Piepho
2007-08-11 11:13 ` Markus Rechberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a297b360707312052l14adb72el8ee59c74b7757605@mail.gmail.com \
--to=abraham.manu@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®