From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD29C433E0 for ; Thu, 4 Jun 2020 03:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCE7720772 for ; Thu, 4 Jun 2020 03:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbgFDDIs (ORCPT ); Wed, 3 Jun 2020 23:08:48 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2157 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726146AbgFDDIr (ORCPT ); Wed, 3 Jun 2020 23:08:47 -0400 Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 1AA4597754FD4DB2E412; Thu, 4 Jun 2020 11:08:45 +0800 (CST) Received: from dggeme758-chm.china.huawei.com (10.3.19.104) by DGGEMM405-HUB.china.huawei.com (10.3.20.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 4 Jun 2020 11:08:44 +0800 Received: from [10.174.61.242] (10.174.61.242) by dggeme758-chm.china.huawei.com (10.3.19.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 4 Jun 2020 11:08:44 +0800 Subject: Re: [PATCH net-next 5/5] hinic: add support to get eeprom information To: Jakub Kicinski CC: , , , , , , References: <20200603062015.12640-1-luobin9@huawei.com> <20200603062015.12640-6-luobin9@huawei.com> <20200603200145.41cf76fd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: "luobin (L)" Message-ID: <1a2dbd8d-9e93-4dcf-dfb0-5a7186fd8729@huawei.com> Date: Thu, 4 Jun 2020 11:08:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200603200145.41cf76fd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.61.242] X-ClientProxiedBy: dggeme701-chm.china.huawei.com (10.1.199.97) To dggeme758-chm.china.huawei.com (10.3.19.104) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/6/4 11:01, Jakub Kicinski wrote: > On Wed, 3 Jun 2020 14:20:15 +0800 Luo bin wrote: >> add support to get eeprom information from the plug-in module >> with ethtool -m cmd. >> >> Signed-off-by: Luo bin > > drivers/net/ethernet/huawei/hinic/hinic_port.c:1386:5: warning: variable port_id set but not used [-Wunused-but-set-variable] > 1386 | u8 port_id; > | ^~~~~~~ > . > Will fix. Thanks.