From: Werner Sembach <wse@tuxedocomputers.com>
To: Armin Wolf <W_Armin@gmx.de>,
hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] uniwill-laptop: Input-related improvements
Date: Wed, 11 Feb 2026 13:37:09 +0100 [thread overview]
Message-ID: <1a302ede-5198-47a0-a714-ddb9b7796760@tuxedocomputers.com> (raw)
In-Reply-To: <20260210232946.302936-1-W_Armin@gmx.de>
Hi,
Am 11.02.26 um 00:29 schrieb Armin Wolf:
> This patch series contains a set of input-related improvements
> for the uniwill-laptop driver. The first patch renames the
> "fn_lock_toggle_enable" and "super_key_toggle_enable" sysfs attributes
> after it was discovered that the underlying hardware works differently
> than previously thought. This technically breaks user space
> applications using those sysfs attributes, but AFAIK no such users
> currently exist.
Just to note it down somewhere: Not every Uniwill device hast a shortcut to
enable/disable the super key, but the programmatic switch seems to work on all
devices (at least the ones I tested so far).
Best regards,
Werner
>
> The next two patches fix a potential crash and an issue with the fn
> lock status not being updated when using a key combination. The
> remaining patches ensure that when the users changes the fn lock
> status or enables/disables the super key using a key combination, a
> poll notification is being issued on the appropriate sysfs attr.
>
> Armin Wolf (5):
> platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs
> platform/x86: uniwill-laptop: Fix crash on unexpected battery event
> platform/x86: uniwill-laptop: Mark FN lock status as being volatile
> platform/x86: uniwill-laptop: Handle FN lock event
> platform/x86: uniwill-laptop: Handle super key lock events
>
> .../ABI/testing/sysfs-driver-uniwill-laptop | 10 +-
> drivers/platform/x86/uniwill/uniwill-acpi.c | 109 ++++++++++++------
> 2 files changed, 80 insertions(+), 39 deletions(-)
>
prev parent reply other threads:[~2026-02-11 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 23:29 Armin Wolf
2026-02-10 23:29 ` [PATCH 1/5] platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs Armin Wolf
2026-02-11 0:16 ` Werner Sembach
2026-02-12 6:43 ` Armin Wolf
2026-02-10 23:29 ` [PATCH 2/5] platform/x86: uniwill-laptop: Fix crash on unexpected battery event Armin Wolf
2026-02-10 23:29 ` [PATCH 3/5] platform/x86: uniwill-laptop: Mark FN lock status as being volatile Armin Wolf
2026-02-10 23:29 ` [PATCH 4/5] platform/x86: uniwill-laptop: Handle FN lock event Armin Wolf
2026-02-10 23:29 ` [PATCH 5/5] platform/x86: uniwill-laptop: Handle super key lock events Armin Wolf
2026-02-11 12:37 ` Werner Sembach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a302ede-5198-47a0-a714-ddb9b7796760@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=W_Armin@gmx.de \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®