From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Rob Herring <robh@kernel.org>, David Heidelberg <david@ixit.cz>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, ~okias/devicetree@lists.sr.ht
Subject: Re: [PATCH v3] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml
Date: Sun, 10 Oct 2021 23:01:24 +0200 [thread overview]
Message-ID: <1a315cff-fa34-0fac-8312-9a96d56966c7@canonical.com> (raw)
In-Reply-To: <1633894316.431235.3158667.nullmailer@robh.at.kernel.org>
On 10/10/2021 21:31, Rob Herring wrote:
> On Sat, 09 Oct 2021 18:19:42 +0200, David Heidelberg wrote:
>> Convert bindings for NXP PN544 NFC driver to YAML syntax.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> v2
>> - Krzysztof is a maintainer
>> - pintctrl dropped
>> - 4 space indent for example
>> - nfc node name
>> v3
>> - remove whole pinctrl
>> .../bindings/net/nfc/nxp,pn544.yaml | 61 +++++++++++++++++++
>> .../devicetree/bindings/net/nfc/pn544.txt | 33 ----------
>> 2 files changed, 61 insertions(+), 33 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
>> delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1538804
>
>
> pn547@28: 'clock-frequency' is a required property
> arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml
> arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml
>
I think clock-frequency should be dropped from I2C slave device.
Similarly to this one:
https://lore.kernel.org/linux-nfc/f955726a-eb2d-7b3e-9c5f-978358710eb6@canonical.com/T/#u
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-10-10 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 16:19 David Heidelberg
2021-10-09 17:20 ` Krzysztof Kozlowski
2021-10-10 14:27 ` Krzysztof Kozlowski
2021-10-10 19:31 ` Rob Herring
2021-10-10 21:01 ` Krzysztof Kozlowski [this message]
2021-10-17 16:18 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a315cff-fa34-0fac-8312-9a96d56966c7@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®