mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Question about config UPROBES and UPROBE_EVENTS
Date: Wed, 11 Sep 2024 14:40:56 +0800	[thread overview]
Message-ID: <1a3567d5-e558-351a-c45d-73b2e5a8788c@loongson.cn> (raw)

Hi Masami,

I am a little confused about config UPROBES and UPROBE_EVENTS.
Uprobes is the user-space counterpart to kprobes, I want to do
some small changes:

(1) since config KPROBES can be selectable, just make config UPROBES
     selectable too.

(2) since config KPROBE_EVENTS depends on KPROBES rather than select
     KPROBES, just make config UPROBE_EVENTS depends on UPROBES rather
     than select UPROBES.

Could you please let me know are you OK with the following changes?
If yes, I will send formal patches later.

-- >8 --
diff --git a/arch/Kconfig b/arch/Kconfig
index 975dd22a2dbd..5de2187d3440 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -124,7 +124,8 @@ config KPROBES_ON_FTRACE
           optimize on top of function tracing.

  config UPROBES
-       def_bool n
+       bool "Uprobes"
+       default n
         depends on ARCH_SUPPORTS_UPROBES
         help
           Uprobes is the user-space counterpart to kprobes: they
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 721c3b221048..7db0462a5d11 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -732,10 +732,9 @@ config KPROBE_EVENTS_ON_NOTRACE

  config UPROBE_EVENTS
         bool "Enable uprobes-based dynamic events"
-       depends on ARCH_SUPPORTS_UPROBES
+       depends on UPROBES
         depends on MMU
         depends on PERF_EVENTS
-       select UPROBES
         select PROBE_EVENTS
         select DYNAMIC_EVENTS
         select TRACING

Thanks,
Tiezhu


             reply	other threads:[~2024-09-11  6:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  6:40 Tiezhu Yang [this message]
2024-09-11 13:43 ` Steven Rostedt
2024-09-29 23:15 ` Masami Hiramatsu
2024-09-30  1:33   ` Tiezhu Yang
2024-09-30 14:06     ` Steven Rostedt
2024-09-30 15:28       ` Masami Hiramatsu
2024-09-30 15:32         ` Steven Rostedt
2024-09-30 15:43           ` Masami Hiramatsu
2024-10-01  6:30             ` Tiezhu Yang
2024-10-01 12:30               ` Steven Rostedt
2024-10-01 12:33                 ` Steven Rostedt
2024-10-01 12:32           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a3567d5-e558-351a-c45d-73b2e5a8788c@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®