From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 08/11] staging: rtl8192e: Remove constant variable fltr_src_sta_frame
Date: Tue, 3 Oct 2023 21:33:55 +0200 [thread overview]
Message-ID: <1a37a8be464bb25531657aa7c868201676d7abb6.1696360404.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1696360403.git.philipp.g.hortmann@gmail.com>
Remove variable fltr_src_sta_frame as it is set to 0 and unchanged. The
equation results accordingly. Remove dead code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 --
drivers/staging/rtl8192e/rtllib.h | 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 10 ----------
3 files changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 9c872819969a..f15f73be41a2 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -741,8 +741,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
priv->rtllib->iw_mode = IW_MODE_INFRA;
priv->rtllib->net_promiscuous_md = false;
priv->rtllib->intel_promiscuous_md_info.promiscuous_on = false;
- priv->rtllib->intel_promiscuous_md_info.fltr_src_sta_frame =
- false;
priv->rtllib->ieee_up = 0;
priv->retry_rts = DEFAULT_RETRY_RTS;
priv->retry_data = DEFAULT_RETRY_DATA;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index a02e8c976ca0..748ae8d35c1a 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1177,7 +1177,6 @@ struct rt_pmkid_list {
struct rt_intel_promisc_mode {
bool promiscuous_on;
- bool fltr_src_sta_frame;
};
/*************** DRIVER STATUS *****/
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index a7b6f837024d..1086dd0809be 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -956,16 +956,6 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
return -1;
}
- /* Filter packets sent by an STA that will be forwarded by AP */
- if (ieee->intel_promiscuous_md_info.promiscuous_on &&
- ieee->intel_promiscuous_md_info.fltr_src_sta_frame) {
- if ((fc & IEEE80211_FCTL_TODS) && !(fc & IEEE80211_FCTL_FROMDS) &&
- !ether_addr_equal(dst, ieee->current_network.bssid) &&
- ether_addr_equal(bssid, ieee->current_network.bssid)) {
- return -1;
- }
- }
-
/* Nullfunc frames may have PS-bit set, so they must be passed to
* hostap_handle_sta_rx() before being dropped here.
*/
--
2.42.0
next prev parent reply other threads:[~2023-10-03 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 19:32 [PATCH 00/11] staging: rtl8192e: Remove functions rawtx and promisc Philipp Hortmann
2023-10-03 19:33 ` [PATCH 01/11] staging: rtl8192e: Remove function _rtl92e_wx_set_rawtx() Philipp Hortmann
2023-10-03 19:33 ` [PATCH 02/11] staging: rtl8192e: Remove equation in function rtllib_xmit_inter() Philipp Hortmann
2023-10-03 19:33 ` [PATCH 03/11] staging: rtl8192e: Remove function rtllib_start_monitor_mode() Philipp Hortmann
2023-10-03 19:33 ` [PATCH 04/11] staging: rtl8192e: Remove unused variable raw_tx Philipp Hortmann
2023-10-03 19:33 ` [PATCH 05/11] staging: rtl8192e: Remove unused parameter mesh_flag Philipp Hortmann
2023-10-03 19:33 ` [PATCH 06/11] staging: rtl8192e: Remove function _rtl92e_wx_set_promisc_mode() Philipp Hortmann
2023-10-03 19:33 ` [PATCH 07/11] staging: rtl8192e: Remove function _rtl92e_wx_get_promisc_mode() Philipp Hortmann
2023-10-03 19:33 ` Philipp Hortmann [this message]
2023-10-03 19:34 ` [PATCH 09/11] staging: rtl8192e: Remove constant variable promiscuous_on Philipp Hortmann
2023-10-03 19:34 ` [PATCH 10/11] staging: rtl8192e: Remove constant variable net_promiscuous_md Philipp Hortmann
2023-10-03 19:34 ` [PATCH 11/11] staging: rtl8192e: Remove constant variable bToOtherSTA Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a37a8be464bb25531657aa7c868201676d7abb6.1696360404.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®