Re: [PATCH] Bluetooth: mgmt: Fix wrong param be used

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Clancy,


Thank you for your patch.

Am 05.01.24 um 04:11 schrieb clancy_shang@163.com:
> From: Clancy Shang <clancy.shang@quectel.com>
> 
> bluez lib could not receive MGMT_EV_DEVICE_FLAGS_CHANGED notifications
> after sending MGMT_OP_SET_DEVICE_FLAGS

Please add a dot/period at the end of sentences.

Please extend the commit message to describe your fix, and why it fixes 
the problem.

> Signed-off-by: Clancy Shang <clancy.shang@quectel.com>
> ---
>   net/bluetooth/mgmt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 9dd815b6603f..c74abdf3618f 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -5177,7 +5177,7 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
>   
>   done:
>   	if (status == MGMT_STATUS_SUCCESS)
> -		device_flags_changed(sk, hdev, &cp->addr.bdaddr, cp->addr.type,
> +		device_flags_changed(NULL, hdev, &cp->addr.bdaddr, cp->addr.type,
>   				     supported_flags, current_flags);
>   
>   	return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_DEVICE_FLAGS, status,


Kind regards,

Paul