mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jonathan Corbet <corbet@lwn.net>,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Kamalesh Babulal <kamalesh.babulal@oracle.com>,
	Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH-cgroup v4] cgroup: Show # of subsystem CSSes in cgroup.stat
Date: Fri, 26 Jul 2024 16:42:00 -0400	[thread overview]
Message-ID: <1a4963c0-9c90-4488-b13b-92019494741d@redhat.com> (raw)
In-Reply-To: <79fcaba1-552b-4969-84fc-70c5151508a5@redhat.com>

On 7/26/24 16:40, Waiman Long wrote:
>
>
> On 7/26/24 04:19, Michal Koutný wrote:
>>>>> +	for_each_css(css, ssid, cgroup) {
>>>>> +		if ((BIT(ssid) & cgrp_dfl_inhibit_ss_mask) ||
>>>>> +		    (cgroup_subsys[ssid]->root !=  &cgrp_dfl_root))
>>>>> +			continue;
>>>> Is this taken? (Given cgroup.stat is only on the default hierarchy.)
>>> I am not sure what you are asking here. Since cgroup.stat is a cgroup v2
>>> only control file, it won't show subsystems that are bound to cgroup v1.
>> So, is the if (...) ever true? (The file won't exist on v1.)
>
> A mixed cgroup v1/v2 environment is allowed, though not encouraged. We 
> can have some cgroup controllers bound to cgroup v2 and the rests to 
> cgroup v1. It is in this case that cgroup.stat will only show those 
> that are with cgroup v2.
>
> Regards,
> Longman
>


      parent reply	other threads:[~2024-07-26 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11  2:51 Waiman Long
2024-07-11  3:26 ` Roman Gushchin
2024-07-11 12:01   ` Waiman Long
2024-07-11 13:25   ` Kamalesh Babulal
2024-07-25 13:15 ` Michal Koutný
2024-07-25 20:05   ` Waiman Long
2024-07-26  8:19     ` Michal Koutný
2024-07-26 20:04       ` Tejun Heo
2024-07-26 20:36         ` Waiman Long
     [not found]       ` <79fcaba1-552b-4969-84fc-70c5151508a5@redhat.com>
2024-07-26 20:42         ` Waiman Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a4963c0-9c90-4488-b13b-92019494741d@redhat.com \
    --to=longman@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=kamalesh.babulal@oracle.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=roman.gushchin@linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®