From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DE5C77B73 for ; Sun, 16 Apr 2023 13:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbjDPNKI (ORCPT ); Sun, 16 Apr 2023 09:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230283AbjDPNKF (ORCPT ); Sun, 16 Apr 2023 09:10:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 279582D68 for ; Sun, 16 Apr 2023 06:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681650540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYjPZsCNrqGMbLHPtu1l9hSHzXZoEudtLitWN2eVd14=; b=hQ4ZSAFnL0dRuhZPv29tZkpqqJNod9B+prjdQYeboj7zntc32NUOYSOMjEHPMgGBDSSUQ0 RpGGrGJxUWcz7gB8SJ3Dgcvr7WCtHCvAg6qUMZT3XHAiASw3Kam4y7BbLdtAMkKYQ0vKhB 8bmha8QRVxCybpDGTSHZ0Zq15RmEc/o= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-yo4Fh7dyOPyvlNFolRGlgg-1; Sun, 16 Apr 2023 09:08:58 -0400 X-MC-Unique: yo4Fh7dyOPyvlNFolRGlgg-1 Received: by mail-ej1-f71.google.com with SMTP id s14-20020a17090699ce00b0093994122eddso7678648ejn.17 for ; Sun, 16 Apr 2023 06:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681650538; x=1684242538; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YYjPZsCNrqGMbLHPtu1l9hSHzXZoEudtLitWN2eVd14=; b=GHw48lrNuhoD0WBGXLi2bN+OzptdUnfPKVMiKzEe7vl9K2lJR96GeqryDNbKOMGwCQ tnfq6QLqbkWQLxFgqk7jolNJzWT4+j2+g4HNQmTc1IL47c2BX+pCg/A0uGDjsXJP661T B2Qn/kyOR9j71yK/HVwmq2E062vqRRjkIFiGbSDWxP+Vums8LRclP/fPMWnkllquq5QV k/XjwNBWLEa+vizRzBtFt0OmevApOp+1PnS8eTC59Eaqaw9yCq7wQK6FwmZqr/BDLzIG 7otLiRggSp90mTnC0gwmI8BtKN3/APg06qygDJuUMTUHJ2T7sgksxRh454KbEZBK2B+n CMXw== X-Gm-Message-State: AAQBX9enirDuw0+Na92nsx8cOEFRWaz5GI/yYMIcGgUKuuhISR4Nb3zv 39D+fFHoj4HtcKRCMM5/Q1qCArLDmXN9gwikoMo8c48z4CKaLyB3/Q72C3VbeGjRPE/Cu82N9My d9q97RxVmuxib7Vk3ZpoKX2YX X-Received: by 2002:a17:906:5616:b0:94a:4107:3975 with SMTP id f22-20020a170906561600b0094a41073975mr3988005ejq.76.1681650537909; Sun, 16 Apr 2023 06:08:57 -0700 (PDT) X-Google-Smtp-Source: AKy350Y8T5yCBh6wbbbBr7heC2qmakzdZtsbI8F4J0aabpm/Yfbud6LdMSwb8q3jPy/KSS4e7PhRhQ== X-Received: by 2002:a17:906:5616:b0:94a:4107:3975 with SMTP id f22-20020a170906561600b0094a41073975mr3987989ejq.76.1681650537667; Sun, 16 Apr 2023 06:08:57 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id g25-20020a17090613d900b0094edfbd475csm3581864ejc.127.2023.04.16.06.08.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 06:08:57 -0700 (PDT) Message-ID: <1a4a7016-a871-abbe-e8cb-c8a7241de50f@redhat.com> Date: Sun, 16 Apr 2023 15:08:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Staging: media: atomisp: include: mmu: include instead of Content-Language: en-US, nl To: Andy Shevchenko , Anup Sharma Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, andy@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org References: From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/16/23 12:01, Andy Shevchenko wrote: > On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma wrote: >> >> Fix following checkpatch.pl warning by including >> instead of > > Missing period at the end. But the entire patch seems unnecessary > since it's all about x86, and we have more arch headers there anyway. > Anyway it's up to Hans. Also see below. Right, given how much real work this driver still needs this really feels like needless churn, so I'm not going to take this patch, sorry. Regards, Hans > > ... > >> #include >> -#include >> +#include >> >> #include >> #include > > This seems a bit chaotic with the ordering of the headers here. > > ... > > If you want a good patch, you need to understand what headers are > _really_ being used in the header file. Then drop unused, try to > compile that and fix all files that will have missing headers after > that. This will be a very useful clean up! >