mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aditya Garg <aditya.garg@linux.dev>
To: Alex Deucher <alexdeucher@gmail.com>,
	Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: airlied@gmail.com, alexander.deucher@amd.com,
	amd-gfx@lists.freedesktop.org, christian.koenig@amd.com,
	dev@deq.rocks, dri-devel@lists.freedesktop.org,
	ed@aicharmers.com, kenneth.feng@amd.com,
	linux-kernel@vger.kernel.org, simona@ffwll.ch
Subject: Re: [PATCH v4] drm/amd/pm: defer UCLK DPM on selected Apple Navi GPUs
Date: Tue, 3 Nov 2026 21:30:55 +0530	[thread overview]
Message-ID: <1a4eb0fb-adbe-4884-8f37-b5ffa6782b84@linux.dev> (raw)
In-Reply-To: <CADnq5_N-sobVK3qitqABjqMv2HMyGNdxX0XMXa4TZzVnMv8MLA@mail.gmail.com>


Hi Alex
> On Tue, Nov 3, 2026 at 10:01 AM Atharva Tiwari
> <atharvatiwarilinuxdev@gmail.com> wrote:
>>
>>> It is the same issue.  I don't want two fixes for the same issue. I
>>> just sent an updated version of this patch expanded to cover more
>>> macs.
>>>
>>> Alex
>>
>> How is the problems same exactly?, Does initializing UCLK later change the
>> PPTable?, and as said this is not even a solution for iMacs, so why are we
>> still trying to upstream this?, and btw initializing UCLK later with 5K,
>> makes it not initialize at all, so the patch is just wrong.
> 
> I asked around internally with the windows team about this issue and
> was told macs needed to enable UCLK DPM later, but no one was aware of
> any uclk dpm patching.We have filed multiple bug reports regarding the 5K issue on iMacs but they have simply been tagged and left over for many years. Now suddenly one day a person without properly consulting the author sends a patch upstream, inspite of the author himself saying doesn't work.

I own a MacBookPro16,1 and the v5 send doesn't work at all to fix it for me.

Since Windows team is willing to help us please fix the 5K issue on iMacs as well. And the devs aim achieve hybrid graphics, which Windows does not support.

For my testing results, the patch in v5 (https://lore.kernel.org/all/20261103143014.522592-1-alexander.deucher@amd.com/T/#u) doesn't solve what is claims to. It might be possible its needed, but in that case even more workups and patches should also needed to get the GPUs running properly on Linux only.

I believe patches submitted by the author himself should be acknowledged. We already are victims of AI cannon, pls don't make things worse.

Nacked-by: Aditya Garg <aditya.garg@linux.dev>

  parent reply	other threads:[~2026-11-03 16:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 14:40 Ed Schofield
2026-10-29 21:57 ` Alex Deucher
2026-10-30  1:55   ` Atharva Tiwari
2026-10-30 11:30   ` André Eikmeyer
2026-11-03 14:30     ` Alex Deucher
2026-11-03 15:00       ` Atharva Tiwari
2026-11-03 15:14         ` Alex Deucher
2026-11-03 15:59           ` André Eikmeyer
2026-11-03 16:00           ` Aditya Garg [this message]
2026-11-03 15:25       ` André Eikmeyer
2026-11-03 15:53         ` Alex Deucher
2026-11-03 16:05           ` Atharva Tiwari
2026-11-03 16:15           ` André Eikmeyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a4eb0fb-adbe-4884-8f37-b5ffa6782b84@linux.dev \
    --to=aditya.garg@linux.dev \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=atharvatiwarilinuxdev@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dev@deq.rocks \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ed@aicharmers.com \
    --cc=kenneth.feng@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®