From: Mukesh Ojha <mojha@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID'
Date: Sat, 6 Apr 2019 13:52:37 +0530 [thread overview]
Message-ID: <1a4f101a-6bb1-821b-2130-6590b8048948@codeaurora.org> (raw)
In-Reply-To: <20190406031134.59419-1-yuehaibing@huawei.com>
On 4/6/2019 8:41 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.c: In function 'rtl92e_check_adapter':
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.c:36:6: warning:
> variable 'VenderID' set but not used [-Wunused-but-set-variable]
> u16 VenderID;
> ^
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
> index bab41ab7c0a5..1d992d5c4e17 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
> @@ -33,12 +33,10 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev,
> bool rtl92e_check_adapter(struct pci_dev *pdev, struct net_device *dev)
> {
> struct r8192_priv *priv = (struct r8192_priv *)rtllib_priv(dev);
> - u16 VenderID;
> u16 DeviceID;
> u8 RevisionID;
> u16 IrqLine;
>
> - VenderID = pdev->vendor;
> DeviceID = pdev->device;
> RevisionID = pdev->revision;
> pci_read_config_word(pdev, 0x3C, &IrqLine);
>
>
>
prev parent reply other threads:[~2019-04-06 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 3:11 YueHaibing
2019-04-06 8:22 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a4f101a-6bb1-821b-2130-6590b8048948@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®