mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>, Roy Luo <royluo@google.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Badhri Jagan Sridharan" <badhri@google.com>,
	"Doug Anderson" <dianders@google.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	"Joy Chakraborty" <joychakr@google.com>,
	"Naveen Kumar" <mnkumar@google.com>
Subject: Re: [PATCH v7 2/2] phy: Add Google Tensor SoC USB PHY driver
Date: Sat, 22 Nov 2025 13:49:36 +0100	[thread overview]
Message-ID: <1a53d473-fc13-4ac5-ba52-4701d95e3073@kernel.org> (raw)
In-Reply-To: <CADrjBPpLn9qzg1y5_c_0CYL2U8p6taMWtPOw5RykAO4=4uNeUA@mail.gmail.com>

On 22/11/2025 13:48, Peter Griffin wrote:
> Hi Roy,
> 
> On Fri, 21 Nov 2025 at 08:56, Roy Luo <royluo@google.com> wrote:
>>
>> Support the USB PHY found on Google Tensor G5 (Laguna). This
>> particular USB PHY supports both high-speed and super-speed
>> operations, and is integrated with the SNPS DWC3 controller that's
>> also on the SoC. This initial patch specifically adds functionality
>> for high-speed.
>>
>> Co-developed-by: Joy Chakraborty <joychakr@google.com>
>> Signed-off-by: Joy Chakraborty <joychakr@google.com>
>> Co-developed-by: Naveen Kumar <mnkumar@google.com>
>> Signed-off-by: Naveen Kumar <mnkumar@google.com>
>> Signed-off-by: Roy Luo <royluo@google.com>
>> ---
>>  drivers/phy/Kconfig          |  13 ++
>>  drivers/phy/Makefile         |   1 +
>>  drivers/phy/phy-google-usb.c | 292 +++++++++++++++++++++++++++++++++++++++++++
> 
> Please add this new file to Tensor SoC MAINTAINERS entry so it's
> easier to review future patches.
> 
>>  3 files changed, 306 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 678dd0452f0aa0597773433f04d2a9ba77474d2a..af14ec74542a9879c856dee8236753990fdf3705 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -101,6 +101,19 @@ config PHY_NXP_PTN3222
>>           schemes. It supports all three USB 2.0 data rates: Low Speed, Full
>>           Speed and High Speed.
>>
>> +config PHY_GOOGLE_USB
>> +       tristate "Google Tensor SoC USB PHY driver"
>> +       depends on HAS_IOMEM
>> +       depends on OF
>> +       depends on TYPEC
> 
> Add COMPILE_TEST for build testing.

... and this probably should depend on your ARCH_xxx || COMPILE_TEST

Same for USB DWC driver.


Best regards,
Krzysztof

  reply	other threads:[~2025-11-22 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  8:56 [PATCH v7 0/2] Add Google Tensor SoC USB PHY support Roy Luo
2025-11-21  8:56 ` [PATCH v7 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY Roy Luo
2025-11-21  8:56 ` [PATCH v7 2/2] phy: Add Google Tensor SoC USB PHY driver Roy Luo
2025-11-22 12:48   ` Peter Griffin
2025-11-22 12:49     ` Krzysztof Kozlowski [this message]
2025-12-05  3:51       ` Roy Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a53d473-fc13-4ac5-ba52-4701d95e3073@kernel.org \
    --to=krzk@kernel.org \
    --cc=andre.draszik@linaro.org \
    --cc=badhri@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=joychakr@google.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mnkumar@google.com \
    --cc=p.zabel@pengutronix.de \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=royluo@google.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®