From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755263AbcEZTcH (ORCPT ); Thu, 26 May 2016 15:32:07 -0400 Received: from dec59.ruk.cuni.cz ([195.113.2.17]:50920 "HELO dec59.ruk.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755238AbcEZTcF (ORCPT ); Thu, 26 May 2016 15:32:05 -0400 Date: 26 May 2016 19:25:22 -0000 MBOX-Line: From 1a546e24f0fa4839deffd6e708ad10dd14219cb6 Mon Sep 17 00:00:00 2001 Message-Id: <1a546e24f0fa4839deffd6e708ad10dd14219cb6.1464042565.git.hramrach@gmail.com> From: Michal Suchanek Subject: [PATCH] fbtft: limit transfer length by spi device limit To: Thomas Petazzoni , "Noralf Tronnes" , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some SPI controllers can transfer only small piece of data at a time. Since SPI core gained a function to get the maximum transfer length use it. Signed-off-by: Michal Suchanek --- Tested on sunxi spi with DMA enabled and disabled. Makes a visible speed difference and display works in either case. drivers/staging/fbtft/fbtft-core.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 0c1a77c..f3bdc8f 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -1346,6 +1346,15 @@ int fbtft_probe_common(struct fbtft_display *display, return PTR_ERR(pdata); } + if (sdev && (spi_max_transfer_size(sdev) < SIZE_MAX)) + if ((pdata->txbuflen <= 0) || (pdata->txbuflen > spi_max_transfer_size(sdev))) { + dev_warn(dev, + "Limiting used buffer size %i -> %i due to device %s transfer size limitation", + pdata->txbuflen, spi_max_transfer_size(sdev), + dev_name(&sdev->dev)); + pdata->txbuflen = spi_max_transfer_size(sdev); + } + info = fbtft_framebuffer_alloc(display, dev, pdata); if (!info) return -ENOMEM; -- 2.8.1