From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D551D256C6D for ; Thu, 18 Jun 2026 10:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781779878; cv=none; b=AT99izQ1bJWkfT7jNNS2qpTRkfUDCPXH8AwLZP85J4Hr+W3h9d1Wj+Ku8698Qv9hExcRKEaJKUODY6mQpSYLPub6oWbojagW9fypMEIQ9j2iyqolBuBBeAJE08rAh/Tg2L2fSbOyCiU5DHXnRp8ommvV6jNR+l2ZgV3jUQcZISQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781779878; c=relaxed/simple; bh=GtAjYXmPGxnwaGEw/Du49sp6idTnlDczLHJXmY2DajA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nIoOJPcbdWa2uvbs4M8biOng1rN9AeWaxY4qJLis5ibLW9SaZY7Yv7TfuAli/DKj8NuV/YCtEGKG/InUaU3EQ9y/nODNNgojiwRgbmlNcBheHM2YZ6w32PZBo+LHjRnVSVQ1Diz+3BWvm5ATzyIsPvjVUc3QzA78AUgpk54ye8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vituv40R; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vituv40R" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-39980aa41fbso176621fa.3 for ; Thu, 18 Jun 2026 03:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781779874; x=1782384674; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KNAKlXEYaxZFctOwMRDsRkHXgZuOff9zmqCb7Yt/btk=; b=vituv40RXz2rbZTD8iv7pmkp5cHQK6eDQgh8xgImIKX1xk1emY5fYwzXzevFZerCCl s3DLxZuOfALLmqcanI6c/jLpi0w4nkyKfYn9GxhyciodTsiRnpOjrBD9NrPgPN4KOwWi Gj3qdm4ZoX5ZhPNSi8PcAF1x1VynNFyC1IXXH5Ql+KeWa4qMBpPg9gt6K5SFSZieEwOd V9mYmKOKkE07dsHdqOMPvtqgQ1iN8430L2SPtPCn+iEC/UDG2lN2JBMxK79Dj2COwhOK kNYCBYqj4ohSndpji/ztM3gz4f7/WvBTpFCXUWzdBNEokZjFaVgqRoIc0CMyZYvH9Ukv hMZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781779874; x=1782384674; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KNAKlXEYaxZFctOwMRDsRkHXgZuOff9zmqCb7Yt/btk=; b=c3YJL/YbJeQL9t58tpgyHAb4i+1CdLuLnpL5KSplj5+izkqDU7tv8stHHK0Zsm4Z7A DWNuWBP2fcvBe8qbBbD5162zpPAyMnX6dg7L53lLcSYMDghFeGvMHbVmZbMnXTN4kw86 QW0nvSyS6IImg+DHUhhNm4DjUErQnQLvBzNVPzXgU7CV0Gvqkaw48YtFZ+ipALfP5rHK wJeKIdDAI0hRzp4nwpb8sc/I03uMmRJu11BKXGh4pbHyPNSBf7SfH9BhDuZ1ElKzUCMI FTCNxz7su3FTq/DRogkZNjoN10GpB3oYpmfNwazawC9N5dAm5LuGPkdsExnp7PO46ed/ olsQ== X-Forwarded-Encrypted: i=1; AFNElJ+HT95vxKiurPAAwy9xjcY/I7jRIJxxZOd9MiIj7QywYAj9xtqpuoNpO58oOoX7a1iyha+ikHdVA/QdADk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxy1tLLNl1pymLqU8VxTFlWB+sqZBnADxdsDUIPy0cixU60rc80 jodSlnDr/k3TNGAvgOVZQUCNgwV0SiVg1iVqy4hiLz5oWW6tFBlCWqBQkuhfX1dcQczb+5om2or m1RIykQI= X-Gm-Gg: AfdE7ckTnM953Qwj6S7CIdFtl+xuuh+vVGWj9vqyxRGLK4R/9bYGKWphtSfC+k4IMUY sISEOPWpUuThXO2hzjG+aGAPJUOtGqBeMqZL/+I0crSMUPnA0mouoovboo/Yix6kMFAyi3mOD/g SDSdBtkqHMpobWxANXS5hL397JLmQw4upaQ7ZD6wXYw052JUDOXc199FgutUPyHoLMGCAI9W42g 4co9d/PZZljXlvWozIuzqim6VWEpeo0dAQncT9rRM4G83JVDNOFUIepIsyV7zLW5XPNy81bm2fm O/KY6lKu+9ekJLf0Dugr1L03RmAlqgGM0bbJqjSAEzlRIU6An6ULMP2gLMIvGT1aHS2tD9pQRJb JE2J+QfQ70ZyJxK5rffrKrdgtC+a1Nl2zZbches2D6lmUmCirYVICl2dYxvNiiAGuZg0pG0ZGJe ZqG747N1+RUTCEzI1hhC8XL9ljakXk2ZkAMNQ04LYrxq3mQHzD3hmoRa4rLa2lKoXSG+FxnCCXs lmKsw== X-Received: by 2002:a2e:bd09:0:b0:396:92eb:36a0 with SMTP id 38308e7fff4ca-399776a5fb2mr5207351fa.0.1781779873612; Thu, 18 Jun 2026 03:51:13 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3995c19a6c4sm24284941fa.29.2026.06.18.03.51.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 03:51:13 -0700 (PDT) Message-ID: <1a57863c-831a-411c-a0ae-da3d4f1fd6a0@linaro.org> Date: Thu, 18 Jun 2026 13:50:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: i2c: og0va1b: Add OmniVision OG0VA1B camera sensor To: Wenmeng Liu , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260618-og0va1b-v1-0-dda71bb83009@oss.qualcomm.com> <20260618-og0va1b-v1-2-dda71bb83009@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260618-og0va1b-v1-2-dda71bb83009@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Wenmeng. On 6/18/26 13:37, Wenmeng Liu wrote: > Add V4L2 sub device driver for OmniVision OG0VA1B image sensor. > OmniVision OG0VA1B is an image sensor, which produces frames in 10-bit > raw output format (Y10) over a 1-lane MIPI CSI-2 interface and supports > the 640x480 (VGA) resolution. > > Signed-off-by: Wenmeng Liu > --- > MAINTAINERS | 1 + > drivers/media/i2c/Kconfig | 10 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/og0va1b.c | 867 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 879 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5aa846c8479b20651291d5bd2e316308310f826c..85a06eb9eacc410a565b80d56979eaa565515d0e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19891,6 +19891,7 @@ M: Wenmeng Liu > L: linux-media@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/media/i2c/ovti,og0va1b.yaml > +F: drivers/media/i2c/og0va1b.c > > OMNIVISION OG0VE1B SENSOR DRIVER > M: Vladimir Zapolskiy > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 5d173e0ecf424f2f204f8d426be818e44357f8e4..56680772f5f47b4629c4e17f5a5feba08b1d94fc 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -363,6 +363,16 @@ config VIDEO_OG01A1B > To compile this driver as a module, choose M here: the > module will be called og01a1b. > > +config VIDEO_OG0VA1B > + tristate "OmniVision OG0VA1B sensor support" > + select V4L2_CCI_I2C > + help > + This is a Video4Linux2 sensor driver for the OmniVision > + OG0VA1B camera. > + > + To compile this driver as a module, choose M here: the > + module will be called og0va1b. > + > config VIDEO_OG0VE1B > tristate "OmniVision OG0VE1B sensor support" > select V4L2_CCI_I2C > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile > index e45359efe0e41e13e3c0869e5ead7d6cf4aca3a7..c60851c7fe07e3bdc511c5f482525ba7a044f48e 100644 > --- a/drivers/media/i2c/Makefile > +++ b/drivers/media/i2c/Makefile > @@ -83,6 +83,7 @@ obj-$(CONFIG_VIDEO_MT9V011) += mt9v011.o > obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o > obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o > obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o > +obj-$(CONFIG_VIDEO_OG0VA1B) += og0va1b.o > obj-$(CONFIG_VIDEO_OG0VE1B) += og0ve1b.o > obj-$(CONFIG_VIDEO_OS05B10) += os05b10.o > obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o > diff --git a/drivers/media/i2c/og0va1b.c b/drivers/media/i2c/og0va1b.c > new file mode 100644 > index 0000000000000000000000000000000000000000..f0505b7ba7f329ad57ffafa8f90a24204f002d3c > --- /dev/null > +++ b/drivers/media/i2c/og0va1b.c > @@ -0,0 +1,867 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * OmniVision OG0VA1B Camera Sensor Driver > + * > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > + > +#define OG0VA1B_REG_CHIP_ID CCI_REG16(0x300a) > +#define OG0VA1B_CHIP_ID 0xC756 This is the same chip id as of the OG0VE1B sensor device. What's the difference between these two sensors, and do you find it possible to add support of OG0VA1B sensor/modes into OG0VE1B sensor driver? Or is it just the same device? Hardware specifics described in dt changes also does not show a difference in comparison to ovti,og0ve1b.yaml. -- Best wishes, Vladimir