From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: andrzej.p@collabora.com, asmadeus@codewreck.org, corbet@lwn.net,
ericvh@kernel.org, gregkh@linuxfoundation.org,
kernel@pengutronix.de, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux_oss@crudebyte.com, lucho@ionkov.net, v9fs@lists.linux.dev
Subject: Re: [PATCH v10 1/3] usb: gadget: function: move u_f.h to include/linux/usb/func_utils.h
Date: Tue, 27 Aug 2024 18:46:39 +0200 [thread overview]
Message-ID: <1a5d3a68-56e5-4084-b86c-e60542cbbb98@wanadoo.fr> (raw)
In-Reply-To: <20240116-ml-topic-u9p-v10-1-a85fdeac2c52@pengutronix.de>
Le 26/08/2024 à 23:47, Michael Grzeschik a écrit :
> We move the func_utils.h header to include/linux/usb to be
> able to compile function drivers outside of the
> drivers/usb/gadget/function directory.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>
> ---
> v9 -> v10:
> - respect alphabetical order
> - correctly changed filename in func_utils.h itself
>
...
> index e313c3b8dcb19..e7b69e3145c07 100644
> --- a/drivers/usb/gadget/u_f.h
> +++ b/include/linux/usb/func_utils.h
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * u_f.h
> + * func_utils.h
> *
> * Utility definitions for USB functions
> *
>
Maybe the include guard could be updated as-well?
By include guard I mean:
#ifndef __U_F_H__
#define __U_F_H__
...
#endif /* __U_F_H__ */
s/__U_F_H__/_FUNC_UTILS_H_/ or something like that.
CJ
next prev parent reply other threads:[~2024-08-27 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 21:47 [PATCH v10 0/3] usb: gadget: 9pfs transport Michael Grzeschik
2024-08-26 21:47 ` [PATCH v10 1/3] usb: gadget: function: move u_f.h to include/linux/usb/func_utils.h Michael Grzeschik
2024-08-27 16:46 ` Christophe JAILLET [this message]
2024-08-27 17:13 ` Michael Grzeschik
2024-08-26 21:47 ` [PATCH v10 2/3] net/9p/usbg: Add new usb gadget function transport Michael Grzeschik
2024-08-30 15:15 ` kernel test robot
2024-08-26 21:47 ` [PATCH v10 3/3] tools: usb: p9_fwd: add usb gadget packet forwarder script Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a5d3a68-56e5-4084-b86c-e60542cbbb98@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andrzej.p@collabora.com \
--cc=asmadeus@codewreck.org \
--cc=corbet@lwn.net \
--cc=ericvh@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=m.grzeschik@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®