From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sumeet Pawnikar <sumeet4linux@gmail.com>,
rafael@kernel.org, amit.kachhap@gmail.com,
daniel.lezcano@kernel.org, thara.gopinath@gmail.com,
talel@amazon.com, hayashi.kunihiko@socionext.com,
mhiramat@kernel.org, mmayer@broadcom.com,
viresh.kumar@linaro.org, sumitg@nvidia.com,
peter.griffin@linaro.org, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, cw00.choi@samsung.com,
Frank.Li@nxp.com, s.hauer@pengutronix.de, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, sven@kernel.org,
j@jannau.net, marcan@marcan.st, casey.connolly@linaro.org,
sre@kernel.org, wens@kernel.org, t.schramm@manjaro.org
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de,
imx@lists.linux.dev, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] power: Use %pe to print error pointers symbolically
Date: Sun, 6 Sep 2026 08:30:07 +0200 [thread overview]
Message-ID: <1a5fb9bb-d057-4579-8b2c-b81aa16a61cb@kernel.org> (raw)
In-Reply-To: <20260906061755.5103-6-sumeet4linux@gmail.com>
On 06/09/2026 08:17, Sumeet Pawnikar wrote:
> }
> diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
> index 1bcb60cf763d..48643f7bf503 100644
> --- a/drivers/power/supply/cw2015_battery.c
> +++ b/drivers/power/supply/cw2015_battery.c
> @@ -658,8 +658,8 @@ static int cw_bat_probe(struct i2c_client *client)
>
> cw_bat->regmap = devm_regmap_init_i2c(client, &cw2015_regmap_config);
> if (IS_ERR(cw_bat->regmap)) {
> - dev_err(cw_bat->dev, "Failed to allocate regmap: %ld\n",
> - PTR_ERR(cw_bat->regmap));
> + dev_err(cw_bat->dev, "Failed to allocate regmap: %pe\n",
> + cw_bat->regmap);
> return PTR_ERR(cw_bat->regmap);
return dev_err_probe
Instead you should use dev_err_probe and drop the last argument.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-06 6:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 6:17 [PATCH 0/5] PM: " Sumeet Pawnikar
2026-09-06 6:17 ` [PATCH 1/5] powercap: intel_rapl: " Sumeet Pawnikar
2026-09-06 6:28 ` Krzysztof Kozlowski
2026-09-06 6:17 ` [PATCH 2/5] thermal: " Sumeet Pawnikar
2026-09-06 6:29 ` Krzysztof Kozlowski
2026-09-06 6:17 ` [PATCH 3/5] cpufreq: " Sumeet Pawnikar
2026-09-07 4:39 ` Viresh Kumar
2026-09-06 6:17 ` [PATCH 4/5] devfreq: " Sumeet Pawnikar
2026-09-06 6:30 ` Krzysztof Kozlowski
2026-09-06 6:17 ` [PATCH 5/5] power: " Sumeet Pawnikar
2026-09-06 6:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a5fb9bb-d057-4579-8b2c-b81aa16a61cb@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=amit.kachhap@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=casey.connolly@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=j@jannau.net \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mmayer@broadcom.com \
--cc=myungjoo.ham@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sre@kernel.org \
--cc=sumeet4linux@gmail.com \
--cc=sumitg@nvidia.com \
--cc=sven@kernel.org \
--cc=t.schramm@manjaro.org \
--cc=talel@amazon.com \
--cc=thara.gopinath@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®