From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754009AbcHaA7D (ORCPT ); Tue, 30 Aug 2016 20:59:03 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:39249 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbcHaA7B (ORCPT ); Tue, 30 Aug 2016 20:59:01 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <6abfa5eb6b2794f720bc470c4661aca9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] PCI: rockchip: Correct the register value for clearing client interrupts To: Bjorn Helgaas , Brian Norris References: <1472505251-122204-1-git-send-email-briannorris@chromium.org> <20160829235742.GB14177@localhost> Cc: shawn.lin@rock-chips.com, Bjorn Helgaas , linux-kernel@vger.kernel.org, Brian Norris , Wenrui Li , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org From: Shawn Lin Message-ID: <1a689435-c336-ff81-a231-4c17e19fa2f5@rock-chips.com> Date: Wed, 31 Aug 2016 08:58:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160829235742.GB14177@localhost> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/30 7:57, Bjorn Helgaas wrote: > On Mon, Aug 29, 2016 at 02:14:11PM -0700, Brian Norris wrote: >> I'm pretty sure the bitwise 'or' was meant for the value parameter, not >> the register parameter. >> >> This resolves an interrupt storm, where if we receive any client IRQs >> (e.g., correctable errors), we fail to ever clear them properly, so they >> reoccur indefinitely. >> >> Fixes: 199410f6270e ("PCI: rockchip: Add Rockchip PCIe controller support") >> Signed-off-by: Brian Norris >> Cc: Shawn Lin > > Shawn, please confirm. If this patch is correct, I'll fold it into > the initial commit that adds the driver. yes, Brian's patch is correct. I probably didn't notice this as the client interrput on EVB-rev1 board which I was using is broken, so my SSD didn't actually yelled at this irqstorm. Brain, thanks for fixing this. > >> --- >> Patched against git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/host-rockchip >> >> drivers/pci/host/pcie-rockchip.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c >> index 8fb47ee9eaee..e77aec3cc869 100644 >> --- a/drivers/pci/host/pcie-rockchip.c >> +++ b/drivers/pci/host/pcie-rockchip.c >> @@ -689,9 +689,10 @@ static irqreturn_t rockchip_pcie_client_irq_handler(int irq, void *arg) >> PCIE_CLIENT_INT_MSG | PCIE_CLIENT_INT_HOT_RST | >> PCIE_CLIENT_INT_DPA | PCIE_CLIENT_INT_FATAL_ERR | >> PCIE_CLIENT_INT_NFATAL_ERR | >> - PCIE_CLIENT_INT_CORR_ERR), >> - PCIE_CLIENT_INT_STATUS | >> - PCIE_CLIENT_INT_PHY); >> + PCIE_CLIENT_INT_CORR_ERR | >> + PCIE_CLIENT_INT_PHY), >> + PCIE_CLIENT_INT_STATUS); >> + >> return IRQ_HANDLED; >> } >> >> -- >> 2.8.0.rc3.226.g39d4020 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pci" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards Shawn Lin