From: Gao Xiang <gaoxiang25@huawei.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Chao Yu <yuchao0@huawei.com>, <linux-erofs@lists.ozlabs.org>,
Greg KH <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH] staging: erofs: drop unneeded -Wall addition
Date: Wed, 15 May 2019 13:18:43 +0800 [thread overview]
Message-ID: <1a69420a-95c1-bd96-4382-229bcae391b0@huawei.com> (raw)
In-Reply-To: <20190515043123.9106-1-yamada.masahiro@socionext.com>
On 2019/5/15 12:31, Masahiro Yamada wrote:
> The top level Makefile adds -Wall globally:
>
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>
> I see two "-Wall" added for compiling objects in drivers/staging/erofs/.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Looks good to me and sorry about adding this flag...
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Thanks,
Gao Xiang
> ---
>
> drivers/staging/erofs/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/Makefile b/drivers/staging/erofs/Makefile
> index 38ab344a285e..a34248a2a16a 100644
> --- a/drivers/staging/erofs/Makefile
> +++ b/drivers/staging/erofs/Makefile
> @@ -2,7 +2,7 @@
>
> EROFS_VERSION = "1.0pre1"
>
> -ccflags-y += -Wall -DEROFS_VERSION=\"$(EROFS_VERSION)\"
> +ccflags-y += -DEROFS_VERSION=\"$(EROFS_VERSION)\"
>
> obj-$(CONFIG_EROFS_FS) += erofs.o
> # staging requirement: to be self-contained in its own directory
>
next prev parent reply other threads:[~2019-05-15 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 4:31 Masahiro Yamada
2019-05-15 5:18 ` Gao Xiang [this message]
2019-05-15 6:52 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a69420a-95c1-bd96-4382-229bcae391b0@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yamada.masahiro@socionext.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®