From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EE2C4167B for ; Tue, 20 Dec 2022 09:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233387AbiLTJV6 (ORCPT ); Tue, 20 Dec 2022 04:21:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233316AbiLTJVy (ORCPT ); Tue, 20 Dec 2022 04:21:54 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B802C2E for ; Tue, 20 Dec 2022 01:21:53 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id a19so11866688ljk.0 for ; Tue, 20 Dec 2022 01:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DazyWikdI/OzsaaGF39wdaaOlC0XReiy+hFbZZu2Q1I=; b=Hjx00EFpYwP45LwbOziknhwz2zKD+sbAMQ86G061nKhGmmw4qE9jTARKz07mPQht/T 1k3StqDnfBGg121+F/oghnfJ9rq45ATS7T/HkmOYgKWBy4gkWf1knqsSRRSXgICSBb64 LOnH0EU+gXHUGouF9PyD26nOG17gg7A6Ree5Xf6VXHvU3FD28v/R/8J3IMmUXbgrPHuZ PwNTg1Ah8mxrVtEKBQ+uyoqNGDocJ5EoyqxLd3xjEQiPYtsUzWa5ZBVVxPSI8FTARB/J UQc7cBaoU0zJ6qX97ehqfCmzi4XGWcNRqqIsqHj3v6iy/p7nocOFGOsMiylkAUKKB76R KD3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DazyWikdI/OzsaaGF39wdaaOlC0XReiy+hFbZZu2Q1I=; b=txGF92VG3poYwhEqXQSoJpzMS7GHUo38KvMQKlSpzt5tbrcCj+JC2emQAsNFJtX1kh OjYqivOgXMa54UyN220k5kCW061MN7GB5V+LEj2f6IaQ4bmv4u/Ljc5JU35fT2fqtqBU TS9QbBNPmE/rqW9ejIq+05WSUrUbnNc1yCUPPhaqpEG+ppkgYXgsUx8+vk50iRM+bXJC 9GDWZL49NYcLy+SMs5Jvavs27SG5DMKT+godMBpwo08tzOnIkxSo3Ne0aJ5tORouAS7P g4A28e9OibOi+18OUENM3G7XP/WbU1NjmZqzInYIkaO+wuSfYQ253Mxm+GM1KBxyKeee cChA== X-Gm-Message-State: ANoB5pnVGNotm7Be94KS0L+uzgDgjlvrkdnPSc3YvJyIWaVvBiOTXvkU MRZxurgHJmQ+wi6MUSun6gNkeQ== X-Google-Smtp-Source: AA0mqf7cINmxUQTVHIA51W+eyOnDgUmlNBK3MC35Vz0emZ06VI2+JlnPdeEHi9nVd6I2/sVZYIoByA== X-Received: by 2002:a2e:3205:0:b0:27b:490b:8478 with SMTP id y5-20020a2e3205000000b0027b490b8478mr10500411ljy.36.1671528111530; Tue, 20 Dec 2022 01:21:51 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s8-20020a05651c048800b00279d73cdf83sm943007ljc.128.2022.12.20.01.21.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 01:21:51 -0800 (PST) Message-ID: <1a696768-45ef-0144-07f3-d356af9659e5@linaro.org> Date: Tue, 20 Dec 2022 10:21:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Content-Language: en-US To: yanhong wang , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20221216070632.11444-1-yanhong.wang@starfivetech.com> <20221216070632.11444-3-yanhong.wang@starfivetech.com> <040b56b1-c65c-34c3-e4a1-5cae4428d1d2@linaro.org> <7f4339df-6616-120f-f16a-cd38a2b6ea1d@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <7f4339df-6616-120f-f16a-cd38a2b6ea1d@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/12/2022 07:48, yanhong wang wrote: >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index e26c3e76ebb7..7870228b4cd3 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -133,12 +133,19 @@ properties: >>> - ptp_ref >>> >>> resets: >>> - maxItems: 1 >>> - description: >>> - MAC Reset signal. >>> + minItems: 1 >>> + maxItems: 3 >>> + additionalItems: true >>> + items: >>> + - description: MAC Reset signal >>> >>> reset-names: >>> - const: stmmaceth >>> + minItems: 1 >>> + maxItems: 3 >>> + additionalItems: true >>> + contains: >>> + enum: >>> + - stmmaceth >> >> No, this is highly unspecific and you know affect all the schemas using >> snps,dwmac.yaml. Both lists must be specific - for your device and for >> others. >> > > I have tried to define the resets in "starfive,jh71x0-dwmac.yaml", but it can not over-write the maxItems limit in "snps,dwmac.yaml",therefore, it will report error "reset-names: ['stmmaceth', 'ahb'] is too long" running "make dt_binding_check". Do you have any suggestions to deal with this situation? The solution is not to affect all schemas with allowing anything as reset. If you need more items for your case, you can change snps,dwmac.yaml and add constraints in allOf:if:then: allowing it only for your compatible. There are plenty of examples how this is done, e.g.: https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57 > >> Best regards, >> Krzysztof >> Best regards, Krzysztof