From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>, Jiri Slaby <jslaby@suse.cz>,
Xiao Liang <xiliang@redhat.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually
Date: Fri, 24 Aug 2018 10:26:05 -0400 [thread overview]
Message-ID: <1a6b2326-78b3-f7fa-fb3b-08c54f4f9761@oracle.com> (raw)
In-Reply-To: <830d73b5-8bbb-4d9a-a004-7aeea0b35067@suse.com>
On 08/24/2018 07:26 AM, Juergen Gross wrote:
> On 24/08/18 13:12, Jiri Slaby wrote:
>> On 07/30/2018, 10:18 AM, Xiao Liang wrote:
>>> On 07/29/2018 11:30 PM, David Miller wrote:
>>>> From: Xiao Liang <xiliang@redhat.com>
>>>> Date: Fri, 27 Jul 2018 17:56:08 +0800
>>>>
>>>>> @@ -1330,6 +1331,11 @@ static struct net_device
>>>>> *xennet_create_dev(struct xenbus_device *dev)
>>>>> netif_carrier_off(netdev);
>>>>> xenbus_switch_state(dev, XenbusStateInitialising);
>>>>> + wait_event(module_load_q,
>>>>> + xenbus_read_driver_state(dev->otherend) !=
>>>>> + XenbusStateClosed &&
>>>>> + xenbus_read_driver_state(dev->otherend) !=
>>>>> + XenbusStateUnknown);
>>>>> return netdev;
>>>>> exit:
>>>> What performs the wakeups that will trigger for this sleep site?
>>> In my understanding, backend leaving closed/unknow state can trigger the
>>> wakeups. I mean to make sure both sides are ready for creating connection.
>> While backporting this to 4.12, I was surprised by the commit the same
>> as Boris and David.
>>
>> So I assume the explanation is that wake_up_all of module_unload_q in
>> netback_changed wakes also all the processes waiting on module_load_q?
>> If so, what makes sure that module_unload_q is queued and the process is
>> the same as for module_load_q?
> How could it? Either the thread is waiting on module_unload_q _or_ on
> module_load_q. It can't wait on two queues at the same time.
>
>> To me, it looks rather error-prone. Unless it is erroneous now, at least
>> for future changes. Wouldn't it make sense to wake up module_load_q
>> along with module_unload_q in netback_changed? Or drop module_load_q
>> completely and use only module_unload_q (i.e. in xennet_create_dev too)?
> To me this looks just wrong. A thread waiting on module_load_q won't be
> woken up again.
>
> I'd drop module_load_q in favor of module_unload_q.
Yes, use single queue, but rename it to something more neutral. module_wq?
-boris
next prev parent reply other threads:[~2018-08-24 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 9:56 Xiao Liang
2018-07-27 18:40 ` Boris Ostrovsky
2018-07-30 7:43 ` [Xen-devel] " Xiao Liang
2018-07-29 15:30 ` David Miller
2018-07-30 8:18 ` [Xen-devel] " Xiao Liang
2018-08-24 11:12 ` Jiri Slaby
2018-08-24 11:26 ` Juergen Gross
2018-08-24 14:26 ` Boris Ostrovsky [this message]
2018-09-07 11:06 ` Jiri Slaby
2018-09-07 11:30 ` Juergen Gross
2018-07-30 16:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a6b2326-78b3-f7fa-fb3b-08c54f4f9761@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiliang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®