From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71119C54EBE for ; Thu, 12 Jan 2023 23:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239485AbjALX74 (ORCPT ); Thu, 12 Jan 2023 18:59:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232888AbjALX7o (ORCPT ); Thu, 12 Jan 2023 18:59:44 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80ED45D8AB for ; Thu, 12 Jan 2023 15:59:39 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id cx21-20020a17090afd9500b00228f2ecc6dbso338550pjb.0 for ; Thu, 12 Jan 2023 15:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=YOxGu9TF0QtV9czLWlRoi8MtO/LfBf5pI1clFeTOj3o=; b=sWx4RBoGeV3nGFYmL0SgAWnfFH7s/pPAka7EdFUbaGzvI+oz9UpEJ/MkQDEtTuwnN9 ED2OZlG8Oc1Y/tAlmxByk1osBkmYbNDZFMdEVgbMyQt++/iBLJ77u1urNxwq5OA8Qe2C ZaPFXwFSFeUAQdG0JVNbeWX1KowNmelNcdauSM80Wz6HXNDh+eHXCIADwF/s4SBEtZsg NB8JEcUHOPgT6O1QpfqYNDcgT2v43qEUqY5N7+Ik5R11fF8nqgZdH87rpoLAmOLaJgVJ Nd/bapu4YRQuYRTFv9grs7qrkxl9l4oxvL0f+tLxHwetZL0cliCw/l+jxF5dUthWAxKr Sc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YOxGu9TF0QtV9czLWlRoi8MtO/LfBf5pI1clFeTOj3o=; b=c8GYA1nwC25tbCc63JHEVowVWFxHpElasaHmvjzmUuXo/z4jHCcWLSDib7WRXdteOc CRhOPmoEb68/uBpUImrN9UzHVQQ9WAzj2s3ssD7RQn0PZ9LDfpqklPFNL5F9zT6zj2Z7 iTtgorTxFFoBmCAJ8PSJJYvtu3m+EFmhX6WGeyYeAq329d6jj+Rt3Ig5NGjEafLpXXhZ LoN+TAKtVthLx7BQbZOyH1K2fw/ja4qthTD/4yVgQZEcgePUNGKu/kQwPHa907iFQwHe kWsKizIiChSplOJcthKZqsBXMnmKxQ7TTAa+tL1O2eNB69vsFbM39SZ8FIMLIA23N+id gydQ== X-Gm-Message-State: AFqh2kprAMVYY0yt6W8xSzEJFSpESk3AWsLuIpTDnonNMmlTOLqjDdC+ 9EYoadkZSO86sNH0pcIRffkgyw== X-Google-Smtp-Source: AMrXdXtscQ7xEgomCamqZcZazKq6mWA71lXLjuymhU8awjVGmi4jnbBHrzR/XzGQnLoGXa4o7sltYw== X-Received: by 2002:a05:6a20:4284:b0:9d:b8e6:d8e5 with SMTP id o4-20020a056a20428400b0009db8e6d8e5mr1410949pzj.2.1673567978825; Thu, 12 Jan 2023 15:59:38 -0800 (PST) Received: from [2620:15c:29:203:1f3b:d48c:199c:9f57] ([2620:15c:29:203:1f3b:d48c:199c:9f57]) by smtp.gmail.com with ESMTPSA id d4-20020a17090a8d8400b001fd6066284dsm11340564pjo.6.2023.01.12.15.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 15:59:38 -0800 (PST) Date: Thu, 12 Jan 2023 15:59:37 -0800 (PST) From: David Rientjes To: Jarkko Sakkinen cc: Brijesh Singh , Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, open list Subject: Re: [PATCH v5] crypto: ccp: Sanitize sev_platform_init() error messages In-Reply-To: <20230110191201.29666-1-jarkko@profian.com> Message-ID: <1a78beb1-bd63-ca70-6b05-bff45de842e5@google.com> References: <20230110191201.29666-1-jarkko@profian.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jan 2023, Jarkko Sakkinen wrote: > The following functions end up calling sev_platform_init() or > __sev_platform_init_locked(): > > * sev_guest_init() > * sev_ioctl_do_pek_csr > * sev_ioctl_do_pdh_export() > * sev_ioctl_do_pek_import() > * sev_ioctl_do_pek_pdh_gen() > * sev_pci_init() > > However, only sev_pci_init() prints out the failed command error code, and > even there, the error message does not specify which SEV command failed. > > Address this by printing out the SEV command errors inside > __sev_platform_init_locked(), and differentiate between DF_FLUSH, INIT and > INIT_EX commands. As a side-effect, @error can be removed from the > parameter list. > > This extra information is particularly useful if firmware loading and/or > initialization is going to be made more robust, e.g. by allowing firmware > loading to be postponed. > > Signed-off-by: Jarkko Sakkinen Acked-by: David Rientjes