From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFBDE189B84 for ; Thu, 10 Apr 2025 07:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744271164; cv=none; b=N8XqpagtcnAIhe8j5vGrLKGiG5GkyGueAip91mFCPGkrmQqZmkt8yCFSi4Y6ndygNsZmZQPzgW+JP1sACgWXgTTx5c/dQChHTnAsXr2b9bT694HMCCxIHJZiXxN6dIhEygGUlwzfLCkd6MPYgNrzlRMpyUnYPKTC2peeiqd9/f0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744271164; c=relaxed/simple; bh=9KkuM3PxR3O/kSEkhfLpDrsgcymd6VI76hN32SdMmuw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gEGAEtNGgm3hNd0M4/znSN1acZp9ML7AhNLQKseVk59CGptWbEP18mXhWlFPxQE2mzQ+45qkA+o3kMOFTxKmwhILutvV7CMJNmcKs48XDcb6uQVmJapDR35nKvW0NvMcIEg9aYmhyaZmgpkVxEGAe+cVGyTMOt6sMwH6KgwIQ14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bif+PO2W; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bif+PO2W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744271160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F58ZWliydz3U6uMmvLSlm0nGnQbwI4yd1xZW1tjL3iY=; b=bif+PO2W6fBh+9Wz1BgJHJJdLYSA0PXm8+sPEhTf4u00av6nMOB10bQ8UD9afgKIdxFhFM P1wLvbSboqJz33ynVRkvwAokGmgvbKcDjx5yKESA+bFOXuOd02JGiBFdluciBRCtfYKUpV yD7Xd1TmW7nZl59IRlR/pXu4tQ58hTQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-gl3OVORbO3iDtlv_t2Huzg-1; Thu, 10 Apr 2025 03:45:56 -0400 X-MC-Unique: gl3OVORbO3iDtlv_t2Huzg-1 X-Mimecast-MFC-AGG-ID: gl3OVORbO3iDtlv_t2Huzg_1744271154 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C48C19541B1; Thu, 10 Apr 2025 07:45:54 +0000 (UTC) Received: from [10.44.33.222] (unknown [10.44.33.222]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1F81019560AD; Thu, 10 Apr 2025 07:45:48 +0000 (UTC) Message-ID: <1a78fc71-fcf6-446e-9ada-c14420f9c5fe@redhat.com> Date: Thu, 10 Apr 2025 09:45:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/14] dt-bindings: dpll: Add support for Microchip Azurite chip family To: Krzysztof Kozlowski Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , Michal Schmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250409144250.206590-1-ivecera@redhat.com> <20250409144250.206590-3-ivecera@redhat.com> <20250410-skylark-of-silent-symmetry-afdec9@shite> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20250410-skylark-of-silent-symmetry-afdec9@shite> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 10. 04. 25 9:06 dop., Krzysztof Kozlowski wrote: > On Wed, Apr 09, 2025 at 04:42:38PM GMT, Ivan Vecera wrote: >> Add DT bindings for Microchip Azurite DPLL chip family. These chips >> provides 2 independent DPLL channels, up to 10 differential or >> single-ended inputs and up to 20 differential or 20 single-ended outputs. >> It can be connected via I2C or SPI busses. >> >> Signed-off-by: Ivan Vecera >> --- >> .../bindings/dpll/microchip,zl3073x-i2c.yaml | 74 ++++++++++++++++++ >> .../bindings/dpll/microchip,zl3073x-spi.yaml | 77 +++++++++++++++++++ > > No, you do not get two files. No such bindings were accepted since some > years. > >> 2 files changed, 151 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml >> create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl3073x-spi.yaml >> >> diff --git a/Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml b/Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml >> new file mode 100644 >> index 0000000000000..d9280988f9eb7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/dpll/microchip,zl3073x-i2c.yaml >> @@ -0,0 +1,74 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/dpll/microchip,zl3073x-i2c.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: I2C-attached Microchip Azurite DPLL device >> + >> +maintainers: >> + - Ivan Vecera >> + >> +description: >> + Microchip Azurite DPLL (ZL3073x) is a family of DPLL devices that >> + provides 2 independent DPLL channels, up to 10 differential or >> + single-ended inputs and up to 20 differential or 20 single-ended outputs. >> + It can be connected via multiple busses, one of them being I2C. >> + >> +properties: >> + compatible: >> + enum: >> + - microchip,zl3073x-i2c > > I already said: you have one compatible, not two. One. Ah, you mean something like: iio/accel/adi,adxl313.yaml Do you? > Also, still wildcard, so still a no. This is not wildcard, Microchip uses this to designate DPLL devices with the same characteristics. But I can use microchip,azurite, is it more appropriate? >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +allOf: >> + - $ref: /schemas/dpll/dpll-device.yaml# >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + dpll@70 { >> + compatible = "microchip,zl3073x-i2c"; >> + reg = <0x70>; >> + #address-cells = <0>; >> + #size-cells = <0>; > > Again, not used. Drop. Sorry, will do. >> + dpll-types = "pps", "eec"; >> + >> + input-pins { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pin@0 { /* REF0P */ >> + reg = <0>; >> + label = "Input 0"; >> + supported-frequencies = /bits/ 64 <1 1000>; >> + type = "ext"; >> + }; >> + }; >> + >> + output-pins { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pin@3 { /* OUT1N */ >> + reg = <3>; >> + esync-control; >> + label = "Output 1"; >> + supported-frequencies = /bits/ 64 <1 10000>; >> + type = "gnss"; >> + }; >> + }; >> + }; >> + }; >> +... >> diff --git a/Documentation/devicetree/bindings/dpll/microchip,zl3073x-spi.yaml b/Documentation/devicetree/bindings/dpll/microchip,zl3073x-spi.yaml >> new file mode 100644 >> index 0000000000000..7bd6e5099e1ce >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/dpll/microchip,zl3073x-spi.yaml > > No, you do not get two files. Neither two compatibles, nor two files. > Please look at existing bindings how they do it for such devices. Thanks Krzysztof for comments. Ivan