From: Bean Huo <huobean@gmail.com>
To: Huan Tang <tanghuan@vivo.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, beanhuo@micron.com,
luhongfei@vivo.com, quic_cang@quicinc.com,
keosung.park@samsung.com, viro@zeniv.linux.org.uk,
quic_mnaresh@quicinc.com, peter.wang@mediatek.com,
manivannan.sadhasivam@linaro.org, quic_nguyenb@quicinc.com,
linux@weissschuh.net, ebiggers@google.com,
minwoo.im@samsung.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v8] ufs: core: Add WB buffer resize support
Date: Wed, 02 Apr 2025 10:51:01 +0200 [thread overview]
Message-ID: <1a7a6e077f3750b0385388187cd52010eef4a085.camel@gmail.com> (raw)
In-Reply-To: <20250402075710.224-1-tanghuan@vivo.com>
On Wed, 2025-04-02 at 15:57 +0800, Huan Tang wrote:
>
> +int ufshcd_wb_set_resize_en(struct ufs_hba *hba, u32 en_mode)
you must ensure the mode en_mode is within valid range (0-2), why not
use enum?
> +{
> + int ret;
> + u8 index;
> +
> + index = ufshcd_wb_get_query_index(hba);
> + ret = ufshcd_query_attr_retry(hba,
> UPIU_QUERY_OPCODE_WRITE_ATTR,
> + QUERY_ATTR_IDN_WB_BUF_RESIZE_EN,
> index, 0, &en_mode);
> + if (ret)
> + dev_err(hba->dev, "%s: Enable WB buf resize operation
> failed %d\n",
> + __func__, ret);
> +
> + return ret;
> +}
next prev parent reply other threads:[~2025-04-02 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 7:57 Huan Tang
2025-04-02 8:43 ` Bean Huo
2025-04-07 8:57 ` Huan Tang
2025-04-02 8:51 ` Bean Huo [this message]
2025-04-07 8:56 ` Huan Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a7a6e077f3750b0385388187cd52010eef4a085.camel@gmail.com \
--to=huobean@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=ebiggers@google.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=luhongfei@vivo.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=minwoo.im@samsung.com \
--cc=opensource.kernel@vivo.com \
--cc=peter.wang@mediatek.com \
--cc=quic_cang@quicinc.com \
--cc=quic_mnaresh@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=tanghuan@vivo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®