From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 345F6C636D4 for ; Mon, 13 Feb 2023 10:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231177AbjBMKWb (ORCPT ); Mon, 13 Feb 2023 05:22:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231152AbjBMKW2 (ORCPT ); Mon, 13 Feb 2023 05:22:28 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDB8D11EBC for ; Mon, 13 Feb 2023 02:22:09 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso10903301wms.0 for ; Mon, 13 Feb 2023 02:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WEaVaR3pJQlndiKqh5ZokTFdMHbHbPbZkEmGATqRZYY=; b=jQO1yGiaeuQ4C3W8uQybW+b/n2PTgQSFhz5hDEOnh6QGJEwij3zLRQZIq92XaTZ4lR ZtusVEY3m0Yu+rLjOyj7Hyok6b5fShTToWgd7VBCkqtvlP7xrtAhx1fiSSt81/MGEFL4 YVW68r+lZRjHJbTu/4A9orIqCaUb1+xmNwUp2JdhWSH1sL9BbpvtyXz+wG3PTqNrVdtF j+vPYrf5shPohAqRUQlnxGEotzOLcSEp8LnTUufVDD3QummwVZkC4gK9d/Iw9MMModsC G/tGx+u//h0OvQSJB0O3VIrgwIXoTbe/ruD8gyOslaE87W+CfpZVQG4xJlKQZXqlMC7f sCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WEaVaR3pJQlndiKqh5ZokTFdMHbHbPbZkEmGATqRZYY=; b=pWOWxpY074Z+xo4n1F4/0ZLKtbYrD7WuIkNoEu5axSb54XiCc2mMop7P2o/r77OIWo IOMyNw0ClDYpv8pC7MMP7TKQLSxyAmNnutMQf0ncJknGa6UcOg7rhBSiZa7eFfzBEAJo Qr2d6yZ6SBTZ8++ZMExjEX3zibwIsK1lFtHlkbPqVOdt3B0xC4qPNrD1/PBiHu0B1uDP c8uZNbpnOoBrKrq4+yvFdcxGnOnh5iNEWiTnGcLEhgjNWspCp1OmDVR6YF4Gp1jNWkI3 9Mct9EridER0CMrGoXAzfm8EzG8FZnOLKJpZHDMgeO6AQu7syHBRLKkeOxzvq9w3PnlD MdRQ== X-Gm-Message-State: AO0yUKUOM/s8JAQDtGDRoBIRcUKwiZwUHRvpGJ7yg/KCbYOGxrdN/h29 mtNFszcbLfSnnplS0sU9FR3cKg== X-Google-Smtp-Source: AK7set/YSkJ3lo4sL7+jsNhbWDUo6sMqoN013q7KyFE3YepQ1+9B5t71dyticVVQrB6VvW0cNKPI7w== X-Received: by 2002:a05:600c:43c7:b0:3dc:5d34:dbe5 with SMTP id f7-20020a05600c43c700b003dc5d34dbe5mr18684412wmn.28.1676283728277; Mon, 13 Feb 2023 02:22:08 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id be7-20020a05600c1e8700b003dff2b493c8sm17983147wmb.36.2023.02.13.02.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 02:22:07 -0800 (PST) Message-ID: <1a8268a1-e656-10b2-8ca5-495867e521e7@linaro.org> Date: Mon, 13 Feb 2023 11:22:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode Content-Language: en-US To: Maarten Zanders , Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Jacek Anaszewski Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230213102027.29961-1-maarten.zanders@mind.be> <20230213102027.29961-2-maarten.zanders@mind.be> From: Krzysztof Kozlowski In-Reply-To: <20230213102027.29961-2-maarten.zanders@mind.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/02/2023 11:20, Maarten Zanders wrote: > Add a binding to configure the internal charge pump for lp55xx. > > Signed-off-by: Maarten Zanders > --- > > Notes: > v1: implement as bool to disable charge pump > v2: rewrite to use string configuration, supporting all modes > v3: simplification by replacing string option by u8 constant, > removing previous Reviewed-by tags as it's a complete > rewrite of the patch. > v4: added notes > v5: dual license, change property type to u32 Thank you for your patch. There is something to discuss/improve. > diff --git a/include/dt-bindings/leds/leds-lp55xx.h b/include/dt-bindings/leds/leds-lp55xx.h > new file mode 100644 > index 000000000000..e2256312714b > --- /dev/null > +++ b/include/dt-bindings/leds/leds-lp55xx.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ While technically it is almost equal to BSD-2, any particular reason for using different second license than the binding and generic recommendation (checkpatch)? Best regards, Krzysztof