From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AC335CB71 for ; Fri, 6 Feb 2026 09:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770369695; cv=none; b=h9qTgr5apReOAMMEA0KuAVzZkcEiTJ8c0zmX+bNcXwIXjZnamW/H+QJ2hqbzYXPshlCmFxQ3ZQzJMCrc7+OJFJuJdE+vMU4YByyxoLEDMy6gFmB4Cr9Ig1NOoXfvxSWyIENqgPX8qtFWCUlsGKEuqHJCQTjFs+bn4pnFLPFgW0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770369695; c=relaxed/simple; bh=mPK2MiKQ3X13y09TPJIpWKe2qfh7owIvcDLRW37DMCo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k3a1PPxeK4eFSruz7opw1agX+xXgtfiPyNbVxGWGjh5FPK51cgeMlJ74w1XHXpDhfAmlhAqrPkzl7lIMnOEQdkNKqb+Lun8p2w0xSNfp4Tx+YGA3j0JuAA2SG4EBkdWDWXHOu8XV/o8pBXTB7sDLIL9X7kbGkNrkdTGFh3wTyno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VvvPTTt/; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VvvPTTt/" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-81e8b1bdf0cso1559370b3a.3 for ; Fri, 06 Feb 2026 01:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770369695; x=1770974495; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DHcOD9pDSPOBKmWPMOHD8g7QnZvvQliE20szaOYrjF8=; b=VvvPTTt/H+i3fpdLtN1w0fbMQFruVxkhcFClfTnVb0aJRpW6hGcMM6C7UgnLeiJjRv x9U5dQ6cNnzSLrGN6WW5S5JhszjS6HluYhZpOesk7IXNG0SO82JDFJrRppwJN2TuXzLn dztN5WFkL/RMMRdJhhzIt6XJoyK2iSiK/G6wHS/TB7Ew0O7NHRTVbitkYJdPcErsJVHh cZ2d6u5LLwmXRimqEJwuH79mzAj428BvGkb0LaofcxncWLNawynPWh6XE+AdlOpf1csP Bb5LqDES0OpeiKVYLz+QYcDPlkZutzHQjx9UXhYtPk8IQYz8/MsJVNLW2mMUI1Mty0FG 8TsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770369695; x=1770974495; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DHcOD9pDSPOBKmWPMOHD8g7QnZvvQliE20szaOYrjF8=; b=n7XaLy3CbKeUu2Mf024qiLhHdSfiyQFVWmgooRPiNpaM7YZ9Q8Ql0sp42KFozNGf6p IugCkmkmN+Cv2/r1XRDI/Yy8+rbF9x26E2/4JUfMPaeownRV7pWN2rb0hjQn4hLEmRJ6 VZPdTYDF5JFt8uKVvusXOPa5eiaWRy+LPc83Ubm1eUuTMLHJ7YMRF2kgcftqZGeZUox8 xtawAes9fcq2Uic64vPO54eKsZJSYxTBGnAPxtsxRLbVm2mSvANEBiIy8AMsJUlG/RRc x9jSe0jX0e2MvOaStZp6htxnxV7IVp+CByp4B2TJiNizP70xH6arZiFxa4JmbLAVii8A Pb/g== X-Forwarded-Encrypted: i=1; AJvYcCUipLTjah449dWRghYQFPPaG5h/rvNlu8OaYHteEJKlnGckobxkDJV3yoMLgYW0KZoeRMsFAZ28/sXarP0=@vger.kernel.org X-Gm-Message-State: AOJu0YzVDmUn7N+mkyNTdEsOGE4gjaiPYpjWXt1UhJeDkQxX2laJ3lmX hXaWmOz3yrTXv54xy3/wmhSGmCZG/iefrDXJ1WUIYzZyRo8SHOGiksYN X-Gm-Gg: AZuq6aIym6+X31m/gNuJ0PI/XUd+VWpKJ8V62Xq0MwevS0QadT90sGYQYITz/Nwr48o iSjD4giSLLAeiWVCDzWa3QnBMGPl2PJ3Ibp4y+iRC0CpMtq6Y5Rh5HBTN0amgyw1glwIeWCCgGf /6ieLQjMI/QfpAY05M/W+HqS3w0eKjXH3stDqffPsqQYf3QKmlaQMsUx+atyVsFke8njfRbcSzo JRve2Uo79Gerz/UsCj5x8P5WtGp3PhNd9QfhMM9xFrKN5ZDaOjI7WAcv2AD/nRrOAS8FLUZMiJq EQ7Ng7kR+VXuATkGlzPu0G6XRcO42wfOtgmqk1WqzPXPRb6p/Kg2wxymhUicD8M6hEKwLjsseRb 5B6FjRIRWG6u+oWrcBgJZJEDKMHkB2flrKST+Z5KQjVZn4wjqDFA35lMYpqrKeIOhVbS/a2PRcV Mx5Q0TRTGj9PpbhaQpIKQjRE0NgqgQEYEHJi3cwt8U0pLzJmBYBNGF+AXozyyXq/be X-Received: by 2002:a05:6a00:158e:b0:81f:4c37:7647 with SMTP id d2e1a72fcca58-824417a9046mr1511837b3a.68.1770369694600; Fri, 06 Feb 2026 01:21:34 -0800 (PST) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824416cb967sm1632051b3a.30.2026.02.06.01.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 01:21:34 -0800 (PST) Message-ID: <1a82e38f-2009-47b0-bfb5-c2624bb06719@gmail.com> Date: Fri, 6 Feb 2026 17:21:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] arm64: dts: nuvoton: ma35d1: add display controller support To: Krzysztof Kozlowski Cc: airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260129040532.382693-1-a0987203069@gmail.com> <20260129040532.382693-3-a0987203069@gmail.com> <20260205-tactful-warm-chicken-50bdc8@quoll> <7c29f46c-aa27-4569-9170-53538785e029@kernel.org> Content-Language: en-US From: Joey Lu In-Reply-To: <7c29f46c-aa27-4569-9170-53538785e029@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/6/2026 4:56 PM, Krzysztof Kozlowski wrote: > On 06/02/2026 08:12, Joey Lu wrote: >> On 2/5/2026 9:23 PM, Krzysztof Kozlowski wrote: >>> On Thu, Jan 29, 2026 at 12:05:31PM +0800, Joey Lu wrote: >>>> &uart0 { >>>> @@ -129,3 +165,23 @@ &uart16 { >>>> pinctrl-0 = <&pinctrl_uart16>; >>>> status = "okay"; >>>> }; >>>> + >>>> +&panel { >>>> + port { >>>> + panel_in: endpoint@0 { >>>> + remote-endpoint = <&dpi_out>; >>>> + }; >>>> + }; >>>> +}; >>>> + >>>> +&display { >>> What sort of ordering rule is followed in Nuvoton? Why is it different >>> than DTS coding style? Why do you choose other style? >>> >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = <&pinctrl_display>; >>>> + status = "okay"; >>>> + >>>> + port { >>>> + dpi_out: endpoint@0 { >>>> + remote-endpoint = <&panel_in>; >>>> + }; >>>> + }; >>>> +}; >>>> diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi >>>> index e51b98f5bdce..7d9d077f12b2 100644 >>>> --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi >>>> +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi >>>> @@ -379,5 +379,19 @@ uart16: serial@40880000 { >>>> clocks = <&clk UART16_GATE>; >>>> status = "disabled"; >>>> }; >>>> + >>>> + panel: panel { >>> No, there is no way your SoC has a panel. >>> >>> Don't add fake stuff to your DTS. >>> >>> Best regards, >>> Krzysztof >> I'll move panel nodes out of dtsi into board dts. > You did not respond to several comments in total, it's fine, but if you > just ignored them, then it would not be fine. > > > Best regards, > Krzysztof Thanks for the review. I've gone through all comments carefully. Some points were addressed directly in the next revision,so I grouped a few replies together since the original code will no longer appear after the update. I will also restructure the DTS so the panel is defined under the root node to follow the standard hierarchy and ordering conventions. For remaining items that need discussion, I'll reply inline one by one. Joey