From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: dev@pschenker.ch, devicetree@vger.kernel.org,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 17/25] arm64: dts: colibri-imx8x: eval: Add spi-to-can
Date: Wed, 8 Mar 2023 15:34:46 +0100 [thread overview]
Message-ID: <1a837bec-8658-3200-edff-76809de3fae6@linaro.org> (raw)
In-Reply-To: <3730a506119804b5740854c74d1558010ce37b47.camel@pschenker.ch>
On 08/03/2023 14:43, Philippe Schenker wrote:
>>> + mcp2515: can@0 {
>>> + compatible = "microchip,mcp2515";
>>> + reg = <0>;
>>> + interrupt-parent = <&lsio_gpio3>;
>>> + interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
>>> + pinctrl-0 = <&pinctrl_can_int>;
>>> + pinctrl-names = "default";
>>> + clocks = <&clk16m>;
>>
>> You just sorted all nodes in previous patches and add something
>> unsorted? What is then the style of order? Random name?
>
> My logic behind this one is
>
> 1. compatible property
> 2. reg property
> 3. standard properties
> - first interrupt
> - then pinctrl
> 4. specific properties
> - again alphabetically: clocks, spi-max-frequency
clocks and spi-max-frequency are standard properties.
BTW, what is a specific property?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 14:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 12:52 [PATCH v1 00/25] Update Colibri iMX8X Devicetrees Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 01/25] arm64: dts: colibri-imx8x: Prepare for qxp and dx variants Philippe Schenker
2023-03-08 14:33 ` Krzysztof Kozlowski
2023-03-08 15:21 ` Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 02/25] arm64: dts: colibri-imx8x: Update spdx license Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 03/25] arm64: dts: colibri-imx8x: Sort properties Philippe Schenker
2023-03-08 12:57 ` Krzysztof Kozlowski
2023-03-08 13:29 ` Philippe Schenker
2023-03-08 14:32 ` Krzysztof Kozlowski
2023-03-08 14:50 ` Philippe Schenker
2023-03-08 16:09 ` Krzysztof Kozlowski
2023-03-09 12:19 ` Francesco Dolcini
2023-03-14 8:17 ` Shawn Guo
2023-03-14 8:25 ` Francesco Dolcini
2023-03-08 12:52 ` [PATCH v1 04/25] arm64: dts: colibri-imx8x: Use new bracket format Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 05/25] arm64: dts: colibri-imx8x: Add atmel pinctrl groups Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 06/25] arm64: dts: colibri-imx8x: Add pinctrl group for csi_mclk Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 07/25] arm64: dts: colibri-imx8x: Split pinctrl_hog1 Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 08/25] arm64: dts: colibri-imx8x: Correct pull on lcdif Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 09/25] arm64: dts: colibri-imx8x: Add separate pinctrl group for cs2 Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 10/25] arm64: dts: colibri-imx8x: Add pinctrl group for hdmi hpd Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 11/25] arm64: dts: colibri-imx8x: Sort fec1 node alphabetically Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 12/25] arm64: dts: colibri-imx8x: Add SPI Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 13/25] arm64: dts: colibri-imx8x: Add gpio-line-names Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 14/25] arm64: dts: colibri-imx8x: Disable touchscreen by default Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 15/25] arm64: dts: colibri-imx8x: Add jpegenc/dec Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 16/25] arm64: dts: colibri-imx8x: Add colibri pwm b, c, d Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 17/25] arm64: dts: colibri-imx8x: eval: Add spi-to-can Philippe Schenker
2023-03-08 13:00 ` Krzysztof Kozlowski
2023-03-08 13:43 ` Philippe Schenker
2023-03-08 14:34 ` Krzysztof Kozlowski [this message]
2023-03-08 14:46 ` Philippe Schenker
2023-03-08 14:12 ` Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 18/25] arm64: dts: colibri-imx8x: Add no-1-8-v to sd-card Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 19/25] arm64: dts: colibri-imx8x: Set thermal thresholds Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 20/25] arm64: dts: colibri-imx8x: Move gpio-keys to som level Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 21/25] arm64: dts: colibri-imx8x: Add todo comments Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 22/25] dt-bindings: arm: fsl: Add colibri-imx8x carrier boards Philippe Schenker
2023-03-08 13:04 ` Krzysztof Kozlowski
2023-03-08 12:52 ` [PATCH v1 23/25] arm64: dts: colibri-imx8x: Add aster carrier board Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 24/25] arm64: dts: colibri-imx8x: Add iris " Philippe Schenker
2023-03-08 12:52 ` [PATCH v1 25/25] arm64: dts: colibri-imx8x: Add iris v2 " Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a837bec-8658-3200-edff-76809de3fae6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=dev@pschenker.ch \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frowand.list@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®