From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C89BC2D0A3 for ; Sun, 1 Nov 2020 23:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE0B720678 for ; Sun, 1 Nov 2020 23:34:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q8B3+lhA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727482AbgKAXeP (ORCPT ); Sun, 1 Nov 2020 18:34:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbgKAXeP (ORCPT ); Sun, 1 Nov 2020 18:34:15 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02269C0617A6; Sun, 1 Nov 2020 15:34:15 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id a9so12495087wrg.12; Sun, 01 Nov 2020 15:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nB17pwnP57+tQkhNWeBukL2LccU7GhHBJWPWrm23bd8=; b=Q8B3+lhAFq8lPty1RxuU9aYRmf1hAmGt4bliiJFz+86Ubmn93MgaUB/vznfzZaQsqn gJMPUnDGzjcGRtWJhn+TIabl51oYJgBR/uelQsuWh3DT0t9HOQKuF9c3niRjoSoSduZM RbQ934G+x8PUx7JP7vQ/qL2XcZz8ijFR1z4MXkriEn77GzkpU+wlABxryOPC+q1EJnVQ W6uOQb2EVx5P9UydE02hPBpgT5mruz+KRgOCsH6LsvjNbNKr6dA+HpSh6Xpv1EhVwufY smvarHS5G8v9+Lhs+cDuMLICOCGcx2SOskmSrWZGF035n5v8U6MUEqDJUkclf1XcYzXq vPZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nB17pwnP57+tQkhNWeBukL2LccU7GhHBJWPWrm23bd8=; b=dAPUzgPVP0nYKx29Ge6+9zwQ6LeVfNCzTmJ1Uuun22os8IRdeFr09q6fMjyll8rJAo 9BrD3pYROMgFDynD3rPO61PM63M5BMlJnxRQdg+GirHRaDc9cv6Sb16BDVKnTl5nOMbq OkuohU/bpsZnJ6qzRvyRXn1UPdWkfIUVz6PK4GloELgObZrvbCr5UW85pAXxNP5DQJOp bD0DUZS0H5Ekr4Wj4QHs75YBZFGG+BM/avosRU54zQZrlu519xGfddnQ9k43IirCXD0N 0pqHiUzEko7MCcMP7YJ7gx0vhayFVNB+CIRjHtKf7k6/DcJ3x4z8OU3acM8YKM5VzBg0 gb8g== X-Gm-Message-State: AOAM533A8UhSzXVI2gB7o1BHElO03+AMsFXYOI/bQr0f33I9e0GSUQYK 3roRk+RDyvN/im+8g9NTi8g= X-Google-Smtp-Source: ABdhPJyCWs7cgF14HN/r+6VxCNSItinGyqgNmvq8VSl3sUK1kGJtanF0dqMXUF58AwX7bcXEcnM9TQ== X-Received: by 2002:a5d:6cc9:: with SMTP id c9mr18057648wrc.276.1604273653756; Sun, 01 Nov 2020 15:34:13 -0800 (PST) Received: from ?IPv6:2a02:8084:e84:2480:228:f8ff:fe6f:83a8? ([2a02:8084:e84:2480:228:f8ff:fe6f:83a8]) by smtp.gmail.com with ESMTPSA id v67sm13380559wma.17.2020.11.01.15.34.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Nov 2020 15:34:13 -0800 (PST) Subject: Re: [PATCH] xfrm/compat: Remove use of kmalloc_track_caller To: Alistair Delva Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski , "David S . Miller" , Herbert Xu , kernel-team@android.com, =?UTF-8?Q?Maciej_=c5=bbenczykowski?= , Steffen Klassert References: <20201101220845.2391858-1-adelva@google.com> From: Dmitry Safonov <0x7f454c46@gmail.com> Message-ID: <1a85a545-a663-828a-387e-fd4a0e2ae747@gmail.com> Date: Sun, 1 Nov 2020 23:34:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201101220845.2391858-1-adelva@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/20 10:08 PM, Alistair Delva wrote: > The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are > enabled instead of SLAB, which breaks the build on such configs when > CONFIG_XFRM_USER_COMPAT=m. > > ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined! > > Other users of this symbol are 'bool' options, but changing this to > bool would require XFRM_USER to be built in as well, which doesn't > seem worth it. Go back to kmalloc(). > > Fixes: 96392ee5a13b9 ("xfrm/compat: Translate 32-bit user_policy from sockptr") > Cc: Dmitry Safonov <0x7f454c46@gmail.com> > Cc: Maciej Żenczykowski > Cc: Steffen Klassert > Signed-off-by: Alistair Delva Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com> Thank you! -- Dmitry