From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2819531-1514766246-2-4780703525794695699 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-charsets: plain='utf-8' X-Resolved-to: linux@kroah.com X-Delivered-to: linux@kroah.com X-Mail-from: linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1514766246; b=hZgr7aRL05evgu8k/kIWmPUfK7ZR7VN2CRl2woqDEwuiixA 2vVQY9qXPfSxE4fA0sMIyGssoBEM01Yl7av5DRlmmqtaBSAWMd86ASEBwsCAu+vS AJUetEheYACbGT+pQyNTNSP7zj30oOCZkgcTg07eAivnEJiYBuv46uHJZdfGGPrR 4N9GKyag64mTYmvz8DKwrUFbAqtxxEwpTfDv1vLbxN70eCNSZk4aP5jRqtS3L/YN m60ea6bSjBe0IHRVGI8PJ26BqW97Z90W8TMawSgyXa44a0cR9V6OR4b7nrVOoCjv 4Uxfhh3LGFsVKsI3FgM5gDLXuwuUtPm3lUVOaXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1514766246; bh=b/AWj8xj5s+npeWkUyIo4+fkxyEWHfRUtLdiEleSQgo=; b=F m3x0PahwvvaqT7p+3RAe2GeCrePE7FWTIRjmgcQV6Gwf8VQnjdyKV7xBlCRijgXK DjNYYjYVCL1dbDUkL20iwXWN/rAJH23i415ridRq09BFpTgrN+I6oTuTj2Uie1Iw q6vnG9Ex+8lcd6NQ9wll8A4XnjmS2lUJgXnUnB4NqfZGvsyDZrgl14uXzwBbcSye rORNLp8n5Npy+F7+OHQECrekksurEdg3r+94XsrgaK4ZupblA7gBqo5vqkhzzDJ5 3P9N4R2/ivvJ2OQWbjv9vP6oRy6c1k0CeAUNYLT3GLOGHxeGMj8fFStBG1PVvI3X EFWh4WprfdIFPJoyWZMkA== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=lechnology.com header.i=@lechnology.com header.b=a3ElzF51 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=default; dmarc=none (p=none,has-list-id=yes,d=none) header.from=lechnology.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lechnology.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=lechnology.com header.i=@lechnology.com header.b=a3ElzF51 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=default; dmarc=none (p=none,has-list-id=yes,d=none) header.from=lechnology.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lechnology.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbeAAAX5 (ORCPT ); Sun, 31 Dec 2017 19:23:57 -0500 Received: from vern.gendns.com ([206.190.152.46]:56494 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbeAAAX4 (ORCPT ); Sun, 31 Dec 2017 19:23:56 -0500 Subject: Re: [PATCH v4 5/7] clk: Introduce davinci clocks To: linux-arm-kernel@lists.infradead.org Cc: Sekhar Nori , Kevin Hilman , Adam Ford , linux-kernel@vger.kernel.org References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-6-git-send-email-david@lechnology.com> From: David Lechner Message-ID: <1a85abb2-e4c3-a80a-915d-09269617e90e@lechnology.com> Date: Sun, 31 Dec 2017 18:23:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1514763588-31560-6-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX On 12/31/2017 05:39 PM, David Lechner wrote: > This introduces new drivers for arch/arm/mach-davinci. The code is based > on the clock drivers from there and adapted to use the common clock > framework. > > Signed-off-by: David Lechner > --- ... > diff --git a/drivers/clk/davinci/da8xx-cfgchip-clk.c b/drivers/clk/davinci/da8xx-cfgchip-clk.c > new file mode 100644 > index 0000000..780bb25 > --- /dev/null > +++ b/drivers/clk/davinci/da8xx-cfgchip-clk.c > @@ -0,0 +1,380 @@ ... > +static int da8xx_cfgchip_clk_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct da8xx_cfgchip_clk_data *pdata = dev->platform_data; > + struct da8xx_cfgchip_clk *phy_clk; > + const char *parent_name; > + struct clk *parent; > + int ret; > + > + if (!pdata) > + return -EINVAL; > + > + phy_clk = devm_kzalloc(dev, sizeof(*phy_clk), GFP_KERNEL); > + if (!phy_clk) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, phy_clk); > + > + phy_clk->regmap = syscon_regmap_lookup_by_pdevname("syscon"); There is a mistake here. Device tree boards will fail to find "syscon". It should be: /* try device tree, then fall back to platform device */ phy_clk->regmap = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip"); if (IS_ERR(phy_clk->regmap)) phy_clk->regmap = syscon_regmap_lookup_by_pdevname("syscon"); > + if (IS_ERR(phy_clk->regmap)) { > + dev_err(dev, "Failed to get syscon\n"); > + return PTR_ERR(phy_clk->regmap); > + }