From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E7FCC433F5 for ; Fri, 3 Dec 2021 13:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380980AbhLCNF6 (ORCPT ); Fri, 3 Dec 2021 08:05:58 -0500 Received: from so254-9.mailgun.net ([198.61.254.9]:34121 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239885AbhLCNF5 (ORCPT ); Fri, 3 Dec 2021 08:05:57 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1638536553; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=S0boIMq9CsUZ+THAcamuP4gAY6wx2Qx7eFqNdDb2HYs=; b=gY6eEB8AWQjO59qXNYENcxrr5BUy2usMd/DYUvI3X8KqYt9/758TP8orPaKJ6EeBhrg2u2Pj gCcl+14PGzq1gnqU6EvtWu/4tXsNOhThJ+9uHqsWd+LMVzBHx2KQXgsvNGBnIc6PwhkFpkHE R22imDnSXrswvPfgFbirvHFljyQ= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-east-1.postgun.com with SMTP id 61aa15687d878c8ded86aecd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 03 Dec 2021 13:02:32 GMT Sender: charante=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D1B68C43616; Fri, 3 Dec 2021 13:02:31 +0000 (UTC) Received: from [192.168.29.110] (unknown [49.37.157.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id 04359C4338F; Fri, 3 Dec 2021 13:02:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 04359C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH v2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem To: Matthew Wilcox , Charan Teja Reddy Cc: hughd@google.com, akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com, david@redhat.com, mhocko@suse.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1638442253-1591-1-git-send-email-quic_charante@quicinc.com> From: Charan Teja Kalla Message-ID: <1a88ed3f-ad7d-9d06-108e-e00f06b0ed19@codeaurora.org> Date: Fri, 3 Dec 2021 18:32:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/2/2021 8:29 PM, Matthew Wilcox wrote: >> + list_add(&page->lru, list); >> + inc_node_page_state(page, NR_ISOLATED_ANON + >> + page_is_file_lru(page)); > ... what if the page is a THP? Will take care of THP pages in the next spin. Thanks for pointing it out. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project