From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E1D45DF63 for ; Mon, 12 Oct 2026 09:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791797164; cv=none; b=mEggpdSH2Xz0wRC+25NsS9Ytam7pRC8z2A5pSbDNLz1qbL3SIYZ1uqCLugqLejhZV1e0ehSV9dhoWJTe1WCltQJaTRWyBacIVgXz54asN1JwSDRXPsUmoaFInwsdieiiwvnLCVDg5lPiLtfEQO4ywdBUGEOW3lpZrS5XTKvNrNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791797164; c=relaxed/simple; bh=wIo0/c7IRe3Ts5XyPas26K04sTrkN5tIqRH6aK/PMjw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=VHJZmOzwp9YwkAm77Co+gN6HIQAwt/hbfr6d7480fW6j2NSDzAbP/rSxalrsKVo9ZJ/9kzZY8KeWlDpvZeZfDFs/1MNUcmhdpubRdzP46z1gglJBmj4KPVkJZpAdc2pYs4RyN4WfbaxJMiWvIMirKs84Eg8zURLHsEI2KGvCpvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s8kqKxVe; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s8kqKxVe" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a16c399641so17072015e9.2 for ; Mon, 12 Oct 2026 02:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1791797161; x=1792401961; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Gk95jI3lhRqF+q2Y0sX+t13akZvJa78d7yUGx/ACAu4=; b=s8kqKxVedozSXDPeRENYMMQcfiev1+AkX1MVhEt+KgIjDyin/CNPjG262sxY7Bexcn zpJsNghsFVebahdHRaw7AKi/hPDbJdaiMcPNkvIMukZIxCpgij05PvXAhPFAniyGXn3r 3bEL9Yyvv1BNqxjP6zeVALppbuERSqjcvTCOPuQ56L7iwee8OYR7GTJ72tNpw4aBsPse JTbaVMfOceALb2tmeh2DDG8eT67bYifznG6lWvBZ2T517C5fPYcaDV3ogdrSaXKvVlAl A2j+iIrqY9SEfxHopYmg5VZW9kOGIguh5HzOnabnpe5M484sq5PaC20cX2UQWxz55kH0 cZ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791797161; x=1792401961; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=Gk95jI3lhRqF+q2Y0sX+t13akZvJa78d7yUGx/ACAu4=; b=K1HJ1pC/6DXj66KguR8+QhDGif8Wuum5k7H+Bq8iEOvE0ulJefKpGFpY58XOjQGcR+ uOWk/6nTmrnMx0BuDsemW23AoW7qULhTLnsFKGghqfe0nBh52F4OkxFKFO668y7JE1iF onQsb6YvJoj5lcI4PiOQxBwMfwMQPaNOV9BMB9Pbu2vVkmAFUgEnkKf/Xc8+M4VyOJPK dK/svSymhPqgpBOBCiv3JXmN9wRBYSb7DHC2xf3pPxf8fVta19iHpmX1KByNsZNXPh+m 3BONIcwUDcMtseTdIFxMdhf/FQtTE3gzF8lFK7SXVPOg9rHqdy8Gr6oYI6qrlOCPpPxu l4gw== X-Forwarded-Encrypted: i=1; AKwUvBzFnhLwZ/w8h0ur35HqkWLdTkZhMuTTjandbNz3Dh8NGTMF4TFCjo3+OAvpBDg+inBLUU19vGXw+YzMbEU=@vger.kernel.org X-Gm-Message-State: AFq9FYIdCwPnh94SIavylP2SqYqFAnbKkafEbMevP2NNJdCmuMhK+Uq+ 9FXcsXDquGwe5ifyNiKp+jr6KmoQh/2di8ONyRElnlP2YKMnB9Z/Ll/sr8RJkvxr4cFM8UdiPhZ w9vw8GOU= X-Gm-Gg: AYBFou3pE8RgX7OXGZh5b1f4VDch5h2tD66Yn6CW/jMuuDoQu4oPpbdNnigFfbvv6h6 4QVq0TpuE5Mv5ED7sY2tdBWWNN1YDuseeS+C7iA2zOaN0in/sW8CzvQ5+jZxctTW/RE+e5gdDUl X6uXuXxb1j9FRr5r9f6O4pqUfK8iH5ORpIAM7rg2usi9w3TqsE2/mj7PFwD9pfsHiObKCEZvf9d Rovj5Ukkxl6BzrxYZCsa0j6o0z+TTtpqNWEhNFZwyXCKaB2s1RFHz/DqidukgNQXy1NcqbJUk8v vMOdEe+z41IF7SuV9BghKOtYj7pqA1Jwq3dU/ce1THULrBN5wM5C4v4pUIqNRhwL82ZZdaf11zC rLxAAvjBIPaglZxklOd1uCDnW9jJvuMOdAXxNKLTh485qY5VNjaQCcDrphWLGI31yabjRYjlNZx 6oE8n719AWO0Z0kgqLg8t6smJMzyp5+aQYKw6deKTimJ2oYHSzZifQgt5aej8MytpV2zlA4pGrA bPl1JpFlGwPoUx+zU00Gg7C5SRyl4XH00P5N2+cxOurLK2Eg2w= X-Received: by 2002:a05:600c:8b28:b0:49f:bd3c:bc1b with SMTP id 5b1f17b1804b1-4a18e499da4mr171146595e9.22.1791797160966; Mon, 12 Oct 2026 02:26:00 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:417e:f4c4:5b8:8c48? ([2a01:e0a:106d:1080:417e:f4c4:5b8:8c48]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db9ac6a91sm16729294f8f.41.2026.10.12.02.26.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2026 02:26:00 -0700 (PDT) Message-ID: <1a940a0c-0a90-4b8d-831f-300c2cf02ae0@linaro.org> Date: Mon, 12 Oct 2026 11:25:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] arm64: dts: meson-gxbb-odroidc2: read the Ethernet MAC address from eFuse To: filipp.dunsky@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261011-odroidc2-dts-v2-0-a3a4a752f2ab@gmail.com> <20261011-odroidc2-dts-v2-1-a3a4a752f2ab@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20261011-odroidc2-dts-v2-1-a3a4a752f2ab@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/11/26 20:31, Fil Dunsky via B4 Relay wrote: > From: Fil Dunsky > > The vendor programs a unique factory MAC address into the SoC eFuse at > offset 0x34, where meson-gx.dtsi already describes the eth_mac nvmem > cell. Reference the cell from the Ethernet controller so the kernel > picks up the factory address itself instead of depending on the > bootloader to populate local-mac-address, or falling back to a random > one when it does not. > > The cell is 16 bytes long in meson-gx.dtsi, while > of_get_mac_address_nvmem() only accepts a cell of exactly ETH_ALEN > bytes, so narrow it to the 6 bytes of the address for this board. > > Tested on an ODROID-C2 with the bootloader's MAC fixup out of the way > (ethernet0 alias removed from the DTB): with the 16-byte cell the > driver falls back to a random address, with the 6-byte cell eth0 comes > up with the factory address from the eFuse. > > Signed-off-by: Fil Dunsky > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index 5943bc810..3b74528ef 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -223,6 +223,10 @@ &cec_AO { > hdmi-phandle = <&hdmi_tx>; > }; > > +ð_mac { > + reg = <0x34 0x6>; > +}; > + > ðmac { > status = "okay"; > pinctrl-0 = <ð_rgmii_pins>; > @@ -230,6 +234,9 @@ ðmac { > phy-handle = <ð_phy0>; > phy-mode = "rgmii"; > > + nvmem-cells = <ð_mac>; > + nvmem-cell-names = "mac-address"; > + > amlogic,tx-delay-ns = <2>; > > mdio { > Reviewed-by: Neil Armstrong Thanks, Neil