From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests
Date: Wed, 23 Nov 2022 10:37:24 +0100 [thread overview]
Message-ID: <1a9a16d9-221e-6fa4-0ace-fd6e8afaaa4a@suse.com> (raw)
In-Reply-To: <20221122163810.29752-4-jgross@suse.com>
On 22.11.2022 17:38, Juergen Gross wrote:
> @@ -137,12 +138,28 @@ static void __init xen_pv_init_platform(void)
> xen_init_time_ops();
> }
>
> +static struct real_mode_header xen_rm_header;
> +
> +static __initdata struct trampoline_ref xen_dummy_trampoline = {
> + .blob = (unsigned char *)&xen_rm_header,
> + .blob_end = (unsigned char *)&xen_rm_header,
With both pointing to the start of the struct, doesn't it suffice
for the above to be xen_rm_header[0]? At which point there'd be no
reason to wonder whether that struct could live in .init.data ...
Jan
prev parent reply other threads:[~2022-11-23 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 16:38 [PATCH v2 0/3] x86/realmode: use " Juergen Gross
2022-11-22 16:38 ` [PATCH v2 1/3] x86/realmode: test real_mode_header outside of real_mode_size_needed() Juergen Gross
2022-11-22 16:38 ` [PATCH v2 2/3] x86/realmode: add trampoline reference structure Juergen Gross
2022-11-22 16:38 ` [PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests Juergen Gross
2022-11-23 9:37 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a9a16d9-221e-6fa4-0ace-fd6e8afaaa4a@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®