From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933323AbdKPBYQ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 20:24:16 -0500
Received: from mail-pf0-f193.google.com ([209.85.192.193]:55078 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751097AbdKPBYJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 20:24:09 -0500
X-Google-Smtp-Source: AGs4zMaNym4sSGxsp5R3zQSAA4Fjm7UuAI0uvRV2hz7VvJkmV8XMuDmqADVL4gz2Jvc1GQDOoZnAig==
Subject: Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        USB <linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
References: <20171113002317.29329-1-Badhri@google.com>
 <20171113002317.29329-2-Badhri@google.com>
 <20171114170531.GB1030@roeck-us.net>
 <CAPTae5+FYSEBKGiaarNkg4y4-PwSW4w7S63es_=jbpjTd075+Q@mail.gmail.com>
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <1a9f3fcc-b146-e522-3477-096a31d6c6a2@roeck-us.net>
Date: Wed, 15 Nov 2017 17:24:05 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAPTae5+FYSEBKGiaarNkg4y4-PwSW4w7S63es_=jbpjTd075+Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/15/2017 05:01 PM, Badhri Jagan Sridharan wrote:
> On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck <linux@roeck-us.net> wrote:
[ ... ]
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>> /* Though I really dislike this new-world comment style.
>>   * It hurts my eyes and distracts me from the code.
>>   */
> 
> Did I somehow introduce this ? I dont think I introduced new comments.
> 

[ ... ]

>>> +                                     /* There could only be one fixed pdo
>>> +                                      * at a specific voltage level.
>>> +                                      * So breaking here.
>>> +                                      */

Guenter