From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A33F92DAFAF for ; Mon, 29 Jun 2026 05:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782710596; cv=none; b=AtZDO7PnYO+o/xtAzytCZCHdKfXdfOR+D/G+crSq8UAYb0G0EsMHgL67iI7lcxDf6b4YbmJ7RvAHJQ/1MBBXo+JbMORIJSc6lOMTd4yUW7uDYO/DEIRJyoopzwEqeJVC4XIc15yCJgAK+BYsqTwE1oSykXypQ3vUUQSkxRXNKzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782710596; c=relaxed/simple; bh=ZxqfMVDg3FWeOpe+56ZRiDWXBu8hxTAQ+YpZ4xQsA5o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X5i8FC3rC238fyDc4WSSJ+PiYxyqsjBDoR0GkE1mlpCRCvNcakU/e0XiWC8rJ3TdkweoQrtqJqbKsEBvNfwteJAHCxxgG7Ks4HbrEZm+Vjjj6avCnIC2ak9YpjIjdK3/oOA5OYKS15VWjmGHiKZKEJYI5Adqantd86CHpfJ8z58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nKv15rIA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kQrGs6we; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nKv15rIA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kQrGs6we" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T4NGkq1771372 for ; Mon, 29 Jun 2026 05:23:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cu36DmfqEkFszFBjI/w/JiRPAOrfBwPdCWBBCaxyZ1A=; b=nKv15rIAd8eiPma+ Z2C/yaUcZrVUsUBqftISqyK2WzWM/2uOaBt+BwSqrcbnfKik5mu19W3hOg5FG0bP WqVhG6pW1gGYsTDGz0FRm7K+hbiI5DF8Y2LoZpEtm5dDFjcKg7wGJJH46BHsDtjT wm7ihNakcGvFD2KqzDIj4sgl/iwWEyU8U8nuNmpnwTswGPBLcnexub+YeijjhtyB JGC3DTDVHu/Yi3LOYycYmwl7TD2WAvletgksW/qZRgz+0AllpoUDog8pgQ1OHcDK tWNDEwOItWXh5iBZ1Fne2QSBKxWKY7pdl+MlmrDkBCyy2VKPz77ghguGVkYd4kgB rZiebw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f26tumj2f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 05:23:14 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c825562f8bso17485955ad.2 for ; Sun, 28 Jun 2026 22:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782710594; x=1783315394; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cu36DmfqEkFszFBjI/w/JiRPAOrfBwPdCWBBCaxyZ1A=; b=kQrGs6webdMBF/KX34hKylACdYKeXtDl3kw6MnsWWe0JhBa2vqDO09IR57KeIzhoRA cyd9qjy76WSGW2ZZ/cR+zW8qHHtOUuoGo1/FHHJQNK/xcqFlegyVf/ghPnxEx3hBWr3u emneoohXGf/eq1nkQ4bNQPUQT4xJc+V2aPuaSnXdd06vqsTpPmdLLqVt+G3vRxNzQN6j pNESRDTcWKO+b6bkT6oW092kE0nN19EW6NSGl4Pe7u2NLDfA+/OQF4eUYcnGcdtMZQfx +k4mjSiZl32zftgXIvNcX2aF4sN6QmeSm99QEfEu6ikegrnnmjf9q/9FaMzPngqtPK6c SA7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782710594; x=1783315394; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cu36DmfqEkFszFBjI/w/JiRPAOrfBwPdCWBBCaxyZ1A=; b=StNkyXo4GMm4pRaZHzg7EQQNorgMHMo6KkseQySNrnhmwgWTh8D0wELLO0PNHMchb3 yFbstL2+N3ynEjiLYKqjxe+QbIgCPS+EVIFaj5B3m4YM+CGFkDqIiTuxPv0W3VD/NqBH mTfCKmCas7R+RzBI6bLT0ldDnOtno+9z3tc/11KaIdSa8uJBmOMGRolz+KFbm8/skT/t PuGfheDCmKzVvDV+Qer/0Kv19I80lcVsqQ6PHux4I9r43xb12P0C8BV6D53DF3dTVG7H SYQzBt2B/5ZuglNkmmmhbKRltKixlQ9BbyQfWcEKyY6yfiaQBSnVbadzuPR9SccvhmYl 33kg== X-Forwarded-Encrypted: i=1; AHgh+RoHY+Y7h/Ur2gvG230U3rZOdJIDZ7NpzyVyvvINWaqA4QEUPUT7et7trgB/Ck2hvGLvblSvoawg91BKz24=@vger.kernel.org X-Gm-Message-State: AOJu0YwYjIPi6cGpfQAldKX+X2cp6yR+q3NieYh265Zg2tM5tJYC1KUE AMEYU2u8bKwjBI/CIMV+viOaBIPArJmXkL03jsXn19au/zneURK96HD7g1WmkM8bcs1nA+N8fB8 huRj0QHyZcZgSvR/XnUx7Y/RIj608hkCKIA7M8TvG7y2UCjT9mso2WYW5P+No6SPtxTQ= X-Gm-Gg: AfdE7cklLUSOI8uvZmgbrD6DL3N3MuE6ew8NTWza/s7VwMpv05V+Lx1xiwCjK01nrHP /qp5ILX0Kc94nNHbf2dupsh+E+msENgqD3YAmUHKpKr+mGPs71a+V96qe/h235NZwcLMkiNLdv8 gV91elrSy7BeGDYiPNZF2Z0M3hOmG9n7cxVHnqU1YHnlHdsSFliGzOq/KpKeOOpem4DDn5Sz16e PgTiGLFWtAJoGVtKvFjV4K9aCekBkRVxmYZCIy+B6Zn8k4XzBq64Vz8QmAlkEU9XFtnNrM4vSrL 49nZYdEjbefhg0vUI9ZdKOGdorr2TJ5XARAIiV7gJjyth2X5i/3N59WfBkTap9g/F1OxeOa+V/s UMboD8sFR9/DpXy6w095QR7vQBLnS69gN9O2RI473rug5Gz3iAA== X-Received: by 2002:a17:903:4b03:b0:2c9:deec:f564 with SMTP id d9443c01a7336-2c9deed0010mr38516585ad.13.1782710594239; Sun, 28 Jun 2026 22:23:14 -0700 (PDT) X-Received: by 2002:a17:903:4b03:b0:2c9:deec:f564 with SMTP id d9443c01a7336-2c9deed0010mr38516445ad.13.1782710593804; Sun, 28 Jun 2026 22:23:13 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c9cd6916e3sm29479155ad.40.2026.06.28.22.23.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 22:23:13 -0700 (PDT) Message-ID: <1aa30528-6cec-41cd-9289-a3979c989740@oss.qualcomm.com> Date: Mon, 29 Jun 2026 10:53:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/8] arm64: dts: qcom: shikra: Add gpr node To: Krzysztof Kozlowski , Srinivas Kandagatla , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pratyush Meduri References: <20260616201315.2565115-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260616201315.2565115-4-mohammad.rafi.shaik@oss.qualcomm.com> <7ce8356f-ec09-41e2-a57d-60d20a08e850@kernel.org> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <7ce8356f-ec09-41e2-a57d-60d20a08e850@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: GTmFGkWSO_kwskLkZeFX-xnbiFX-CEyn X-Authority-Analysis: v=2.4 cv=A8Rc+aWG c=1 sm=1 tr=0 ts=6a420142 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=P-IC7800AAAA:8 a=KLxTuU9TmGYBU-aeN2AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: GTmFGkWSO_kwskLkZeFX-xnbiFX-CEyn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA0NCBTYWx0ZWRfX5PNhtLguFAax 8K/aFwXv14KXsQqZosIPq42CIhZvWfY8XEbqWHFovLrhaVXIMf7zgCs+lRr6YBUc788keGksFB3 GVNlKHokkd2166ed0DhoTzljxRVTw2rHz0SS5iA2MOGjWUqmh9BNg/BAoEsNfvHXM+stfYeJpcS UJxJC20LJ/aLPVRXdCGKI47LbST00EcXpwxz47L/o1lCvKbOL2rZDgNumWdSrBKP2jx74Q7X6Of ECLlr5CDfqTXQRb/sKB60hWKVmGfiYKmus2NytFMnOoGzd73KvdBgFUEK/js/i7mqzExHFCwmH+ FxHAHKA0M0k3kV406i4llOeuSxXXrMrQgSAET8bRv1ruw9SqUOk+BUZAyvBIZ2G7hMIvfhaQ7kv P0dy0ZdkrJHe0OUbSR4L+IePpwAtwMgC+7aaYdKPte965aA5yFWU5he6PhYzi7IpWKEL+byD/QY +48I6ftWp/Mi2p3mtag== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA0NCBTYWx0ZWRfX7gR29A++g1lP WWO1iROoqzfSuw+j6g8JDBQFC5G5IBRT1gwYYK3xQxIpo0zVIIMRqsjqjqboY9i63fRA6sLiw6+ 5Wct15Vwui80l6so0dAPpGy5w/c8ZzE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290044 On 6/22/2026 7:14 PM, Krzysztof Kozlowski wrote: > On 16/06/2026 22:13, Mohammad Rafi Shaik wrote: >> Add GPR(Generic Pack router) node along with > > Missing spaces before (. > >> APM(Audio Process Manager) and PRM(Proxy resource >> Manager) audio services. > > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > Thanks, I’ll fix the spacing and update the commit message to follow Linux coding style and wrapping guidelines. > >> @@ -1851,6 +1854,42 @@ glink-edge { >> mboxes = <&apcs_glb 12>; >> qcom,remote-pid = <1>; >> label = "mpss"; >> + >> + gpr: gpr { >> + compatible = "qcom,gpr"; >> + qcom,glink-channels = "modem_apps"; >> + qcom,domain = ; >> + qcom,intents = <200 20>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + q6apm: service@1 { >> + compatible = "qcom,q6apm"; >> + reg = ; >> + #sound-dai-cells = <0>; >> + >> + q6apmbedai: bedais { >> + compatible = "qcom,q6apm-lpass-dais"; >> + #sound-dai-cells = <1>; >> + }; >> + >> + q6apmdai: dais { >> + compatible = "qcom,q6apm-dais"; >> + qcom,vmid = > + QCOM_SCM_VMID_MSS_MSA>; > > I don't understand what is happening here. > Apologies for the confusion. I will update the commit description in the next revision to clearly explain the use of vmid, > Other patch made a change like: > > -qcom,vmid = ; > > But even here you do not have it. > > I don't understand what is happening here, but for now it looks that > this patchset is incorrect and incomplete. > I will also incorporate that change directly into this patchset to avoid confusion caused by multiple parallel threads, and ensure everything is consistent and complete here. Thanks & Regards, Rafi. >> + }; >> + }; >> + > > > Best regards, > Krzysztof