From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E47F2853F3 for ; Mon, 30 Mar 2026 20:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774902859; cv=none; b=JwDoTrs4Hf+pkI6a3/OQg3qpdJP+tUmRpsUJT5HYFC8PyaGxQ3iNIyUZtBIfzktPH8CbPwAgskM6TP18EXuorswIOVbCRefNBmeuecDHBV7Vj/0afh1ODABKQI+Bxz0aOn5VLvzz/zJ2xJniF7C0wTMXSteA/weO/LS+kMYFsdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774902859; c=relaxed/simple; bh=mgyZa6+VAXUFf65uhiIQnesnscUgiwTJgUzZl/hgqo0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o1OiVDqFJqOpg9NRgxDvppcBWUvq5RSpIn+dPFUU1MTEHkhlgpU7GstLfi/3oNtxzjtAhg9NtHuoRJbZk1MtaiP0QbHTkBCc0mJlPXgvoPV/DOWEUgxHugDRdJM/hIs5Y62LwRJbgP1lVNQ2OqMDKC/57UHIXS+gf3H4hwJTPns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YRs6zXdV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gtYqH/cX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YRs6zXdV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gtYqH/cX" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UIwNbU4053308 for ; Mon, 30 Mar 2026 20:34:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GGvHmo/XuIHKu6RSmajSbZfGYuTsJcvqIRS6kB5ctsw=; b=YRs6zXdVjv4lA3Vb 4ZSgQmNHGhNNi1t/Hcu8pBkwxkhBjx5QGgAiMlD7EEQ3ooSVV/98KWcJ0DL505f5 ynQGDMBwWu5eMso83EOU1AzqwQmpKZfhJj7pLeX4RYMlPlvfWEzZ62kbw3BwdzGM Yus3vr11v4lJIWG/I6P1m9kV6iCz1DLyidaUyynFuwszY3JIOmXGud4JSmjPuq6Y hqRrmeQcQarCnDnHCFRAQW71EsBgCuO6NupRhVpAa9K3er95fpzk56S6fcNUNIlv q+mydM2aFAFiho8Ni04BD29VyfVycK/tLuhU2fYWYLqwyuDqwmF+nTCrn1y/qnqC 4em6AA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7xx38a3p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 20:34:17 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35dacc40f92so1284710a91.2 for ; Mon, 30 Mar 2026 13:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774902857; x=1775507657; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GGvHmo/XuIHKu6RSmajSbZfGYuTsJcvqIRS6kB5ctsw=; b=gtYqH/cXru9Enm2N79ggB4dFOf8TgK7HIrazkqVYBi9iWXU8B/l9+FKqGXgVnfCgMJ ZMj2mNO7jmsHqwijXSTsskyVo2769pqzUjYWkFmqdJYuDTP9aTnABbqolCAndeFexYT2 m1QXmElgVa97m5ATDyOGtbLRLGU9zjfqbAcbb0jw72xLNPbEocduvsVkx05w5AtJzCAk uA5L3intGsQR8nJXZuBAhA+c2lGewYnptSgUA3wXhHPKQnsQ7T9euYYtK3fa031sAa/c WcpanPguJUAZasYgKOgpr2RhcihFtlqYzKmkEWq6F99wBBIFr6fFGaU8xiR1tzGooh71 HQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774902857; x=1775507657; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GGvHmo/XuIHKu6RSmajSbZfGYuTsJcvqIRS6kB5ctsw=; b=RzZ6bXUytZD4+qEFzBu2DD79bYnnZLvXw6uAuVoC6Q//8dGEBtiRKNsrxhnG5XWS1T hdewlPzS/C7m4B9Z6QPhQSuJT+yw8AaYLn6vUHQ8qyxzaO4fluVkbhjfAzvOKlzaRCRo +7pV01METbVbuF7I9j9pAYXrCP/Vdg7mPs+BsehpaCupq8iVWDgv0cL7tqnjw+1UquLV zzCfn98ejmdI2Ev7QOJLmRJUPoRM3a0Ca85obL49SR9/KNAieiooz/ynAob7jZhvhLWb 4clxMOpEfuEvZ+UQkgs40pQJXDI2xzpKQv7Au+4R/y8uJki2y6dOt20OCkLU+ZUWMArB 0ESg== X-Forwarded-Encrypted: i=1; AJvYcCXvHdXSdz/ijDIDuHzCBlVx1dbl4JwLeKmEj4ouxwkl8Znt6tuTfyRRrcw1NHV3uHPylAEPEhswfAHRRbE=@vger.kernel.org X-Gm-Message-State: AOJu0YyHsy+4BVPd6IPJx/w27skGFwi4xten13mw0rzos+Ix2fFMSaLd Nr9DCt50GpdUORci0vxijU08yQLQCsDIX+G4VOyGXtY+XJ99tq0iPjU6u9WODIK9IWIcxS9tOAl iAcGDbIcF90GAM8jCjoBooF/Jx/ed0kjogeAvlI5SQI66A4k4aeeXw5ConjKoiQzg1y8= X-Gm-Gg: ATEYQzyGUDjhDLR1QmkVtMO88HXtlphurRjlEQDjHwY90toXP1zy9r2IGAyGxK5fxX/ hEEB2Uon5Peug1O9kYslaTNfcJ17v0slxyIY8Q/DCVH/9UbeEsHEs5JRPS041rHeEUxnSaYi9KD lXwzCTvRFYyzv0pcFcr6WmiiXgYRKZnseFui48IQdClrroTbeg4IL8Lfk4DkWsrfA0/PGshwZHX JrfqdPWHeM21tB3v7VEDUuf2wKn4krWWx9Dfgvsywe84ap9t70bcgNs1DBrsdQb0S5LKH8AxwD/ SWIfdXlF4GYupCKWS0yyMJltHhC7OOd9oIgcHbLYaPXBoakXVR+YzSXovvRpol5EsRY5+PRMguG 57aqRuRIioA38s6i6YNCJQKH2QnsFg+QTQEaM8a8+csDR X-Received: by 2002:a17:90b:1d11:b0:35c:a8f:5c5f with SMTP id 98e67ed59e1d1-35c2ff6afecmr12444972a91.8.1774902856882; Mon, 30 Mar 2026 13:34:16 -0700 (PDT) X-Received: by 2002:a17:90b:1d11:b0:35c:a8f:5c5f with SMTP id 98e67ed59e1d1-35c2ff6afecmr12444951a91.8.1774902856401; Mon, 30 Mar 2026 13:34:16 -0700 (PDT) Received: from [10.91.121.222] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35daaf2a70dsm3488317a91.11.2026.03.30.13.34.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 13:34:15 -0700 (PDT) Message-ID: <1aa49c9c-279d-421e-879f-d0d93728841b@oss.qualcomm.com> Date: Tue, 31 Mar 2026 02:04:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/17] drm/msm/a8xx: Implement IFPC support for A840 To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-14-2b53c38d2101@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ErbfbCcA c=1 sm=1 tr=0 ts=69cade49 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=khfaMGtS6DP7kCttXrYA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: QhXUjhQ8FSj3Bzp9Y3AYSrem4YO990u5 X-Proofpoint-GUID: QhXUjhQ8FSj3Bzp9Y3AYSrem4YO990u5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDE3MiBTYWx0ZWRfXxoxGmmlv6Ji1 DRPy9/anYEkBxTHC+iqMWVgl7aeQL8VWh/o6DPruIl/6Dz6BF4Q4gYVLH/vTqlZdscJwqPVc4td TOrj/vOa9hu/70fPCWvcjQk0+q2YXNBDLcu35lp05Q3/JK7ohWlCRFo+rc5XiLY6zqmgXDNBzJv PYfrrVUgqh5UMKIeQGg3N+WBU6ZXRAQk8WuB5MrYVBee9gsd7cGk7hDvRQwdeoeZpZv7dsBq61y YYdblyAey+AnV+RUmYkElUfhf3HtFeSlBIpKzzu8HqM5acXc+ZazknaS5mruvj7/8qTw6MTkEhh lwVdFs7u7iwWj6MYSQOfSyLtWRWlJrMTj6uiZYa6OHQ8YHi7Qj5Y0/PrkT2Jk4WLRkGG7tzMwgP mQrOO1yfxkf/9nhZF2s+pHdLLb2+76bPcFabWnMceTs73V71SSxVUJZaVheYa5dmza1rgrYWhWw puT+X+C275qd1hTxgVg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-30_01,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300172 On 3/27/2026 4:37 PM, Konrad Dybcio wrote: > On 3/27/26 1:14 AM, Akhil P Oommen wrote: >> Implement pwrup reglist support and add the necessary register >> configurations to enable IFPC support on A840 >> >> Signed-off-by: Akhil P Oommen >> --- > > [...] > >> + REG_A8XX_CP_PROTECT_GLOBAL(51), >> + REG_A8XX_CP_PROTECT_GLOBAL(52), >> + REG_A8XX_CP_PROTECT_GLOBAL(53), >> + REG_A8XX_CP_PROTECT_GLOBAL(54), >> + REG_A8XX_CP_PROTECT_GLOBAL(55), >> + REG_A8XX_CP_PROTECT_GLOBAL(56), >> + REG_A8XX_CP_PROTECT_GLOBAL(57), >> + REG_A8XX_CP_PROTECT_GLOBAL(58), >> + REG_A8XX_CP_PROTECT_GLOBAL(59), >> + REG_A8XX_CP_PROTECT_GLOBAL(60), >> + REG_A8XX_CP_PROTECT_GLOBAL(61), >> + REG_A8XX_CP_PROTECT_GLOBAL(62), > > 53..62 aren't listed by kgsl, but I suppose this is more robust > > Similarly for: > > SP_CHICKEN_BITS_4 > RBBM_PERFCTR_CNTL I can see SP_CHICKEN_BITS_4 in the recent kgsl code. RBBM_PERFCTR_CNTL is required as we don't handle perfcounter management in this driver yet. > > The other reglists look OK > > [...] > >> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_DDE_BV; pipe_id++) { >> + for (i = 0; i < dyn_pwrup_reglist->count; i++) { >> + if (!(dyn_pwrup_reglist->regs[i].pipe & BIT(pipe_id))) >> + continue; >> + *dest++ = A8XX_CP_APERTURE_CNTL_HOST_PIPEID(pipe_id); >> + *dest++ = dyn_pwrup_reglist->regs[i].offset; >> + *dest++ = a8xx_read_pipe_slice(gpu, >> + pipe_id, >> + a8xx_get_first_slice(a6xx_gpu), > > IDK if the compiler is smart enough to pick it up itself, but > you could do const u32 first_slice = a8xx.. beforehand to save a > couple cycles This code is not called frequent enough to worry about micro optimizations. > > [...] > >> + if (!a6xx_gpu->pwrup_reglist_emitted) { >> + a8xx_patch_pwrup_reglist(gpu); >> + a6xx_gpu->pwrup_reglist_emitted = true; > > Would this flag be better set in the function above? Agree, but we should update a6xx_gpu.c too. Lets do that separately. -Akhil. > > Konrad