From: "Mike Frysinger" <vapier@gentoo.org>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/video_{de,en}coder.h: cleanup for userspace
Date: Mon, 27 Oct 2008 23:34:03 -0400 [thread overview]
Message-ID: <1aad82fa0810272034o22341562sbedcb098ba506bee@mail.gmail.com> (raw)
In-Reply-To: <20081027203103.be272647.akpm@linux-foundation.org>
On Mon, Oct 27, 2008 at 11:31 PM, Andrew Morton wrote:
> On Sun, 26 Oct 2008 06:47:44 -0400 Mike Frysinger wrote:
>> Make sure the linux/video_{de,en}coder.h header files include other header
>> files that they use (for types and structures).
>
> checkpatch (amazing tool, and it's free!) said:
>
> ERROR: Don't use <linux/videodev.h>: see Documentation/feature-removal-schedule.txt
> #23: FILE: include/linux/video_decoder.h:5:
> +#include <linux/videodev.h>
>
> so I'll drop this one.
maybe, but video_decoder.h def uses things in linux/videodev.h today.
if we add the include, hopefully it'll help people realize they need
to remove the relevant things from video_decoder.h as well.
-mike
prev parent reply other threads:[~2008-10-28 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 10:47 Mike Frysinger
2008-10-28 3:31 ` Andrew Morton
2008-10-28 3:34 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aad82fa0810272034o22341562sbedcb098ba506bee@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®