From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 078B2C433E0 for ; Thu, 21 Jan 2021 15:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6FE8238E3 for ; Thu, 21 Jan 2021 15:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732285AbhAUPBm (ORCPT ); Thu, 21 Jan 2021 10:01:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26542 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbhAUPBP (ORCPT ); Thu, 21 Jan 2021 10:01:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611241188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VWveDnvQfP+PsL4unltCL6r/BDFmk40wyGsyzqSzMPQ=; b=CCV4+O9MlTuQUe1mf3BRsmYSXkTVJrwXD28BL5o9jiwF6t3iIpV1y7/zALZWczYkxwuFgD RK6tZsrdufBfmUxoULpOfDM9gYLu7RYXHkoIVLlifH6LeB026wvR5Vke2gP+ychj61Jz7E h2tza4R+lEwi04XSsH0vqq7QtcT5/r0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-SYHe7PS1PyuFlFv3J79wVg-1; Thu, 21 Jan 2021 09:59:46 -0500 X-MC-Unique: SYHe7PS1PyuFlFv3J79wVg-1 Received: by mail-ej1-f72.google.com with SMTP id h18so856723ejx.17 for ; Thu, 21 Jan 2021 06:59:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VWveDnvQfP+PsL4unltCL6r/BDFmk40wyGsyzqSzMPQ=; b=rzko+Aqr5wQDxf+0X1SOW32/yXOXFljIOpN5SnbDbQNXHmKHMkDjyOBrNlo0ugSBnz AxLyfUPxZr3Q8g8dHLipCupgMfvi0O4mnlbzr1+aJXMObwrNzfh1S/D/DPFIWGDjbg6S WTt+vl3g9Z3sZ6ETt7Skrwb+f4mrcsaBqICeS8QzuOzH9L6E+AdhJJLGBnTI9akVZaci BQ8Qk/wRLZqu+YuXaRc+AFe68hLwctbi5EhcH6Odmd4Y6/xNdXj+kMUmJFL8/pfiVE6q OFWchnTlnySef4PvdVILAiU+bG5hGOgsaU7Mwt9evWEHjCBdKpuz7sU/9W/cG8zq605/ 1CmA== X-Gm-Message-State: AOAM533G1v0KgI+lbu3TY2DRkT6FDCJf9+b9TlYHO0X6MCKpcCkj4nna 6540LQJKSIklYa3tiZ8Ap2rjdtWHoBp8+Nw0Id810ZSNt28CcBGHeoDnf7uo2sqfHMNmmof+PdG WUzUezZZGO8Ww25jrFK1sonql X-Received: by 2002:a50:fa86:: with SMTP id w6mr8174052edr.98.1611241184842; Thu, 21 Jan 2021 06:59:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzShcRHvjWlak25wOw0kLg65aNYi5H/RRWjjGEc3kLqFCIKI8oid0c0yjtkv6UmnKvGy/pGGg== X-Received: by 2002:a50:fa86:: with SMTP id w6mr8174036edr.98.1611241184707; Thu, 21 Jan 2021 06:59:44 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id f9sm2905661edm.6.2021.01.21.06.59.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 06:59:43 -0800 (PST) Subject: Re: [PATCH v2 1/3] KVM: nVMX: Always call sync_vmcs02_to_vmcs12_rare on migration To: Sean Christopherson , Maxim Levitsky Cc: kvm@vger.kernel.org, Thomas Gleixner , x86@kernel.org, Borislav Petkov , Ingo Molnar , Vitaly Kuznetsov , Joerg Roedel , Wanpeng Li , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Jim Mattson References: <20210114205449.8715-1-mlevitsk@redhat.com> <20210114205449.8715-2-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <1aadff70-afed-ba8f-411f-c8aac1518098@redhat.com> Date: Thu, 21 Jan 2021 15:59:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/01/21 00:58, Sean Christopherson wrote: > Reviewed-by: Sean Christopherson New commit message: KVM: nVMX: Sync unsync'd vmcs02 state to vmcs12 on migration Even when we are outside the nested guest, some vmcs02 fields may not be in sync vs vmcs12. This is intentional, even across nested VM-exit, because the sync can be delayed until the nested hypervisor performs a VMCLEAR or a VMREAD/VMWRITE that affects those rarely accessed fields. However, during KVM_GET_NESTED_STATE, the vmcs12 has to be up to date to be able to restore it. To fix that, call copy_vmcs02_to_vmcs12_rare() before the vmcs12 contents are copied to userspace. Paolo